On Wed, 4 Aug 2010, Attilio Rao wrote:
This bug seems also to affect the 6.x backport of rwlocks that Alfred did.
Might either you or Alfred consider doing an MFC of this change? Without
it, recursive write locks on rwlocks are broken with INVARIANTS enabled.
Thanks for signaling this, I'll
2010/8/4 Attilio Rao :
> 2010/8/4 Robert Watson :
>> On Wed, 14 Nov 2007, Attilio Rao wrote:
>>
>>> attilio 2007-11-14 21:21:48 UTC
>>>
>>> FreeBSD src repository
>>>
>>> Modified files:
>>> sys/kern kern_rwlock.c
>>> Log:
>>> Remove a bogus KASSERT which will prevent rwlock t
2010/8/4 Robert Watson :
> On Wed, 14 Nov 2007, Attilio Rao wrote:
>
>> attilio 2007-11-14 21:21:48 UTC
>>
>> FreeBSD src repository
>>
>> Modified files:
>> sys/kern kern_rwlock.c
>> Log:
>> Remove a bogus KASSERT which will prevent rwlock to be acquired
>> recursively in ex
On Wed, 14 Nov 2007, Attilio Rao wrote:
attilio 2007-11-14 21:21:48 UTC
FreeBSD src repository
Modified files:
sys/kern kern_rwlock.c
Log:
Remove a bogus KASSERT which will prevent rwlock to be acquired
recursively in exclusive mode with debugging kernels.
Submitted b
rwatson 2008-08-08 14:36:21 UTC
FreeBSD src repository
Modified files:(Branch: RELENG_7)
sys/kern kern_rwlock.c
sys/sys rwlock.h
Log:
SVN rev 181429 on 2008-08-08 14:36:21Z by rwatson
Merge r177843,178147 from head to stable/7:
Ad
jeff2008-04-04 10:00:46 UTC
FreeBSD src repository
Modified files:
sys/kern kern_rwlock.c
Log:
- Add sysctls at debug.rwlock to control the behavior of the speculative
spinning when readers hold a lock. This spinning is speculative because,
unlike the
On Wed, 2 Apr 2008, Max Laier wrote:
On Wednesday 02 April 2008 09:15:25 Jeff Roberson wrote:
On Wed, 2 Apr 2008, Max Laier wrote:
On Wednesday 02 April 2008 03:11:11 Jeff Roberson wrote:
On Wed, 2 Apr 2008, Attilio Rao wrote:
2008/4/2, Max Laier <[EMAIL PROTECTED]>:
On Wednesday 02 April 2
On Wed, 2 Apr 2008, David Schultz wrote:
On Tue, Apr 01, 2008, Jeff Roberson wrote:
On Wed, 2 Apr 2008, Max Laier wrote:
On Tuesday 01 April 2008 22:31:55 Attilio Rao wrote:
attilio 2008-04-01 20:31:55 UTC
FreeBSD src repository
Modified files:
sys/kern kern_rwlock.c
On Tue, Apr 01, 2008, Jeff Roberson wrote:
> On Wed, 2 Apr 2008, Max Laier wrote:
>
> >On Tuesday 01 April 2008 22:31:55 Attilio Rao wrote:
> >>attilio 2008-04-01 20:31:55 UTC
> >>
> >> FreeBSD src repository
> >>
> >> Modified files:
> >>sys/kern kern_rwlock.c
> >>sys/sy
On Wednesday 02 April 2008 09:15:25 Jeff Roberson wrote:
> On Wed, 2 Apr 2008, Max Laier wrote:
> > On Wednesday 02 April 2008 03:11:11 Jeff Roberson wrote:
> >> On Wed, 2 Apr 2008, Attilio Rao wrote:
> >>> 2008/4/2, Max Laier <[EMAIL PROTECTED]>:
> On Wednesday 02 April 2008 00:52:45 Jeff Rob
2008/4/2, Jeff Roberson <[EMAIL PROTECTED]>:
>
> On Wed, 2 Apr 2008, Attilio Rao wrote:
>
>
> > 2008/4/2, Max Laier <[EMAIL PROTECTED]>:
> >
> > > On Wednesday 02 April 2008 00:52:45 Jeff Roberson wrote:
> > > > On Wed, 2 Apr 2008, Max Laier wrote:
> > > >> On Tuesday 01 April 2008 22:31:55 Attili
On Tue, 1 Apr 2008, Jeff Roberson wrote:
On Wed, 2 Apr 2008, Max Laier wrote:
On Wednesday 02 April 2008 03:11:11 Jeff Roberson wrote:
On Wed, 2 Apr 2008, Attilio Rao wrote:
2008/4/2, Max Laier <[EMAIL PROTECTED]>:
On Wednesday 02 April 2008 00:52:45 Jeff Roberson wrote:
On Wed, 2 Apr 2008
On Tue, 1 Apr 2008, Jeff Roberson wrote:
I don't think this is a good thing either, but I also think that there are
some cases where there just are different access orders. I'd rather want a
clean way out of this than a lot of difficult per-instance hacks. This
does not mean that these can'
On Wed, 2 Apr 2008, Max Laier wrote:
On Wednesday 02 April 2008 03:11:11 Jeff Roberson wrote:
On Wed, 2 Apr 2008, Attilio Rao wrote:
2008/4/2, Max Laier <[EMAIL PROTECTED]>:
On Wednesday 02 April 2008 00:52:45 Jeff Roberson wrote:
On Wed, 2 Apr 2008, Max Laier wrote:
On Tuesday 01 April 200
On Wednesday 02 April 2008 03:11:11 Jeff Roberson wrote:
> On Wed, 2 Apr 2008, Attilio Rao wrote:
> > 2008/4/2, Max Laier <[EMAIL PROTECTED]>:
> >> On Wednesday 02 April 2008 00:52:45 Jeff Roberson wrote:
> >> > On Wed, 2 Apr 2008, Max Laier wrote:
> >> >> On Tuesday 01 April 2008 22:31:55 Attilio
On Wed, 2 Apr 2008, Attilio Rao wrote:
2008/4/2, Max Laier <[EMAIL PROTECTED]>:
On Wednesday 02 April 2008 00:52:45 Jeff Roberson wrote:
> On Wed, 2 Apr 2008, Max Laier wrote:
>> On Tuesday 01 April 2008 22:31:55 Attilio Rao wrote:
>>> attilio 2008-04-01 20:31:55 UTC
>>>
>>> FreeBSD src
2008/4/2, Max Laier <[EMAIL PROTECTED]>:
> On Wednesday 02 April 2008 00:52:45 Jeff Roberson wrote:
> > On Wed, 2 Apr 2008, Max Laier wrote:
> > > On Tuesday 01 April 2008 22:31:55 Attilio Rao wrote:
> > >> attilio 2008-04-01 20:31:55 UTC
> > >>
> > >> FreeBSD src repository
> > >>
> >
On Wednesday 02 April 2008 00:52:45 Jeff Roberson wrote:
> On Wed, 2 Apr 2008, Max Laier wrote:
> > On Tuesday 01 April 2008 22:31:55 Attilio Rao wrote:
> >> attilio 2008-04-01 20:31:55 UTC
> >>
> >> FreeBSD src repository
> >>
> >> Modified files:
> >> sys/kern kern_rwlock.
Max Laier wrote:
On Tuesday 01 April 2008 22:31:55 Attilio Rao wrote:
attilio 2008-04-01 20:31:55 UTC
FreeBSD src repository
Modified files:
sys/kern kern_rwlock.c
sys/sys rwlock.h
Log:
Add rw_try_rlock() and rw_try_wlock() to rwlocks.
These funct
On Wed, 2 Apr 2008, Max Laier wrote:
On Tuesday 01 April 2008 22:31:55 Attilio Rao wrote:
attilio 2008-04-01 20:31:55 UTC
FreeBSD src repository
Modified files:
sys/kern kern_rwlock.c
sys/sys rwlock.h
Log:
Add rw_try_rlock() and rw_try_wlock() to r
On Tuesday 01 April 2008 22:31:55 Attilio Rao wrote:
> attilio 2008-04-01 20:31:55 UTC
>
> FreeBSD src repository
>
> Modified files:
> sys/kern kern_rwlock.c
> sys/sys rwlock.h
> Log:
> Add rw_try_rlock() and rw_try_wlock() to rwlocks.
> These functio
attilio 2008-04-01 20:31:55 UTC
FreeBSD src repository
Modified files:
sys/kern kern_rwlock.c
sys/sys rwlock.h
Log:
Add rw_try_rlock() and rw_try_wlock() to rwlocks.
These functions try the specified operation (rlocking and wlocking) and
true is
jhb 2008-02-12 19:16:53 UTC
FreeBSD src repository
Modified files:(Branch: RELENG_7)
sys/kern kern_rwlock.c
Log:
MFC: Remove a conditional that is always true.
Revision ChangesPath
1.28.4.3 +1 -1 src/sys/kern/kern_rwlock.c
___
jeff2008-02-07 06:16:54 UTC
FreeBSD src repository
Modified files:
sys/kern kern_rwlock.c
Log:
- In rw_wunlock_hard prefer to wakeup writers if there are both readers
and writers available. Doing otherwise can cause deadlocks as no
read locks can proce
jhb 2008-01-17 20:15:15 UTC
FreeBSD src repository
Modified files:
sys/kern kern_rwlock.c
Log:
Remove a conditional that is always true.
MFC after: 2 weeks
Revision ChangesPath
1.34 +1 -1 src/sys/kern/kern_rwlock.c
_
attilio 2007-11-14 23:33:41 UTC
FreeBSD src repository
Modified files:(Branch: RELENG_7)
sys/kern kern_rwlock.c
Log:
MFC: revision 1.30
Approved by: re
Revision ChangesPath
1.28.4.1 +0 -3 src/sys/kern/kern_rwlock.c
__
attilio 2007-11-14 21:21:48 UTC
FreeBSD src repository
Modified files:
sys/kern kern_rwlock.c
Log:
Remove a bogus KASSERT which will prevent rwlock to be acquired
recursively in exclusive mode with debugging kernels.
Submitted by: kmacy
Approved by: jeff
jhb 2007-09-27 18:06:49 UTC
FreeBSD src repository
Modified files:(Branch: RELENG_6)
sys/kern kern_rwlock.c
Log:
A few tweaks to reduce diffs with HEAD including using lock_init() and
lock_destroy() and adding a missing #include so that NO_ADAPTIVE_RWLOC
alfred 2007-09-05 22:18:39 UTC
FreeBSD src repository
Modified files:(Branch: RELENG_6)
sys/kern kern_rwlock.c
Log:
Remove/refactor calls to turnstile_release() as it turns out that
turnstile_unpend_queue() drops the lock that turnstile_release()
does. T
attilio 2007-07-20 08:43:42 UTC
FreeBSD src repository
Modified files:
sys/kern kern_rwlock.c
sys/sys rwlock.h
Log:
Fix some problems with lock profiling in rw locks:
- Adjust lock_profiling stubs semantic in the hard functions in order to be
m
attilio 2007-06-26 21:31:56 UTC
FreeBSD src repository
Modified files:
sys/kern kern_rwlock.c
sys/sys _rwlock.h rwlock.h
Log:
Introduce a new rwlocks initialization function: rw_init_flags.
This is very similar to sx_init_flags: it initializes the
jhb 2007-05-08 21:51:37 UTC
FreeBSD src repository
Modified files:
sys/kern kern_rwlock.c kern_sx.c
sys/sys rwlock.h sx.h
Log:
Add destroyed cookie values for sx locks and rwlocks as well as extra
KASSERTs so that any lock operations on a destr
jhb 2007-03-30 18:08:55 UTC
FreeBSD src repository
Modified files:
sys/kern kern_rwlock.c
Log:
- Drop memory barriers in rw_try_upgrade(). We don't need an 'acq' memory
barrier here as the earlier rw_rlock() already contained one.
- Comment fix.
Revisi
jhb 2007-03-13 16:51:27 UTC
FreeBSD src repository
Modified files:
sys/kern kern_rwlock.c
Log:
Print readers count as unsigned in ddb 'show lock'.
Submitted by: attilio
Revision ChangesPath
1.20 +2 -2 src/sys/kern/kern_rwlock.c
___
jhb 2007-03-12 20:10:29 UTC
FreeBSD src repository
Modified files:
sys/kern kern_rwlock.c
Log:
Fix a typo.
Revision ChangesPath
1.19 +1 -1 src/sys/kern/kern_rwlock.c
___
cvs-all@freebsd.org mailing
jhb 2007-03-07 20:48:48 UTC
FreeBSD src repository
Modified files:
sys/kern kern_rwlock.c
Log:
Fix some nits in lock profiling for rwlocks:
- Properly note when a read lock is released.
- Always note when we contest on a read lock.
- Only note success of obt
jhb 2006-04-19 21:06:52 UTC
FreeBSD src repository
Modified files:
sys/kern kern_rwlock.c
sys/sys rwlock.h
Log:
Implement rw_try_upgrade() and rw_downgrade(). rw_try_upgrade() makes a
single attempt at upgrading a read lock to a write lock, an
wkoszek 2006-04-18 20:32:42 UTC
FreeBSD src repository
Modified files:
sys/kern kern_rwlock.c
Log:
'owner' is not used without SMP. Fix kernel build for such kernel
configurations.
Approved by:jhb
Revision ChangesPath
1.8 +4 -0 src/sy
jhb 2006-04-18 18:27:54 UTC
FreeBSD src repository
Modified files:
sys/kern kern_rwlock.c
Log:
Adaptively spin before blocking on the turnstile if an rwlock is write
locked. In general the adaptive spinning is similar to the same code
for mutexes with some ex
jhb 2006-04-17 21:11:01 UTC
FreeBSD src repository
Modified files:
sys/kern kern_rwlock.c
Log:
- Add a rw_wowner() macro that just returns the owner of a write lock and
use it in places that only care about the write owner instead of
rw_owner() as a baby s
Scott Long wrote:
> scottl 2006-02-01 04:18:08 UTC
>
> FreeBSD src repository
>
> Modified files:
> sys/kern kern_rwlock.c
> Log:
> Fix another compile problem. If I find any more, this file is going in the
> Attic until it is properly fixed.
Without supper I pr
scottl 2006-02-01 04:18:08 UTC
FreeBSD src repository
Modified files:
sys/kern kern_rwlock.c
Log:
Fix another compile problem. If I find any more, this file is going in the
Attic until it is properly fixed.
Revision ChangesPath
1.5 +1 -1 src
scottl 2006-01-30 19:25:52 UTC
FreeBSD src repository
Modified files:
sys/kern kern_rwlock.c
Log:
Regroup order of operations to better reflect what was probably intended.
Submitted by: Peter Jeremy
Revision ChangesPath
1.4 +3 -3 src/sys/k
Peter Jeremy wrote:
On Sun, 2006-Jan-29 20:48:25 +, Scott Long wrote:
gcc can't
figure out the order of operations at line 519, and neither can I, but this
is my best guess. Also correct a number of typos and syntax errors.
Revision ChangesPath
1.3 +4 -4 src/sys/kern/kern_
On Sun, 2006-Jan-29 20:48:25 +, Scott Long wrote:
> gcc can't
> figure out the order of operations at line 519, and neither can I, but this
> is my best guess. Also correct a number of typos and syntax errors.
>
> Revision ChangesPath
> 1.3 +4 -4 src/sys/kern/kern_rwlock
scottl 2006-01-29 20:48:25 UTC
FreeBSD src repository
Modified files:
sys/kern kern_rwlock.c
Log:
Take a stab at making this compile when WITNESS is not defined. gcc can't
figure out the order of operations at line 519, and neither can I, but this
is my best gue
mlaier 2006-01-29 02:35:22 UTC
FreeBSD src repository
Modified files:
sys/kern kern_rwlock.c
Log:
Unbreak on archs where %d doesn't print uintptr_t arithmetic.
Revision ChangesPath
1.2 +2 -1 src/sys/kern/kern_rwlock.c
__
47 matches
Mail list logo
