Re: cvs commit: src/sys/dev/bge if_bge.c

2008-01-22 Thread Xin LI
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Jung-uk Kim wrote: > jkim2008-01-22 17:30:13 UTC > > FreeBSD src repository > > Modified files:(Branch: RELENG_7_0) > sys/dev/bge if_bge.c > Log: > MFC:1.201 > > Fix mbuf pool watermark configuration. >

Re: cvs commit: src/sys/dev/bge if_bge.c if_bgereg.h src/sys/dev/mii brgphy.c brgphyreg.h miidevs

2007-03-21 Thread Jung-uk Kim
On Wednesday 21 March 2007 06:53 pm, Jung-uk Kim wrote: > jkim2007-03-21 22:53:22 UTC > > FreeBSD src repository > > Modified files:(Branch: RELENG_6) > sys/dev/bge if_bge.c if_bgereg.h > sys/dev/mii brgphy.c brgphyreg.h miidevs > Log: > MFC: Sync b

Re: cvs commit: src/sys/dev/bge if_bge.c

2007-03-12 Thread Ruslan Ermilov
Hi Scott, On Mon, Mar 12, 2007 at 09:25:57AM +, Scott Long wrote: > scottl 2007-03-12 09:25:57 UTC > > FreeBSD src repository > > Modified files: > sys/dev/bge if_bge.c > Log: > Add MAC, RX, and TX stats reporting via sysctl. > > Revision ChangesPath >

Re: cvs commit: src/sys/dev/bge if_bge.c

2007-03-07 Thread Jung-uk Kim
On Wednesday 07 March 2007 07:49 pm, Jung-uk Kim wrote: > jkim2007-03-08 00:49:27 UTC > > FreeBSD src repository > > Modified files: > sys/dev/bge if_bge.c > Log: > Use correct bits to stop firmware when ASF mode is enabled. I should have said 'reset', not 'stop'. >

Re: cvs commit: src/sys/dev/bge if_bge.c

2007-03-06 Thread Jung-uk Kim
On Tuesday 06 March 2007 03:42 pm, Ruslan Ermilov wrote: > On Tue, Mar 06, 2007 at 07:15:16PM +, Jung-uk Kim wrote: > > jkim2007-03-06 19:15:16 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/dev/bge if_bge.c > > Log: > > Pollute bge(4) with #if's

Re: cvs commit: src/sys/dev/bge if_bge.c

2007-03-06 Thread Ruslan Ermilov
On Tue, Mar 06, 2007 at 07:15:16PM +, Jung-uk Kim wrote: > jkim2007-03-06 19:15:16 UTC > > FreeBSD src repository > > Modified files: > sys/dev/bge if_bge.c > Log: > Pollute bge(4) with #if's and #ifdef's to make MFC easier. > > MFC after: 3 days > >

Re: cvs commit: src/sys/dev/bge if_bge.c

2006-12-27 Thread John Baldwin
On Saturday 16 December 2006 09:19, John Baldwin wrote: > On Friday 15 December 2006 20:42, John Polstra wrote: > > On 15-Dec-2006 David O'Brien wrote: > > > On Fri, Dec 15, 2006 at 01:26:55PM -0800, Peter Grehan wrote: > > >> >I have a Tyan K8W (s2885) which I experienced this on: > > >> > > >>

Re: cvs commit: src/sys/dev/bge if_bge.c

2006-12-24 Thread Andre Oppermann
Bruce Evans wrote: On Sun, 24 Dec 2006, Scott Long wrote: Bruce Evans wrote: On Sat, 23 Dec 2006, Robert Watson wrote: On Sat, 23 Dec 2006, John Polstra wrote: That said, dropping and regrabbing the driver lock in the rxeof routine of any driver is bad. It may be safe to do, but it incurs

Re: cvs commit: src/sys/dev/bge if_bge.c

2006-12-24 Thread Poul-Henning Kamp
In message <[EMAIL PROTECTED]>, Bruce Evans writes: >Be careful with micro-optimizations. I saw a single change (adding >about 1K in unrelated code that is never executed) give a pessimization >of 15% for tx bge (from 360 kpps to 300 kpps). It is still a good idea to also disable caches or also

Re: cvs commit: src/sys/dev/bge if_bge.c

2006-12-24 Thread Bruce Evans
On Sun, 24 Dec 2006, Robert Watson wrote: From the perspective of optimizing these particular paths, small packet sizes best reveal processing overhead up to about the TCP/socket buffer layer on modern hardware (DMA, etc). The uni/bidirectional axis is interesting because it helps reveal the

Re: cvs commit: src/sys/dev/bge if_bge.c

2006-12-24 Thread Bruce Evans
On Sun, 24 Dec 2006, Scott Long wrote: Bruce Evans wrote: On Sun, 24 Dec 2006, Oleg Bulyzhin wrote: it's quite unusal) and it is not lock related: 1) bge_start_locked() & bge_encap fills tx ring. 2) during next 5 seconds we do not have packets for transmit (i.e. no bge_start_locked() calls

Re: cvs commit: src/sys/dev/bge if_bge.c

2006-12-24 Thread Bruce Evans
On Sun, 24 Dec 2006, Scott Long wrote: Bruce Evans wrote: On Sat, 23 Dec 2006, Robert Watson wrote: On Sat, 23 Dec 2006, John Polstra wrote: That said, dropping and regrabbing the driver lock in the rxeof routine of any driver is bad. It may be safe to do, but it incurs horrible performan

Re: cvs commit: src/sys/dev/bge if_bge.c

2006-12-24 Thread Robert Watson
On Sun, 24 Dec 2006, Scott Long wrote: I try this experiement every few years, and generally don't measure much improvement. I'll try it again with 10gbps early next year once back in the office again. The more interesting transition is between the link layer and the network layer, which is

Re: cvs commit: src/sys/dev/bge if_bge.c

2006-12-23 Thread Scott Long
Bruce Evans wrote: On Sun, 24 Dec 2006, Oleg Bulyzhin wrote: On Fri, Dec 22, 2006 at 01:24:45AM +1100, Bruce Evans wrote: On Wed, 20 Dec 2006, Gleb Smirnoff wrote: I have a suspicion that this may cause a problem under high load. Imagine that thread #1 is spinning in bge_start_locked() get

Re: cvs commit: src/sys/dev/bge if_bge.c

2006-12-23 Thread Scott Long
Bruce Evans wrote: On Sat, 23 Dec 2006, Robert Watson wrote: On Sat, 23 Dec 2006, John Polstra wrote: That said, dropping and regrabbing the driver lock in the rxeof routine of any driver is bad. It may be safe to do, but it incurs horrible performance penalties. It essentially allows the

Re: cvs commit: src/sys/dev/bge if_bge.c

2006-12-23 Thread Scott Long
Robert Watson wrote: On Sat, 23 Dec 2006, John Polstra wrote: That said, dropping and regrabbing the driver lock in the rxeof routine of any driver is bad. It may be safe to do, but it incurs horrible performance penalties. It essentially allows the time-critical, high priority RX path to

Re: cvs commit: src/sys/dev/bge if_bge.c

2006-12-23 Thread Bruce Evans
On Sun, 24 Dec 2006, Oleg Bulyzhin wrote: On Fri, Dec 22, 2006 at 01:24:45AM +1100, Bruce Evans wrote: On Wed, 20 Dec 2006, Gleb Smirnoff wrote: I have a suspicion that this may cause a problem under high load. Imagine that thread #1 is spinning in bge_start_locked() getting packets out of in

Re: cvs commit: src/sys/dev/bge if_bge.c

2006-12-23 Thread Bruce Evans
On Sat, 23 Dec 2006, Robert Watson wrote: On Sat, 23 Dec 2006, John Polstra wrote: That said, dropping and regrabbing the driver lock in the rxeof routine of any driver is bad. It may be safe to do, but it incurs horrible performance penalties. It essentially allows the time-critical, high

Re: cvs commit: src/sys/dev/bge if_bge.c

2006-12-23 Thread Robert Watson
On Sun, 24 Dec 2006, Oleg Bulyzhin wrote: We currently make this a lot worse than it needs to be by handing off the received packets one at a time, unlocking and relocking for every packet. It would be better if the driver's receive interrupt handler would harvest all of the incoming packets

Re: cvs commit: src/sys/dev/bge if_bge.c

2006-12-23 Thread Oleg Bulyzhin
On Sat, Dec 23, 2006 at 09:36:33PM +, Robert Watson wrote: > > On Sat, 23 Dec 2006, John Polstra wrote: > > >>That said, dropping and regrabbing the driver lock in the rxeof routine > >>of any driver is bad. It may be safe to do, but it incurs horrible > >>performance penalties. It essent

Re: cvs commit: src/sys/dev/bge if_bge.c

2006-12-23 Thread Oleg Bulyzhin
On Fri, Dec 22, 2006 at 01:24:45AM +1100, Bruce Evans wrote: > On Wed, 20 Dec 2006, Gleb Smirnoff wrote: > > >On Wed, Dec 20, 2006 at 12:03:21PM +, Bruce Evans wrote: > >B> bde 2006-12-20 12:03:21 UTC > >B> > >B> FreeBSD src repository > >B> > >B> Modified files: > >B> sys/dev/

Re: cvs commit: src/sys/dev/bge if_bge.c

2006-12-23 Thread Robert Watson
On Sat, 23 Dec 2006, John Polstra wrote: That said, dropping and regrabbing the driver lock in the rxeof routine of any driver is bad. It may be safe to do, but it incurs horrible performance penalties. It essentially allows the time-critical, high priority RX path to be constantly preempte

Re: cvs commit: src/sys/dev/bge if_bge.c

2006-12-23 Thread John Polstra
On 22-Dec-2006 Scott Long wrote: > In any case, the driver lock must not be held when calling if_input > because there are many ways the codepath can loop from there back into > if_start of the same driver or another driver. There is no way around > this without doing big decoupling steps that wil

Re: cvs commit: src/sys/dev/bge if_bge.c

2006-12-22 Thread Scott Long
Bruce Evans wrote: On Fri, 22 Dec 2006, I wrote: bge_start_locked() starts with the bge (sc) lock held and never releases it as far as I can see. This this problem can't happen (the lock prevents both txeof and the watchdog from being reached before start resets the timeout to 5 seconds). I c

Re: cvs commit: src/sys/dev/bge if_bge.c

2006-12-22 Thread Bruce Evans
On Fri, 22 Dec 2006, I wrote: bge_start_locked() starts with the bge (sc) lock held and never releases it as far as I can see. This this problem can't happen (the lock prevents both txeof and the watchdog from being reached before start resets the timeout to 5 seconds). I could only find the l

Re: cvs commit: src/sys/dev/bge if_bge.c

2006-12-21 Thread Bruce Evans
On Wed, 20 Dec 2006, Gleb Smirnoff wrote: On Wed, Dec 20, 2006 at 12:03:21PM +, Bruce Evans wrote: B> bde 2006-12-20 12:03:21 UTC B> B> FreeBSD src repository B> B> Modified files: B> sys/dev/bge if_bge.c B> Log: B> In bge_txeof(), cancel the watchdog timeout if

Re: cvs commit: src/sys/dev/bge if_bge.c

2006-12-20 Thread Scott Long
Bruce Evans wrote: bde 2006-12-20 12:03:21 UTC FreeBSD src repository Modified files: sys/dev/bge if_bge.c Log: In bge_txeof(), cancel the watchdog timeout if all descriptors have been handled instead of when at least one descriptor was just handled. For bge,

Re: cvs commit: src/sys/dev/bge if_bge.c

2006-12-20 Thread Gleb Smirnoff
On Wed, Dec 20, 2006 at 12:03:21PM +, Bruce Evans wrote: B> bde 2006-12-20 12:03:21 UTC B> B> FreeBSD src repository B> B> Modified files: B> sys/dev/bge if_bge.c B> Log: B> In bge_txeof(), cancel the watchdog timeout if all descriptors have B> been handled ins

Re: cvs commit: src/sys/dev/bge if_bge.c

2006-12-18 Thread Scott Long
Bruce Evans wrote: On Sat, 16 Dec 2006, I wrote: On Thu, 14 Dec 2006, I wrote: On Wed, 13 Dec 2006, Jung-uk Kim wrote: On Wednesday 13 December 2006 03:51 pm, Scott Long wrote: scottl 2006-12-13 20:51:51 UTC FreeBSD src repository Modified files: sys/dev/bge if_bge.

Re: cvs commit: src/sys/dev/bge if_bge.c

2006-12-18 Thread Bruce Evans
On Sat, 16 Dec 2006, I wrote: On Thu, 14 Dec 2006, I wrote: On Wed, 13 Dec 2006, Jung-uk Kim wrote: On Wednesday 13 December 2006 03:51 pm, Scott Long wrote: scottl 2006-12-13 20:51:51 UTC FreeBSD src repository Modified files: sys/dev/bge if_bge.c Log: Remove a

Re: cvs commit: src/sys/dev/bge if_bge.c

2006-12-16 Thread John Baldwin
On Friday 15 December 2006 20:42, John Polstra wrote: > On 15-Dec-2006 David O'Brien wrote: > > On Fri, Dec 15, 2006 at 01:26:55PM -0800, Peter Grehan wrote: > >> >I have a Tyan K8W (s2885) which I experienced this on: > >> > >> That's using the the AMD 8131 right ? > > > > Yep. > > > >> Known

Re: cvs commit: src/sys/dev/bge if_bge.c

2006-12-15 Thread John Polstra
On 15-Dec-2006 David O'Brien wrote: > On Fri, Dec 15, 2006 at 01:26:55PM -0800, Peter Grehan wrote: >> >I have a Tyan K8W (s2885) which I experienced this on: >> >> That's using the the AMD 8131 right ? > > Yep. > >> Known not to support MSI. > > I assumed the code would check and not attempt

Re: cvs commit: src/sys/dev/bge if_bge.c

2006-12-15 Thread John Polstra
> I wonder if enabling MSI is what killed bge(4) for me. The booted kernel > would establish 1000Mbit link, but would see and wouldn't send any > packets. > > I have a Tyan K8W (s2885) which I experienced this on: > bge0: mem 0xfd7e-0xfd7e irq > 24 a > t device 9.0 on pci2 > miibus0: o

Re: cvs commit: src/sys/dev/bge if_bge.c

2006-12-15 Thread David O'Brien
On Fri, Dec 15, 2006 at 01:26:55PM -0800, Peter Grehan wrote: > >I have a Tyan K8W (s2885) which I experienced this on: > > That's using the the AMD 8131 right ? Yep. > Known not to support MSI. I assumed the code would check and not attempt MSI if not supported. -- -- David ([EMAIL PROTEC

Re: cvs commit: src/sys/dev/bge if_bge.c

2006-12-15 Thread Peter Grehan
I have a Tyan K8W (s2885) which I experienced this on: That's using the the AMD 8131 right ? Known not to support MSI. later, Peter. ___ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail

Re: cvs commit: src/sys/dev/bge if_bge.c

2006-12-15 Thread David O'Brien
On Fri, Dec 15, 2006 at 12:27:06AM +, John Polstra wrote: > jdp 2006-12-15 00:27:06 UTC > > FreeBSD src repository > > Modified files: > sys/dev/bge if_bge.c > Log: > Disable bge MSI support for now. A couple of people warned me that there > are problems with

Re: cvs commit: src/sys/dev/bge if_bge.c

2006-12-15 Thread Bruce Evans
On Thu, 14 Dec 2006, I wrote: On Wed, 13 Dec 2006, Jung-uk Kim wrote: On Wednesday 13 December 2006 03:51 pm, Scott Long wrote: scottl 2006-12-13 20:51:51 UTC FreeBSD src repository Modified files: sys/dev/bge if_bge.c Log: Remove a redundant write of the firmware

RE: cvs commit: src/sys/dev/bge if_bge.c if_bgereg.h

2006-12-14 Thread John Polstra
On 15-Dec-2006 David Christensen wrote: > MSI capabilities registers are present on virtually all "bge" > controllers but many of the "older" controllers don't correctly support > MSI due to a chip errata that prevents MSI interrupts from actually > being disabled during an ISR. Check the Linux co

RE: cvs commit: src/sys/dev/bge if_bge.c if_bgereg.h

2006-12-14 Thread David Christensen
John, MSI capabilities registers are present on virtually all "bge" controllers but many of the "older" controllers don't correctly support MSI due to a chip errata that prevents MSI interrupts from actually being disabled during an ISR. Check the Linux code for the test used in tg3_open() which

Re: cvs commit: src/sys/dev/bge if_bge.c

2006-12-13 Thread Bruce Evans
On Wed, 13 Dec 2006, Scott Long wrote: Bruce Evans wrote: I just noticed that the code is much clearer and less surprising in old versions. In rev.1.84, there is only 1 write and it is immediately followed by the handshake loop. Now there is a lot of code in between. ... Just for my referenc

Re: cvs commit: src/sys/dev/bge if_bge.c

2006-12-13 Thread Scott Long
Bruce Evans wrote: On Wed, 13 Dec 2006, Jung-uk Kim wrote: On Wednesday 13 December 2006 03:51 pm, Scott Long wrote: scottl 2006-12-13 20:51:51 UTC FreeBSD src repository Modified files: sys/dev/bge if_bge.c Log: Remove a redundant write of the firmware reset magic

Re: cvs commit: src/sys/dev/bge if_bge.c

2006-12-13 Thread Bruce Evans
On Wed, 13 Dec 2006, Jung-uk Kim wrote: On Wednesday 13 December 2006 03:51 pm, Scott Long wrote: scottl 2006-12-13 20:51:51 UTC FreeBSD src repository Modified files: sys/dev/bge if_bge.c Log: Remove a redundant write of the firmware reset magic number. It ... I a

Re: cvs commit: src/sys/dev/bge if_bge.c

2006-12-13 Thread Jung-uk Kim
On Wednesday 13 December 2006 07:23 pm, Scott Long wrote: > Jung-uk Kim wrote: > > On Wednesday 13 December 2006 03:51 pm, Scott Long wrote: > >> scottl 2006-12-13 20:51:51 UTC > >> > >> FreeBSD src repository > >> > >> Modified files: > >> sys/dev/bge if_bge.c > >> Log: > >

Re: cvs commit: src/sys/dev/bge if_bge.c

2006-12-13 Thread Scott Long
Jung-uk Kim wrote: On Wednesday 13 December 2006 03:51 pm, Scott Long wrote: scottl 2006-12-13 20:51:51 UTC FreeBSD src repository Modified files: sys/dev/bge if_bge.c Log: Remove a redundant write of the firmware reset magic number. It looks to have been added erron

Re: cvs commit: src/sys/dev/bge if_bge.c

2006-12-13 Thread Jung-uk Kim
On Wednesday 13 December 2006 03:51 pm, Scott Long wrote: > scottl 2006-12-13 20:51:51 UTC > > FreeBSD src repository > > Modified files: > sys/dev/bge if_bge.c > Log: > Remove a redundant write of the firmware reset magic number. It > looks to have been added erroneously

Re: cvs commit: src/sys/dev/bge if_bge.c if_bgereg.h

2006-12-13 Thread Scott Long
Scott Long wrote: Bruce Evans wrote: On Wed, 13 Dec 2006, Bjoern A. Zeeb wrote: On Tue, 12 Dec 2006, Scott Long wrote: [..] I'll try to run some tests with the third write disabled, but I don't have much time left to devote to this particular project. If others would be willing to test with

Re: cvs commit: src/sys/dev/bge if_bge.c if_bgereg.h

2006-12-13 Thread Scott Long
Bruce Evans wrote: On Wed, 13 Dec 2006, Bjoern A. Zeeb wrote: On Tue, 12 Dec 2006, Scott Long wrote: [..] I'll try to run some tests with the third write disabled, but I don't have much time left to devote to this particular project. If others would be willing to test with the third write re

Re: cvs commit: src/sys/dev/bge if_bge.c if_bgereg.h

2006-12-13 Thread Bruce Evans
On Wed, 13 Dec 2006, Bjoern A. Zeeb wrote: On Tue, 12 Dec 2006, Scott Long wrote: [..] I'll try to run some tests with the third write disabled, but I don't have much time left to devote to this particular project. If others would be willing to test with the third write removed, I'd appreciat

Re: cvs commit: src/sys/dev/bge if_bge.c if_bgereg.h

2006-12-13 Thread Bjoern A. Zeeb
On Tue, 12 Dec 2006, Scott Long wrote: Modified files: sys/dev/bge if_bge.c if_bgereg.h Log: Fix support for certain 575x/578x chips. This consists of the following: ... this change makes my machine hang completely (even not able to break into kernel debugger) by the time the i

Re: cvs commit: src/sys/dev/bge if_bge.c if_bgereg.h

2006-12-12 Thread Scott Long
Bruce Evans wrote: On Tue, 12 Dec 2006, Bjoern A. Zeeb wrote: On Tue, 12 Dec 2006, Scott Long wrote: scottl 2006-12-12 05:11:12 UTC FreeBSD src repository Modified files: sys/dev/bge if_bge.c if_bgereg.h Log: Fix support for certain 575x/578x chips. This consists of th

Re: cvs commit: src/sys/dev/bge if_bge.c if_bgereg.h

2006-12-12 Thread Bruce Evans
On Wed, 13 Dec 2006, Oleg Bulyzhin wrote: On Tue, Dec 12, 2006 at 06:09:17PM -0500, Jung-uk Kim wrote: On Tuesday 12 December 2006 05:05 pm, Oleg Bulyzhin wrote: I would say you have simplified it too much. With your change you will get wrong numbers after ifconfig down/up (since it implies

Re: cvs commit: src/sys/dev/bge if_bge.c

2006-12-12 Thread Bruce Evans
On Wed, 13 Dec 2006, Oleg Bulyzhin wrote: On Tue, Dec 12, 2006 at 06:24:43PM -0500, Jung-uk Kim wrote: On Tuesday 12 December 2006 05:25 pm, Oleg Bulyzhin wrote: On Mon, Dec 11, 2006 at 06:00:35PM +, Jung-uk Kim wrote: jkim2006-12-11 18:00:35 UTC FreeBSD src repository Modif

Re: cvs commit: src/sys/dev/bge if_bge.c if_bgereg.h

2006-12-12 Thread Oleg Bulyzhin
On Tue, Dec 12, 2006 at 08:07:46PM -0500, Jung-uk Kim wrote: > On Tuesday 12 December 2006 07:44 pm, Oleg Bulyzhin wrote: > > On Tue, Dec 12, 2006 at 07:31:24PM -0500, Jung-uk Kim wrote: > > > On Tuesday 12 December 2006 06:44 pm, Oleg Bulyzhin wrote: > > > > On Tue, Dec 12, 2006 at 06:09:17PM -050

Re: cvs commit: src/sys/dev/bge if_bge.c if_bgereg.h

2006-12-12 Thread Scott Long
On Wed, 13 Dec 2006, Bruce Evans wrote: On Tue, 12 Dec 2006, Bjoern A. Zeeb wrote: On Tue, 12 Dec 2006, Scott Long wrote: scottl 2006-12-12 05:11:12 UTC FreeBSD src repository Modified files: sys/dev/bge if_bge.c if_bgereg.h Log: Fix support for certain 575x/578x chi

Re: cvs commit: src/sys/dev/bge if_bge.c if_bgereg.h

2006-12-12 Thread Jung-uk Kim
On Tuesday 12 December 2006 07:44 pm, Oleg Bulyzhin wrote: > On Tue, Dec 12, 2006 at 07:31:24PM -0500, Jung-uk Kim wrote: > > On Tuesday 12 December 2006 06:44 pm, Oleg Bulyzhin wrote: > > > On Tue, Dec 12, 2006 at 06:09:17PM -0500, Jung-uk Kim wrote: > > > > On Tuesday 12 December 2006 05:05 pm, O

Re: cvs commit: src/sys/dev/bge if_bge.c

2006-12-12 Thread Jung-uk Kim
On Tuesday 12 December 2006 07:03 pm, Oleg Bulyzhin wrote: > On Tue, Dec 12, 2006 at 06:24:43PM -0500, Jung-uk Kim wrote: > > On Tuesday 12 December 2006 05:25 pm, Oleg Bulyzhin wrote: > > > On Mon, Dec 11, 2006 at 06:00:35PM +, Jung-uk Kim wrote: > > > > jkim2006-12-11 18:00:35 UTC > >

Re: cvs commit: src/sys/dev/bge if_bge.c if_bgereg.h

2006-12-12 Thread Oleg Bulyzhin
On Tue, Dec 12, 2006 at 07:31:24PM -0500, Jung-uk Kim wrote: > On Tuesday 12 December 2006 06:44 pm, Oleg Bulyzhin wrote: > > On Tue, Dec 12, 2006 at 06:09:17PM -0500, Jung-uk Kim wrote: > > > On Tuesday 12 December 2006 05:05 pm, Oleg Bulyzhin wrote: > > > > On Fri, Dec 01, 2006 at 01:08:52AM +000

Re: cvs commit: src/sys/dev/bge if_bge.c if_bgereg.h

2006-12-12 Thread Bruce Evans
On Tue, 12 Dec 2006, Bjoern A. Zeeb wrote: On Tue, 12 Dec 2006, Scott Long wrote: scottl 2006-12-12 05:11:12 UTC FreeBSD src repository Modified files: sys/dev/bge if_bge.c if_bgereg.h Log: Fix support for certain 575x/578x chips. This consists of the following: ... th

Re: cvs commit: src/sys/dev/bge if_bge.c if_bgereg.h

2006-12-12 Thread Jung-uk Kim
On Tuesday 12 December 2006 06:44 pm, Oleg Bulyzhin wrote: > On Tue, Dec 12, 2006 at 06:09:17PM -0500, Jung-uk Kim wrote: > > On Tuesday 12 December 2006 05:05 pm, Oleg Bulyzhin wrote: > > > On Fri, Dec 01, 2006 at 01:08:52AM +, Jung-uk Kim wrote: > > > > jkim2006-12-01 01:08:52 UTC > >

Re: cvs commit: src/sys/dev/bge if_bge.c

2006-12-12 Thread Oleg Bulyzhin
On Tue, Dec 12, 2006 at 06:24:43PM -0500, Jung-uk Kim wrote: > On Tuesday 12 December 2006 05:25 pm, Oleg Bulyzhin wrote: > > On Mon, Dec 11, 2006 at 06:00:35PM +, Jung-uk Kim wrote: > > > jkim2006-12-11 18:00:35 UTC > > > > > > FreeBSD src repository > > > > > > Modified files: > >

Re: cvs commit: src/sys/dev/bge if_bge.c if_bgereg.h

2006-12-12 Thread Oleg Bulyzhin
On Tue, Dec 12, 2006 at 06:09:17PM -0500, Jung-uk Kim wrote: > On Tuesday 12 December 2006 05:05 pm, Oleg Bulyzhin wrote: > > On Fri, Dec 01, 2006 at 01:08:52AM +, Jung-uk Kim wrote: > > > jkim2006-12-01 01:08:52 UTC > > > > > > FreeBSD src repository > > > > > > Modified files: > >

Re: cvs commit: src/sys/dev/bge if_bge.c

2006-12-12 Thread Jung-uk Kim
On Tuesday 12 December 2006 05:25 pm, Oleg Bulyzhin wrote: > On Mon, Dec 11, 2006 at 06:00:35PM +, Jung-uk Kim wrote: > > jkim2006-12-11 18:00:35 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/dev/bge if_bge.c > > Log: > > - Correct collision cou

Re: cvs commit: src/sys/dev/bge if_bge.c if_bgereg.h

2006-12-12 Thread Bjoern A. Zeeb
On Tue, 12 Dec 2006, Scott Long wrote: scottl 2006-12-12 05:11:12 UTC FreeBSD src repository Modified files: sys/dev/bge if_bge.c if_bgereg.h Log: Fix support for certain 575x/578x chips. This consists of the following: - Use the appropriate register writing method when

Re: cvs commit: src/sys/dev/bge if_bge.c if_bgereg.h

2006-12-12 Thread Jung-uk Kim
On Tuesday 12 December 2006 05:05 pm, Oleg Bulyzhin wrote: > On Fri, Dec 01, 2006 at 01:08:52AM +, Jung-uk Kim wrote: > > jkim2006-12-01 01:08:52 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/dev/bge if_bge.c if_bgereg.h > > Log: > > Simplify st

Re: cvs commit: src/sys/dev/bge if_bge.c

2006-12-12 Thread Oleg Bulyzhin
On Mon, Dec 11, 2006 at 06:00:35PM +, Jung-uk Kim wrote: > jkim2006-12-11 18:00:35 UTC > > FreeBSD src repository > > Modified files: > sys/dev/bge if_bge.c > Log: > - Correct collision counter for BCM5705+. This register is read/clear. > - Correct RX packet d

Re: cvs commit: src/sys/dev/bge if_bge.c if_bgereg.h

2006-12-12 Thread Oleg Bulyzhin
On Fri, Dec 01, 2006 at 01:08:52AM +, Jung-uk Kim wrote: > jkim2006-12-01 01:08:52 UTC > > FreeBSD src repository > > Modified files: > sys/dev/bge if_bge.c if_bgereg.h > Log: > Simplify statistics updates, remove redundant register reads, and add > discarded R

Re: cvs commit: src/sys/dev/bge if_bge.c if_bgereg.h

2006-12-11 Thread Scott Long
For those watching from the sidelines, this work was targeted specifically at the 5754/5787 chip that is found in some newer Dell machines. Prior to this change, merely having the bge driver in the kernel would cause an NMI panic on boot. FreeBSD 6.1 does not suffer from this because these chip

Re: cvs commit: src/sys/dev/bge if_bge.c if_bgereg.h

2006-10-13 Thread Erwin Lansing
On Fri, Oct 13, 2006 at 08:05:56AM +, Gleb Smirnoff wrote: > glebius 2006-10-13 08:05:56 UTC > > FreeBSD src repository > > Modified files:(Branch: RELENG_6) > sys/dev/bge if_bge.c if_bgereg.h > Log: > MFC: > Remove 3Com 985 deviceid that is really ti(4).

Re: cvs commit: src/sys/dev/bge if_bge.c

2006-09-20 Thread John-Mark Gurney
David Malone wrote this message on Wed, Sep 20, 2006 at 09:52 +0100: > (It's interesting to note that as ethernet cards introduce more > features it is getting harder for us to tell what we put on the > wire. With checksum offloading we can no longer trust the checksum. > With VLAN tagging we can't

Re: cvs commit: src/sys/dev/bge if_bge.c

2006-09-20 Thread Robert Watson
On Wed, 20 Sep 2006, David Malone wrote: With VLAN tagging we can't trust the VLAN tag. Unlike checksums etc, the kernel must be able to determine the VLAN tag to be able to process the packet. The problem is that it isn't where bpf expects. True, though BPF just expects to find the data

Re: cvs commit: src/sys/dev/bge if_bge.c

2006-09-20 Thread David Malone
> >Putting ethernet specific code in bpf_* feels like a bad idea. > Is this any worse than having ethernet specific code in the mbuf header? Well, I didn't really like the sound of that either, but I was too polite to mention it ;-) > >(It's interesting to note that as ethernet cards introduce m

Re: cvs commit: src/sys/dev/bge if_bge.c

2006-09-20 Thread Peter Jeremy
On Wed, 2006-Sep-20 09:52:36 +0100, David Malone wrote: >Putting ethernet specific code in bpf_* feels like a bad idea. Is this any worse than having ethernet specific code in the mbuf header? > It >should be possible to leave hardware assisted VLAN tagging on and >get ether input to reinsert the

Re: cvs commit: src/sys/dev/bge if_bge.c

2006-09-20 Thread David Malone
On Wed, Sep 20, 2006 at 05:26:26PM +1000, Peter Jeremy wrote: > In addition, the code necessary to correctly re-insert the VLAN tag > (to provide a fully valid mbuf chain for further processing) will be > larger and slower than the code necessary to kludge a mbuf that is > adequate for bpf_filter()

Re: cvs commit: src/sys/dev/bge if_bge.c

2006-09-20 Thread Peter Jeremy
On Tue, 2006-Sep-19 15:35:06 -0400, Jung-uk Kim wrote: [VLAN tagging] >Why don't we just fake it up from ether_input() and pass it to >BPF_MTAP() instead of 'teaching' bpf? I think it is more logical >thing to do. As Andre points out, this negates the benefit of IFCAP_VLAN_HWTAGGING. In additi

Re: cvs commit: src/sys/dev/bge if_bge.c

2006-09-19 Thread Jung-uk Kim
On Tuesday 19 September 2006 03:54 pm, Andre Oppermann wrote: > Jung-uk Kim wrote: > > On Tuesday 19 September 2006 03:04 pm, Peter Jeremy wrote: > >> On Tue, 2006-Sep-19 14:30:59 -0400, Jung-uk Kim wrote: > >>> On Tuesday 19 September 2006 01:52 pm, John Baldwin wrote: > Which I'm about to ki

Re: cvs commit: src/sys/dev/bge if_bge.c

2006-09-19 Thread Andre Oppermann
Jung-uk Kim wrote: On Tuesday 19 September 2006 03:04 pm, Peter Jeremy wrote: On Tue, 2006-Sep-19 14:30:59 -0400, Jung-uk Kim wrote: On Tuesday 19 September 2006 01:52 pm, John Baldwin wrote: Which I'm about to kill hopefully. Please let's fix this the right way and not hack it any further.

Re: cvs commit: src/sys/dev/bge if_bge.c

2006-09-19 Thread Jung-uk Kim
On Tuesday 19 September 2006 03:04 pm, Peter Jeremy wrote: > On Tue, 2006-Sep-19 14:30:59 -0400, Jung-uk Kim wrote: > >On Tuesday 19 September 2006 01:52 pm, John Baldwin wrote: > >> Which I'm about to kill hopefully. Please let's fix this the > >> right way and not hack it any further. > > > >Sur

Re: cvs commit: src/sys/dev/bge if_bge.c

2006-09-19 Thread Peter Jeremy
On Tue, 2006-Sep-19 14:30:59 -0400, Jung-uk Kim wrote: >On Tuesday 19 September 2006 01:52 pm, John Baldwin wrote: >> Which I'm about to kill hopefully. Please let's fix this the right >> way and not hack it any further. > >Sure, no problem. But I don't think we can DTRT on -STABLE without >brea

Re: cvs commit: src/sys/dev/bge if_bge.c

2006-09-19 Thread Jung-uk Kim
On Tuesday 19 September 2006 01:52 pm, John Baldwin wrote: > On Monday 18 September 2006 19:01, Jung-uk Kim wrote: > > On Monday 18 September 2006 06:33 pm, Christian S.J. Peron wrote: > > > Jung-uk Kim wrote: > > > > jkim2006-09-18 22:18:22 UTC > > > > > > > > FreeBSD src repository > >

Re: cvs commit: src/sys/dev/bge if_bge.c

2006-09-19 Thread Jung-uk Kim
On Tuesday 19 September 2006 12:32 pm, John Baldwin wrote: > On Monday 18 September 2006 18:18, Jung-uk Kim wrote: > > jkim2006-09-18 22:18:22 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/dev/bge if_bge.c > > Log: > > Do not strip VLAN tag in promi

Re: cvs commit: src/sys/dev/bge if_bge.c

2006-09-19 Thread John Baldwin
On Monday 18 September 2006 19:01, Jung-uk Kim wrote: > On Monday 18 September 2006 06:33 pm, Christian S.J. Peron wrote: > > Jung-uk Kim wrote: > > > jkim2006-09-18 22:18:22 UTC > > > > > > FreeBSD src repository > > > > > > Modified files: > > > sys/dev/bge if_bge.c > > >

Re: cvs commit: src/sys/dev/bge if_bge.c

2006-09-19 Thread John Baldwin
On Monday 18 September 2006 18:18, Jung-uk Kim wrote: > jkim2006-09-18 22:18:22 UTC > > FreeBSD src repository > > Modified files: > sys/dev/bge if_bge.c > Log: > Do not strip VLAN tag in promiscuous mode. Why did you change this? Does bge not work correctly with b

Re: cvs commit: src/sys/dev/bge if_bge.c

2006-09-18 Thread Jung-uk Kim
On Monday 18 September 2006 06:33 pm, Christian S.J. Peron wrote: > Jung-uk Kim wrote: > > jkim2006-09-18 22:18:22 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/dev/bge if_bge.c > > Log: > > Do not strip VLAN tag in promiscuous mode. > > > > Revis

Re: cvs commit: src/sys/dev/bge if_bge.c

2006-09-18 Thread Ruslan Ermilov
On Mon, Sep 18, 2006 at 05:33:37PM -0500, Christian S.J. Peron wrote: > Jung-uk Kim wrote: > >jkim2006-09-18 22:18:22 UTC > > > > FreeBSD src repository > > > > Modified files: > >sys/dev/bge if_bge.c > > Log: > > Do not strip VLAN tag in promiscuous mode. > > > > Revis

Re: cvs commit: src/sys/dev/bge if_bge.c

2006-09-18 Thread Jung-uk Kim
On Monday 18 September 2006 06:18 pm, Jung-uk Kim wrote: > jkim2006-09-18 22:18:22 UTC > > FreeBSD src repository > > Modified files: > sys/dev/bge if_bge.c > Log: > Do not strip VLAN tag in promiscuous mode. > > Revision ChangesPath > 1.148 +28 -15src/

Re: cvs commit: src/sys/dev/bge if_bge.c

2006-09-18 Thread Christian S.J. Peron
Jung-uk Kim wrote: jkim2006-09-18 22:18:22 UTC FreeBSD src repository Modified files: sys/dev/bge if_bge.c Log: Do not strip VLAN tag in promiscuous mode. Revision ChangesPath 1.148 +28 -15src/sys/dev/bge/if_bge.c I don't think this is ri

Re: cvs commit: src/sys/dev/bge if_bge.c if_bgereg.h

2006-09-11 Thread Gleb Smirnoff
On Sat, Sep 09, 2006 at 03:36:57AM +, Doug Ambrisko wrote: D> ambrisko2006-09-09 03:36:57 UTC D> D> FreeBSD src repository D> D> Modified files: D> sys/dev/bge if_bge.c if_bgereg.h D> Log: D> Add support to bge(4) to not break IPMI support when the driver attaches D>

Re: cvs commit: src/sys/dev/bge if_bge.c if_bgereg.h

2006-09-02 Thread Maxim Konovalov
On Sat, 2 Sep 2006, 00:42-0700, John-Mark Gurney wrote: > David Christensen wrote this message on Fri, Sep 01, 2006 at 22:30 +: > > davidch 2006-09-01 22:30:56 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/dev/bge if_bge.c if_bgereg.h > > Log: > >

Re: cvs commit: src/sys/dev/bge if_bge.c if_bgereg.h

2006-09-02 Thread John-Mark Gurney
David Christensen wrote this message on Fri, Sep 01, 2006 at 22:30 +: > davidch 2006-09-01 22:30:56 UTC > > FreeBSD src repository > > Modified files: > sys/dev/bge if_bge.c if_bgereg.h > Log: > /tmp/cvsleYf6y are you going to do a force commit w/ the real message?

Re: cvs commit: src/sys/dev/bge if_bge.c if_bgereg.h

2006-09-01 Thread LI Xin
David Christensen wrote: > davidch 2006-09-01 22:45:12 UTC > > FreeBSD src repository > > Modified files: > sys/dev/bge if_bge.c if_bgereg.h > Log: > Resolve "firmware handshake" error on 5752. Thanks! Cheers, -- Xin LI <[EMAIL PROTECTED]> http://www.delphij.net/

Re: cvs commit: src/sys/dev/bge if_bge.c

2006-04-15 Thread Scott Long
Oleg Bulyzhin wrote: On Sat, Apr 15, 2006 at 08:13:07AM +, Scott Long wrote: scottl 2006-04-15 08:13:07 UTC FreeBSD src repository Modified files: sys/dev/bge if_bge.c Log: Fix the interrupt handler to do the mandatory PCI flush before looking at DMA memory. The c

Re: cvs commit: src/sys/dev/bge if_bge.c

2006-04-15 Thread Oleg Bulyzhin
On Sat, Apr 15, 2006 at 08:13:07AM +, Scott Long wrote: > scottl 2006-04-15 08:13:07 UTC > > FreeBSD src repository > > Modified files: > sys/dev/bge if_bge.c > Log: > Fix the interrupt handler to do the mandatory PCI flush before looking at > DMA memory. The cou

Re: cvs commit: src/sys/dev/bge if_bge.c

2006-02-07 Thread Oleg Bulyzhin
On Tue, Feb 07, 2006 at 08:44:42PM +1100, Bruce Evans wrote: > On Mon, 6 Feb 2006, Nate Lawson wrote: > > >Nate Lawson wrote: > >>Oleg Bulyzhin wrote: > >> > >>>On Mon, Feb 06, 2006 at 02:21:09PM -0800, Nate Lawson wrote: > >>> > Oleg Bulyzhin wrote: > > >nq = q->m_nextpkt; >

Re: cvs commit: src/sys/dev/bge if_bge.c

2006-02-07 Thread Bruce Evans
On Mon, 6 Feb 2006, Nate Lawson wrote: Nate Lawson wrote: Oleg Bulyzhin wrote: On Mon, Feb 06, 2006 at 02:21:09PM -0800, Nate Lawson wrote: Oleg Bulyzhin wrote: nq = q->m_nextpkt; q->m_nextpkt = NULL; m->m_pkthdr.csum_flags &= q->m_pkthdr.csum_flags; -m->m_

IP checksum code (was: Re: cvs commit: src/sys/dev/bge if_bge.c)

2006-02-07 Thread Alexander Leidinger
Bruce Evans <[EMAIL PROTECTED]> wrote: in_pseudo() handles both carry steps, but is fairly bogus. Here is the i386 version: % static __inline u_short % in_pseudo(u_int sum, u_int b, u_int c) % { % /* __volatile is necessary because the condition codes are used. */ % __asm __volatil

Re: cvs commit: src/sys/dev/bge if_bge.c

2006-02-06 Thread Bruce Evans
On Mon, 6 Feb 2006, Nate Lawson wrote: Oleg Bulyzhin wrote: On Mon, Feb 06, 2006 at 02:21:09PM -0800, Nate Lawson wrote: Oleg Bulyzhin wrote: Other style bugs in the (not quoted) declaration of `sum' are the missing blank line after the declarations and the type of the variable. I think the

Re: cvs commit: src/sys/dev/bge if_bge.c

2006-02-06 Thread Pyun YongHyeon
On Mon, Feb 06, 2006 at 03:24:50PM -0800, Nate Lawson wrote: > Nate Lawson wrote: > >Oleg Bulyzhin wrote: > > > >>On Mon, Feb 06, 2006 at 02:21:09PM -0800, Nate Lawson wrote: > >> > >>>Oleg Bulyzhin wrote: > >>> > nq = q->m_nextpkt; > q->m_nextpkt = NULL; >

Re: cvs commit: src/sys/dev/bge if_bge.c

2006-02-06 Thread Nate Lawson
Nate Lawson wrote: Oleg Bulyzhin wrote: On Mon, Feb 06, 2006 at 02:21:09PM -0800, Nate Lawson wrote: Oleg Bulyzhin wrote: nq = q->m_nextpkt; q->m_nextpkt = NULL; m->m_pkthdr.csum_flags &= q->m_pkthdr.csum_flags; -m->m_pkthdr.csum_data += q->m_pkthdr.csum_data

Re: cvs commit: src/sys/dev/bge if_bge.c

2006-02-06 Thread Nate Lawson
Oleg Bulyzhin wrote: On Mon, Feb 06, 2006 at 02:21:09PM -0800, Nate Lawson wrote: Oleg Bulyzhin wrote: nq = q->m_nextpkt; q->m_nextpkt = NULL; m->m_pkthdr.csum_flags &= q->m_pkthdr.csum_flags; - m->m_pkthdr.csum_data += q->m_pkthdr.c

Re: cvs commit: src/sys/dev/bge if_bge.c

2006-02-06 Thread Oleg Bulyzhin
On Mon, Feb 06, 2006 at 02:21:09PM -0800, Nate Lawson wrote: > Oleg Bulyzhin wrote: > >On Sun, Feb 05, 2006 at 05:58:17PM -0600, Alan Cox wrote: > >>Unfortunately, it also breaks NFS over UDP. Let me know if you need > >>details. > >> > >>Alan > > > > > >Fix attached. It's not bge problem it's fiv

  1   2   >