Re: cvs commit: src/sys/dev/bge if_bge.c

[Ruslan Ermilov]

Hi Scott,

On Mon, Mar 12, 2007 at 09:25:57AM +0000, Scott Long wrote:
> scottl      2007-03-12 09:25:57 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     sys/dev/bge          if_bge.c 
>   Log:
>   Add MAC, RX, and TX stats reporting via sysctl.
>   
>   Revision  Changes    Path
>   1.185     +147 -10   src/sys/dev/bge/if_bge.c
> 
The following patch eliminates collisions in sysctl
names that kernel reports on boot:

%%%
Index: if_bge.c
===================================================================
RCS file: /home/ncvs/src/sys/dev/bge/if_bge.c,v
retrieving revision 1.185
diff -u -p -r1.185 if_bge.c
--- if_bge.c    12 Mar 2007 09:25:57 -0000      1.185
+++ if_bge.c    12 Mar 2007 16:14:05 -0000
@@ -4275,9 +4275,9 @@ bge_add_sysctls(struct bge_softc *sc)
        BGE_SYSCTL_STAT(sc, ctx, "Undersized Packets",
            children, rxstats.etherStatsUndersizePkts, "UndersizePkts");
        BGE_SYSCTL_STAT(sc, ctx, "Inbound Range Length Errors",
-           children, rxstats.inRangeLengthError, "RangeLengthError");
+           children, rxstats.inRangeLengthError, "inRangeLengthError");
        BGE_SYSCTL_STAT(sc, ctx, "Outbound Range Length Errors",
-           children, rxstats.outRangeLengthError, "RangeLengthError");
+           children, rxstats.outRangeLengthError, "outRangeLengthError");
 
        tree = SYSCTL_ADD_NODE(ctx, schildren, OID_AUTO, "tx", CTLFLAG_RD,
            NULL, "BGE TX Statistics");
@@ -4308,8 +4308,8 @@ bge_add_sysctls(struct bge_softc *sc)
            children, txstats.dot3StatsExcessiveCollisions,
            "ExcessiveCollisions");
        BGE_SYSCTL_STAT(sc, ctx, "Late Collisions",
-           children, txstats.dot3StatsExcessiveCollisions,
-           "ExcessiveCollisions");
+           children, txstats.dot3StatsLateCollisions,
+           "LateCollisions");
        BGE_SYSCTL_STAT(sc, ctx, "Outbound Unicast Packets", 
            children, txstats.ifHCOutUcastPkts, "UcastPkts");
        BGE_SYSCTL_STAT(sc, ctx, "Outbound Multicast Packets",
%%%


Cheers,
-- 
Ruslan Ermilov
[EMAIL PROTECTED]
FreeBSD committer

pgpvYvHq8wh9T.pgp
Description: PGP signature