On Fri, Dec 01, 2006 at 01:08:52AM +0000, Jung-uk Kim wrote: > jkim 2006-12-01 01:08:52 UTC > > FreeBSD src repository > > Modified files: > sys/dev/bge if_bge.c if_bgereg.h > Log: > Simplify statistics updates, remove redundant register reads, and add > discarded RX packets to input error for BCM5705 or newer chipset as the > others. > Unfortunately we cannot do the same for output errors because ifOutDiscards > equivalent register does not exist. While I am here, replace misleading and > wrong BGE_RX_STATS/BGE_TX_STATS with BGE_MAC_STATS. They were reversed but > worked accidently. > > Revision Changes Path > 1.153 +15 -23 src/sys/dev/bge/if_bge.c > 1.58 +4 -5 src/sys/dev/bge/if_bgereg.h
I would say you have simplified it too much. With your change you will get wrong numbers after ifconfig down/up (since it implies hardware counters reset while sc->bge_* counters are not cleared). -- Oleg. ================================================================ === Oleg Bulyzhin -- OBUL-RIPN -- OBUL-RIPE -- [EMAIL PROTECTED] === ================================================================ _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "[EMAIL PROTECTED]"
