All out PR merge commit messages have is the URL. Nothing as informative
as what Andreas submits. :(
Judd Maltin
1-917-882-1270
I have suffering to learn compassion once and once again.
On Nov 16, 2013 1:27 PM, "Andreas Jaeger" wrote:
On 11/16/2013 09:36 AM, Judd Maltin wrote:
> When I see a "m
Well, to a very large extent the information in the non-merge commit
logs should be sufficient to understand what happened to the code.
That said, there is sometimes useful additional information provided
in the body of the pull request, typically providing an overview of
why/how all the commits i
On 11/16/2013 09:36 AM, Judd Maltin wrote:
> When I see a "merge commit" there is no way for me to see the PR title
> without going to github. I am not always online when I'm reading code.
> 'git log' is supposed to tell me what changes happened to my code that I
> can reason about all in the sam
When I see a "merge commit" there is no way for me to see the PR title
without going to github. I am not always online when I'm reading code.
'git log' is supposed to tell me what changes happened to my code that I
can reason about all in the same context. Putting a nearly meaningless URL
in an e
Judd Maltin (j...@newgoliath.com) wrote:
> When looking at 'git log' commit messages should have more than a PR #.
I don't quite follow this. Certainly non-merge commits should have
useful commit messages, and following OpenStack's lead in this regard
would be best practice:
https://wiki.open
When looking at 'git log' commit messages should have more than a PR #.
-judd
commit efa2e4df265fd1f3f5ce8e17219e3f23669b6c33
Merge: 246aa80 4d6d7e7
Author: Rob Hirschfeld
Date: Wed Nov 13 13:57:32 2013 -0800
Merge pull request #1935 from dirkmueller/master
+1
commit 246aa80583be36
