All out PR merge commit messages have is the URL. Nothing as informative
as what Andreas submits. :(
Judd Maltin
1-917-882-1270
I have suffering to learn compassion once and once again.
On Nov 16, 2013 1:27 PM, "Andreas Jaeger" <a...@suse.com> wrote:
On 11/16/2013 09:36 AM, Judd Maltin wrote:
> When I see a "merge commit" there is no way for me to see the PR title
> without going to github. I am not always online when I'm reading code.
> 'git log' is supposed to tell me what changes happened to my code that I
> can reason about all in the same context. Putting a nearly meaningless
> URL in an explanatory commit message context is a wasteful context shift
> and skips important data. That, and they're not that way in OpenStack
> projects.
There should be two log messages for this kind of change - the merge
commit and the original commit message. Just looking at
openstack-manuals, I see:
commit 652e763c3c18bec8044d25a9e43cab22f766bfbe
Merge: d45147e d9417b2
Author: Jenkins <jenk...@review.openstack.org>
Date: Sat Nov 16 05:42:12 2013 +0000
Merge "Make the RabbitMQ settings more consistent"
And then further down:
commit d9417b25d97b5acf943575ac74487205ab2f08c1
Author: Gauvain Pocentek <gauvain.pocen...@objectif-libre.com>
Date: Fri Nov 8 15:58:40 2013 +0800
Make the RabbitMQ settings more consistent
Modify the RabbitMQ password for all distributions using it, and provide
configuration informations for all the OpenStack services connected to
the message bus.
Change-Id: I6309c9080ab34885c68c11b5d37783e07bdd98bd
backport: havana
Closes-Bug: #1249230
So, the information is really there - just not where you expected it,
Andreas
--
Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126
_______________________________________________
Crowbar mailing list
Crowbar@dell.com
https://lists.us.dell.com/mailman/listinfo/crowbar
For more information: http://crowbar.github.com/
