Re: [Crowbar] barclamp-network unit test failures

2013-03-04 Thread Adam Spiers
christopher_dearb...@dell.com (christopher_dearb...@dell.com) wrote: > Hey Adam, > > FYI: I just took an update and diffed the two network_test_helpers: > > crowbar/barclamps/network/crowbar_engine/barclamp_network/test/network_test_helper.rb > > and > > crowbar/barclamps/crowbar/crowbar_framew

Re: [Crowbar] barclamp-network unit test failures

2013-03-04 Thread Adam Spiers
christopher_dearb...@dell.com (christopher_dearb...@dell.com) wrote: > Hey Adam, > > Just ran the unit tests via "bundle exec rake test:units" and "dev > run-unit-tests", and all the unit tests passed in both cases. Spoke with > Andi, and he ran into the same problem over the weekend. He belie

Re: [Crowbar] barclamp-network unit test failures

2013-03-04 Thread Rob_Hirschfeld
I've updated the Marshall to use Json. Should fix that issue. - Original Message - From: Dearborn, Chris Sent: Monday, March 04, 2013 01:58 PM To: aspi...@suse.com ; crowbar Subject: Re: [Crowbar] barclamp-network unit test failures Hey Adam, Just ran the unit tests via "b

Re: [Crowbar] barclamp-network unit test failures

2013-03-04 Thread Christopher_Dearborn
;Adam Spiers'; crowbar Subject: RE: [Crowbar] barclamp-network unit test failures Hey Adam, FYI: I just took an update and diffed the two network_test_helpers: crowbar/barclamps/network/crowbar_engine/barclamp_network/test/network_test_helper.rb and crowbar/barclamps/crowbar/crowbar_framewo

Re: [Crowbar] barclamp-network unit test failures

2013-03-04 Thread Christopher_Dearborn
failure, though I am running Ruby 1.8, and the tests ran fine with sqlite3 as the DB before I generated the pull request. Chris -Original Message- From: crowbar-bounces On Behalf Of Adam Spiers Sent: Monday, March 04, 2013 12:32 PM To: crowbar Subject: Re: [Crowbar] barclamp-network unit test

Re: [Crowbar] barclamp-network unit test failures

2013-03-04 Thread Adam Spiers
Adam Spiers (aspi...@suse.com) wrote: > Regardless, it seems rather odd to be attempting to serialise nested > data structures in database fields, and I don't see any > deserialization code, so I'm guessing this was unintentional? Ah no, I see now it was intentional. But I still don't understand

[Crowbar] barclamp-network unit test failures

2013-03-04 Thread Adam Spiers
I'm getting test failures due to what looks like a bug in network_test_helper.rb: 1) Error: test_ConduitRule.build_if_remap:_Remap_with_known_product_name(ConduitRuleTest): ActiveRecord::StatementInvalid: SQLite3::SQLException: unrecognized token: "{I" eth0:EF{I" path;": UP