Hey Adam, Just ran the unit tests via "bundle exec rake test:units" and "dev run-unit-tests", and all the unit tests passed in both cases. Spoke with Andi, and he ran into the same problem over the weekend. He believes the issue is a difference between the behavior of Marshal in Ruby 1.8 and 1.9, and the solution is not to use it.
I believe that Rob's recent pull request will fix the issue: https://github.com/crowbar/barclamp-crowbar/pull/432 Thanks, Chris -----Original Message----- From: Dearborn, Chris Sent: Monday, March 04, 2013 1:33 PM To: 'Adam Spiers'; crowbar Subject: RE: [Crowbar] barclamp-network unit test failures Hey Adam, FYI: I just took an update and diffed the two network_test_helpers: crowbar/barclamps/network/crowbar_engine/barclamp_network/test/network_test_helper.rb and crowbar/barclamps/crowbar/crowbar_framework/test/network_test_helper.rb and they are identical. Will look at the test failure, though I am running Ruby 1.8, and the tests ran fine with sqlite3 as the DB before I generated the pull request. Chris -----Original Message----- From: crowbar-bounces On Behalf Of Adam Spiers Sent: Monday, March 04, 2013 12:32 PM To: crowbar Subject: Re: [Crowbar] barclamp-network unit test failures Adam Spiers (aspi...@suse.com) wrote: > Regardless, it seems rather odd to be attempting to serialise nested > data structures in database fields, and I don't see any > deserialization code, so I'm guessing this was unintentional? Ah no, I see now it was intentional. But I still don't understand why noone else sees this. By the way, within 48 hours or less of network_test_helper.rb being copied to crowbar_framework to hack around the tests, it already seems to have diverged. We should eliminate this hack ASAP. Presumably it's just a question of teaching ./dev where to find helpers from engines? _______________________________________________ Crowbar mailing list Crowbar@dell.com https://lists.us.dell.com/mailman/listinfo/crowbar For more information: http://crowbar.github.com/ _______________________________________________ Crowbar mailing list Crowbar@dell.com https://lists.us.dell.com/mailman/listinfo/crowbar For more information: http://crowbar.github.com/
