bility
> guarantees made for finalizers in [JLS
> 17.4.5](https://docs.oracle.com/javase/specs/jls/se18/html/jls-17.html#jls-17.4.5):
> _"There is a happens-before edge from the end of a constructor of an object
> to the start of a finalizer (§12.6) for that object."_
Brent
bility
> guarantees made for finalizers in [JLS
> 17.4.5](https://docs.oracle.com/javase/specs/jls/se18/html/jls-17.html#jls-17.4.5):
> _"There is a happens-before edge from the end of a constructor of an object
> to the start of a finalizer (§12.6) for that object."_
Br
On Thu, 30 May 2024 05:14:30 GMT, Joe Darcy wrote:
>> Brent Christian has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 69 commits:
>>
>> - Merge branch 'master' into refDocs2
>> - add lin
bility
> guarantees made for finalizers in [JLS
> 17.4.5](https://docs.oracle.com/javase/specs/jls/se18/html/jls-17.html#jls-17.4.5):
> _"There is a happens-before edge from the end of a constructor of an object
> to the start of a finalizer (§12.6) for that object."_
Br
bility
> guarantees made for finalizers in [JLS
> 17.4.5](https://docs.oracle.com/javase/specs/jls/se18/html/jls-17.html#jls-17.4.5):
> _"There is a happens-before edge from the end of a constructor of an object
> to the start of a finalizer (§12.6) for that object."_
Br
On Mon, 13 Nov 2023 22:31:16 GMT, Brent Christian wrote:
> Classes in the `java.lang.ref` package would benefit from an update to bring
> the spec in line with how the VM already behaves. The changes would focus on
> _happens-before_ edges at some key points during reference processin
On Tue, 4 Jun 2024 02:32:28 GMT, lingjun-cg wrote:
> Run the below benchmark test ,it show the average time of new
> DecimalFormat() increase 18% when compare to jdk 11.
>
> the result with jdk 11:
>
> Benchmark Mode CntScore Error Units
> JmhDecimalFormat.te
On Tue, 4 Jun 2024 09:07:44 GMT, lingjun-cg wrote:
>> ### Performance regression of DecimalFormat.format
>> From the output of perf, we can see the hottest regions contain atomic
>> instructions. But when run with JDK 11, there is no such problem. The
>> reason is the removed biased locking.
On Tue, 27 Aug 2024 21:57:16 GMT, Brent Christian wrote:
> The InterruptibleIO feature (which was only on Solaris) was removed some time
> ago. See [JDK-4385444](https://bugs.openjdk.org/browse/JDK-4385444).
>
> Vestiges of it remain in jdk.internal.loader.Resource.getBytes(), and
The InterruptibleIO feature (which was only on Solaris) was removed some time
ago. See [JDK-4385444](https://bugs.openjdk.org/browse/JDK-4385444).
Vestiges of it remain in jdk.internal.loader.Resource.getBytes(), and should be
removed.
-
Commit messages:
- remove handling for defu
> The InterruptibleIO feature (which was only on Solaris) was removed some time
> ago. See [JDK-4385444](https://bugs.openjdk.org/browse/JDK-4385444).
>
> Vestiges of it remain in jdk.internal.loader.Resource.getBytes(), and should
> be removed.
Brent Christian has updated t
On Wed, 28 Aug 2024 06:32:44 GMT, Alan Bateman wrote:
>> Brent Christian has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> move getContentLength() inside try block
>
> src/java.base/share/classes/jdk/interna
On Tue, 27 Aug 2024 21:57:16 GMT, Brent Christian wrote:
> The InterruptibleIO feature (which was only on Solaris) was removed some time
> ago. See [JDK-4385444](https://bugs.openjdk.org/browse/JDK-4385444).
>
> Vestiges of it remain in jdk.internal.loader.Resource.getBytes(), and
On Thu, 29 Sep 2022 21:48:52 GMT, Justin Lu wrote:
> should we update
> test/jdk/sun/text/IntHashtable/patch-src/java.base/java/text/Bug4170614Test.java
> to include `@test, @bug, @run, @summary`?
/*
(this test doesn't have an at-test tag because it's run by
Bug4170614TestRun.java
i
On Thu, 29 Sep 2022 22:15:00 GMT, Justin Lu wrote:
>> Problem: Unnecessary instances of StringBuffer within java.text (internal
>> only)
>>
>> Fix: StringBuffer Replaced with StringBuilder, and adjusted variable/method
>> names
>
> Justin Lu has updated the pull request incrementally with one
On Fri, 30 Sep 2022 16:14:38 GMT, Сергей Цыпанов wrote:
>> src/java.base/share/classes/java/text/PatternEntry.java line 291:
>>
>>> 289: // We re-use these objects in order to improve performance
>>> 290: private StringBuilder newChars = new StringBuilder();
>>> 291: priv
On Fri, 30 Sep 2022 20:08:10 GMT, Justin Lu wrote:
>> Problem: Unnecessary instances of StringBuffer within java.text (internal
>> only)
>>
>> Fix: StringBuffer Replaced with StringBuilder, and adjusted variable/method
>> names
>
> Justin Lu has updated the pull request incrementally with two
On Mon, 3 Oct 2022 21:22:03 GMT, Justin Lu wrote:
>> Problem: Unnecessary instances of StringBuffer within java.text (internal
>> only)
>>
>> Fix: StringBuffer Replaced with StringBuilder, and adjusted variable/method
>> names
>
> Justin Lu has updated the pull request incrementally with one a
On Mon, 3 Oct 2022 21:22:03 GMT, Justin Lu wrote:
>> Problem: Unnecessary instances of StringBuffer within java.text (internal
>> only)
>>
>> Fix: StringBuffer Replaced with StringBuilder, and adjusted variable/method
>> names
>
> Justin Lu has updated the pull request incrementally with one a
On Wed, 5 Oct 2022 22:17:26 GMT, Justin Lu wrote:
> Problem: Unused variables in GregorianCalendar, JapaneseImperialCalendar, and
> Base Calendar.
>
> Fix: Removed all unused variables in bug description except normalizedYear in
> JapaneseImpericalCalendar.getActualMaximum.() as there was no m
On Thu, 13 Oct 2022 01:02:43 GMT, Justin Lu wrote:
> Issue: java/util/Formatter/Basic regression test emits lots of warning
> messages (~60).
>
> Fix: Made adjustments to Basic-X.java.template as the BasicXXX.java files
> where the errors originate from are generated from the template.
>
>
On Mon, 17 Oct 2022 22:20:11 GMT, Lance Andersen wrote:
>> Issue: Formatter unit tests are launched via basic.sh
>>
>> Fix: Replace basic.sh with a Java test launcher
>>
>> Note: Java.internal.math was included in the original configuration of
>> Basic, but I removed it as it was not used with
On Tue, 18 Oct 2022 17:05:08 GMT, Justin Lu wrote:
>> Issue: Formatter unit tests are launched via basic.sh
>>
>> Fix: Replace basic.sh with a Java test launcher
>>
>> Note: Java.internal.math was included in the original configuration of
>> Basic, but I removed it as it was not used within th
On Tue, 18 Oct 2022 18:03:57 GMT, Lance Andersen wrote:
>> test/jdk/java/util/Formatter/BasicTestLauncher.java line 47:
>>
>>> 45: private static final String TZ_UP = "US/Pacific";
>>> 46: // Asia/Novosibirsk time zone
>>> 47: private static final String TZ_AN = "Asia/Novosibirsk";
>
On Tue, 18 Oct 2022 18:24:56 GMT, Justin Lu wrote:
>> Issue: Formatter unit tests are launched via basic.sh
>>
>> Fix: Replace basic.sh with a Java test launcher
>>
>> Note: Java.internal.math was included in the original configuration of
>> Basic, but I removed it as it was not used within th
On Tue, 18 Oct 2022 18:54:03 GMT, Justin Lu wrote:
>> test/jdk/java/util/Formatter/Basic.java line 93:
>>
>>> 91: ", first" , fail+pass, fail), first);
>>> 92: else
>>> 93: System.out.printf("All %s tests passed", pass);
>>
>> %d, yes?
>
> Right, will cha
On Tue, 18 Oct 2022 18:54:58 GMT, Justin Lu wrote:
>> Issue: Formatter unit tests are launched via basic.sh
>>
>> Fix: Replace basic.sh with a Java test launcher
>>
>> Note: Java.internal.math was included in the original configuration of
>> Basic, but I removed it as it was not used within th
On Thu, 13 Oct 2022 01:02:43 GMT, Justin Lu wrote:
> Issue: java/util/Formatter/Basic regression test emits lots of warning
> messages (~60).
>
> Fix: Made adjustments to Basic-X.java.template as the BasicXXX.java files
> where the errors originate from are generated from the template.
>
>
On Fri, 14 Oct 2022 00:37:53 GMT, Brent Christian wrote:
>> Issue: java/util/Formatter/Basic regression test emits lots of warning
>> messages (~60).
>>
>> Fix: Made adjustments to Basic-X.java.template as the BasicXXX.java files
>> where the errors origina
On Tue, 18 Oct 2022 19:04:29 GMT, Justin Lu wrote:
>> Issue: Formatter unit tests are launched via basic.sh
>>
>> Fix: Replace basic.sh with a Java test launcher
>>
>> Note: Java.internal.math was included in the original configuration of
>> Basic, but I removed it as it was not used within th
On Tue, 18 Oct 2022 19:25:01 GMT, Justin Lu wrote:
>> test/jdk/java/util/Formatter/Basic.java line 90:
>>
>>> 88:
>>> 89: if (fail != 0) {
>>> 90: throw new RuntimeException(String.format("%d tests: %d
>>> failure(s)" +
>>
>> You might consider including `", first"` with t
On Tue, 18 Oct 2022 19:48:15 GMT, Justin Lu wrote:
>> So, the above suggestion gives explicit auto-boxing, though some might find
>> it wordier than necessary.
>>
>> Since `v.byteValue()` already returns a `byte`, the `(byte)` cast doesn't
>> seem necessary. I see that L242 does:
>>> `return -
On Tue, 18 Oct 2022 23:03:16 GMT, Justin Lu wrote:
>> Issue: Formatter unit tests are launched via basic.sh
>>
>> Fix: Replace basic.sh with a Java test launcher
>>
>> Note: Java.internal.math was included in the original configuration of
>> Basic, but I removed it as it was not used within th
On Wed, 19 Oct 2022 22:36:07 GMT, Justin Lu wrote:
>> Issue: Formatter unit tests are launched via basic.sh
>>
>> Fix: Replace basic.sh with a Java test launcher
>>
>> Note: Java.internal.math was included in the original configuration of
>> Basic, but I removed it as it was not used within th
On Thu, 20 Oct 2022 20:17:59 GMT, Justin Lu wrote:
>> Issue: Formatter unit tests are launched via basic.sh
>>
>> Fix: Replace basic.sh with a Java test launcher
>>
>> Note: Java.internal.math was included in the original configuration of
>> Basic, but I removed it as it was not used within th
On Fri, 21 Oct 2022 19:55:55 GMT, Justin Lu wrote:
>> Issue: Resource bundle name does not follow proper naming conventions
>> according to [getBundle
>> method](https://docs.oracle.com/en/java/javase/18/docs/api/java.base/java/util/ResourceBundle.html#getBundle(java.lang.String,java.util.Local
On Mon, 24 Oct 2022 16:37:56 GMT, Justin Lu wrote:
>> Issue: Resource bundle name does not follow proper naming conventions
>> according to [getBundle
>> method](https://docs.oracle.com/en/java/javase/18/docs/api/java.base/java/util/ResourceBundle.html#getBundle(java.lang.String,java.util.Local
On Mon, 24 Oct 2022 21:19:21 GMT, Justin Lu wrote:
>> Issue: Resource bundle name does not follow proper naming conventions
>> according to [getBundle
>> method](https://docs.oracle.com/en/java/javase/18/docs/api/java.base/java/util/ResourceBundle.html#getBundle(java.lang.String,java.util.Local
On Wed, 26 Oct 2022 21:00:43 GMT, Justin Lu wrote:
>> Issue: java/util/Formatter/Basic regression test emits lots of warning
>> messages (~60).
>>
>> Fix: Made adjustments to Basic-X.java.template as the BasicXXX.java files
>> where the errors originate from are generated from the template.
On Fri, 22 Jul 2022 20:51:59 GMT, Brent Christian wrote:
>> Please review this change to replace the finalizer in
>> `AbstractLdapNamingEnumeration` with a Cleaner.
>>
>> The pieces of state required for cleanup (`LdapCtx homeCtx`, `LdapResult
>> res`, and `Ldap
On Fri, 28 Oct 2022 21:51:03 GMT, Justin Lu wrote:
> Issue: Duplication of methods between Basic*.java test classes, due to auto
> generation by genBasic.sh
>
> Fix: Reorganize parts of Basic-X.java.template into base class in Basic.java.
> Toggled -nel flag for generation script (genBasic.sh)
[JDK-8290036](https://bugs.openjdk.org/browse/JDK-8290036) documented the
shutdown sequence, noting that calling Runtime.halt() skips the shutdown
sequence and immediately terminates the VM. Thus, "threads' current methods do
not complete normally or abruptly; no finally clause of any method is
On Thu, 17 Nov 2022 20:08:27 GMT, Lance Andersen wrote:
>> src/java.base/share/classes/java/lang/Runtime.java line 95:
>>
>>> 93: * threads' current methods do not complete normally or abruptly.
>>> 94: * {@linkplain Thread.UncaughtExceptionHandler Uncaught exception
>>> handlers} are not run
finally clause of any method is
> executed".
>
> One ramification of this is that resources within try-with-resource blocks
> will not be released. It would be good to state this explicitly.
Brent Christian has updated the pull request incrementally with one additional
commi
On Thu, 17 Nov 2022 20:36:01 GMT, Brian Burkhalter wrote:
> Is a CSR needed here?
I will check, though the thought is that these are non-normative clarifications
to the normative changes made by
[8290036](https://bugs.openjdk.org/browse/JDK-8290036).
-
PR: https://git.openjdk.org
finally clause of any method is
> executed".
>
> One ramification of this is that resources within try-with-resource blocks
> will not be released. It would be good to state this explicitly.
Brent Christian has updated the pull request incrementally with one additional
commi
On Thu, 17 Nov 2022 20:32:15 GMT, Brent Christian wrote:
>> [JDK-8290036](https://bugs.openjdk.org/browse/JDK-8290036) documented the
>> shutdown sequence, noting that calling Runtime.halt() skips the shutdown
>> sequence and immediately terminates the VM. Thus, "t
On Thu, 17 Nov 2022 22:06:47 GMT, Brent Christian wrote:
> > Is a CSR needed here?
> I will check
A CSR is not needed.
-
PR: https://git.openjdk.org/jdk/pull/11218
finally clause of any method is
> executed".
>
> One ramification of this is that resources within try-with-resource blocks
> will not be released. It would be good to state this explicitly.
Brent Christian has updated the pull request incrementally with one additional
co
finally clause of any method is
> executed".
>
> One ramification of this is that resources within try-with-resource blocks
> will not be released. It would be good to state this explicitly.
Brent Christian has updated the pull request incrementally with one additional
commit s
On Wed, 30 Nov 2022 01:15:54 GMT, Brent Christian wrote:
>> [JDK-8290036](https://bugs.openjdk.org/browse/JDK-8290036) documented the
>> shutdown sequence, noting that calling Runtime.halt() skips the shutdown
>> sequence and immediately terminates the VM. Thus, "t
finally clause of any method is
> executed".
>
> One ramification of this is that resources within try-with-resource blocks
> will not be released. It would be good to state this explicitly.
Brent Christian has updated the pull request incrementally with one additional
co
On Wed, 7 Dec 2022 02:39:55 GMT, David Holmes wrote:
>> Brent Christian has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> put examples into a list, in class doc only, not halt()
>
> src/java.base/share/class
finally clause of any method is
> executed".
>
> One ramification of this is that resources within try-with-resource blocks
> will not be released. It would be good to state this explicitly.
Brent Christian has updated the pull request with a new target base due to a
merge or a
On Thu, 17 Nov 2022 19:25:42 GMT, Brent Christian wrote:
> [JDK-8290036](https://bugs.openjdk.org/browse/JDK-8290036) documented the
> shutdown sequence, noting that calling Runtime.halt() skips the shutdown
> sequence and immediately terminates the VM. Thus, "threads' cu
Backport [8295857](https://bugs.openjdk.org/browse/JDK-8295857) to jdk20
-
Commit messages:
- Backport c7aca73177339f931f7dfb6627365548a32874f7
Changes: https://git.openjdk.org/jdk20/pull/19/files
Webrev: https://webrevs.openjdk.org/?repo=jdk20&pr=19&range=00
Issue: https://bugs.
On Fri, 22 Jul 2022 20:51:59 GMT, Brent Christian wrote:
>> Please review this change to replace the finalizer in
>> `AbstractLdapNamingEnumeration` with a Cleaner.
>>
>> The pieces of state required for cleanup (`LdapCtx homeCtx`, `LdapResult
>> res`, and `Ldap
On Mon, 12 Dec 2022 19:51:22 GMT, Brent Christian wrote:
> Backport [8295857](https://bugs.openjdk.org/browse/JDK-8295857) to jdk20
This pull request has now been integrated.
Changeset: bf78f716
Author: Brent Christian
URL:
https://git.openjdk.org/jdk20/com
On Fri, 22 Jul 2022 20:51:59 GMT, Brent Christian wrote:
>> Please review this change to replace the finalizer in
>> `AbstractLdapNamingEnumeration` with a Cleaner.
>>
>> The pieces of state required for cleanup (`LdapCtx homeCtx`, `LdapResult
>> res`, and `Ldap
On Fri, 22 Jul 2022 20:51:59 GMT, Brent Christian wrote:
>> Please review this change to replace the finalizer in
>> `AbstractLdapNamingEnumeration` with a Cleaner.
>>
>> The pieces of state required for cleanup (`LdapCtx homeCtx`, `LdapResult
>> res`, and `Ldap
On Tue, 21 Feb 2023 18:24:05 GMT, Alan Bateman wrote:
>> Executors.newSingleThreadExecutor returns a delegating ExecutorService that
>> has finalizer to shutdown the underlying TPE when the wrapper is
>> finalizable. It goes back to JDK 6 and JDK-6399443. This is the last
>> non-empty finalize
On Wed, 22 Feb 2023 18:02:46 GMT, Alan Bateman wrote:
>> src/java.base/share/classes/java/util/concurrent/Executors.java line 844:
>>
>>> 842: @Override
>>> 843: public void shutdown() {
>>> 844: cleaner.clean();
>>
>> Hmmm... so now shutdown no longer requires permi
On Wed, 22 Feb 2023 18:57:00 GMT, Alan Bateman wrote:
>> The cleaning action would not have access to the isShutdown() instance
>> method of the (Phantom-reachable) AutoShutdownDelegatedExecutorService.
>
>> The cleaning action would not have access to the isShutdown() instance
>> method of the
On Tue, 21 Feb 2023 20:27:44 GMT, Martin Buchholz wrote:
>> jtreg will look after this. The default timeout is 120s but it can be
>> adjusted with a timeout factor (make time uses a timeout factor of 4). So it
>> would be possible to put a limit on this in the test but it can be
>> problematic
On Fri, 24 Feb 2023 13:44:40 GMT, Alan Bateman wrote:
>> Executors.newSingleThreadExecutor returns a delegating ExecutorService that
>> has finalizer to shutdown the underlying TPE when the wrapper is
>> finalizable. It goes back to JDK 6 and JDK-6399443. This is the last
>> non-empty finalize
On Fri, 22 Jul 2022 20:51:59 GMT, Brent Christian wrote:
>> Please review this change to replace the finalizer in
>> `AbstractLdapNamingEnumeration` with a Cleaner.
>>
>> The pieces of state required for cleanup (`LdapCtx homeCtx`, `LdapResult
>> res`, and `Ldap
With the removal of the AltFinalizer mechanism from `FileInputStream` and
`FileOutputStream` in
[JDK-8192939](https://bugs.openjdk.org/browse/JDK-8192939), this portion of the
Implementation Requirement in the class JavaDoc is no longer true:
> If this FileOutputStream has been subclassed and t
OutputStream has been subclassed and the close() method has been
>> overridden, the close() method will be called when the FileInputStream is
>> unreachable."
>
> The class doc, and the doc for close(), are updated to correctly reflect
> current behavior, and guidance fo
On Fri, 14 Apr 2023 07:57:20 GMT, Alan Bateman wrote:
>> Brent Christian has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> updates, per review comments
>
> src/java.base/share/classes/java/io/FileInpu
On Fri, 14 Apr 2023 22:27:26 GMT, Brent Christian wrote:
>> With the removal of the AltFinalizer mechanism from `FileInputStream` and
>> `FileOutputStream` in
>> [JDK-8192939](https://bugs.openjdk.org/browse/JDK-8192939), this portion of
>> the Implementation Requirem
OutputStream has been subclassed and the close() method has been
>> overridden, the close() method will be called when the FileInputStream is
>> unreachable."
>
> The class doc, and the doc for close(), are updated to correctly reflect
> current behavior, and guidance fo
On Sat, 15 Apr 2023 07:10:46 GMT, Alan Bateman wrote:
>> Brent Christian has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> updates, per review comments
>
> src/java.base/share/classes/java/io/FileInpu
On Tue, 11 Apr 2023 23:55:50 GMT, Brent Christian wrote:
> With the removal of the AltFinalizer mechanism from `FileInputStream` and
> `FileOutputStream` in
> [JDK-8192939](https://bugs.openjdk.org/browse/JDK-8192939), this portion of
> the Implementation Requirement in the clas
On Thu, 20 Apr 2023 18:39:29 GMT, Naoto Sato wrote:
> The current macro assumes the argument is `jint` because all locations pass
> `jint`. However, this would not work if a wider type such as `jlong` is
> passed. Removing the `unsigned` cast and make the condition explicit would
> make the ma
On Fri, 21 Apr 2023 16:22:02 GMT, Naoto Sato wrote:
>> The current macro assumes the argument is `jint` because all locations pass
>> `jint`. However, this would not work if a wider type such as `jlong` is
>> passed. Removing the `unsigned` cast and make the condition explicit would
>> make th
On Tue, 25 Apr 2023 21:43:54 GMT, Roger Riggs wrote:
> It appears that -Xcomp causes the relative timing of the commands to be
> disturbed enough to prevent the correct operation of the test. The test
> should not be run with -Xcomp
Changes requested by bchristi (Reviewer).
test/jdk/java/lang
On Thu, 27 Apr 2023 13:54:53 GMT, Roger Riggs wrote:
>> It appears that -Xcomp causes the relative timing of the commands to be
>> disturbed enough to prevent the correct operation of the test. The test
>> should not be run with -Xcomp
>
> Roger Riggs has updated the pull request incrementally
On Fri, 22 Jul 2022 20:51:59 GMT, Brent Christian wrote:
>> Please review this change to replace the finalizer in
>> `AbstractLdapNamingEnumeration` with a Cleaner.
>>
>> The pieces of state required for cleanup (`LdapCtx homeCtx`, `LdapResult
>> res`, and `Ldap
On Mon, 20 Jun 2022 14:09:27 GMT, Daniel Fuchs wrote:
> Hi,
>
> Please find here a patch that should help the HttpClient's SelectorManager
> thread to terminate more timely, allowing the resources consumed by the
> client to be released earlier.
>
> The idea is to use a Cleaner registered wit
only tests `LdapSearchEnumeration` (not `LdapNamingEnumeration`
> or `LdapBindingEnumeration`, though all are subclasses of
> `AbstractLdapNamingEnumeration`).
>
> Thanks.
Brent Christian has updated the pull request with a new target base due to a
merge or a rebase. The pull req
only tests `LdapSearchEnumeration` (not `LdapNamingEnumeration`
> or `LdapBindingEnumeration`, though all are subclasses of
> `AbstractLdapNamingEnumeration`).
>
> Thanks.
Brent Christian has updated the pull request incrementally with two additional
commits s
On Wed, 20 Jul 2022 22:21:35 GMT, Brent Christian wrote:
>> Please review this change to replace the finalizer in
>> `AbstractLdapNamingEnumeration` with a Cleaner.
>>
>> The pieces of state required for cleanup (`LdapCtx homeCtx`, `LdapResult
>> res`, and `Ldap
only tests `LdapSearchEnumeration` (not `LdapNamingEnumeration`
> or `LdapBindingEnumeration`, though all are subclasses of
> `AbstractLdapNamingEnumeration`).
>
> Thanks.
Brent Christian has updated the pull request incrementally with one additional
commit since the last
On Fri, 22 Jul 2022 20:51:59 GMT, Brent Christian wrote:
>> Please review this change to replace the finalizer in
>> `AbstractLdapNamingEnumeration` with a Cleaner.
>>
>> The pieces of state required for cleanup (`LdapCtx homeCtx`, `LdapResult
>> res`, and `Ldap
On Mon, 26 Sep 2022 18:25:34 GMT, Justin Lu wrote:
> Problem: Unnecessary instances of StringBuffer + .toString()
>
> Fix: StringBuffer Replaced with StringBuilder, and .toString() removed when
> possible
>
> Other: Line 698 in RuleBasedCollator.java also uses a .toString() conversion,
> but
On Thu, 1 Jun 2023 18:19:14 GMT, Mandy Chung wrote:
> Convert `ClassForNameLeak` test to use `jdk.test.lib.util.ForceGC` that would
> be more reliable in waiting for the class loader to be unloaded.
Good changes.
-
Marked as reviewed by bchristi (Reviewer).
PR Review: https://git
On Fri, 2 Jun 2023 01:12:32 GMT, Stuart Marks wrote:
> Create and use new NullableKeyValueHolder class to accommodate map entries
> whose key or value might be null.
Changes look good.
An observation:
`TreeMap` implements `SequencedMap`, and I see that its `firstEntry()` and
related metho
On Wed, 7 Jun 2023 19:03:31 GMT, Mandy Chung wrote:
> Trivial fix. The deploy modules no longer exist. The tests are updated
> not to reference them.
Looks fine.
-
Marked as reviewed by bchristi (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/14367#pullrequestreview-1
On Fri, 22 Jul 2022 20:51:59 GMT, Brent Christian wrote:
>> Please review this change to replace the finalizer in
>> `AbstractLdapNamingEnumeration` with a Cleaner.
>>
>> The pieces of state required for cleanup (`LdapCtx homeCtx`, `LdapResult
>> res`, and `Ldap
On Fri, 16 Jun 2023 15:30:55 GMT, Roger Riggs wrote:
>> Can I get a preliminary review of the wording for Deque.reversed()? If the
>> text is good, I'll make corresponding changes to the implSpecs of the other
>> reversed() default methods, namely those in List, SortedMap, and SortedSet
>> and
On Mon, 26 Jun 2023 23:13:19 GMT, Mandy Chung wrote:
>> This PR updates the spec of `Lookup::findClass` to reflect the current
>> behavior that requires a binary name or a string representing an array class
>> in the form as returned by `Class::getName`.
>>
>> `test/jdk/java/lang/invoke/ac
On Fri, 22 Jul 2022 20:51:59 GMT, Brent Christian wrote:
>> Please review this change to replace the finalizer in
>> `AbstractLdapNamingEnumeration` with a Cleaner.
>>
>> The pieces of state required for cleanup (`LdapCtx homeCtx`, `LdapResult
>> res`, and `Ldap
On Tue, 22 Aug 2023 19:01:53 GMT, Mandy Chung wrote:
>> 8268829: Provide an optimized way to walk the stack with Class object only
>>
>> `StackWalker::walk` creates one `StackFrame` per frame and the current
>> implementation
>> allocates one `StackFrameInfo` and one `MemberName` objects per fr
On Thu, 24 Aug 2023 18:44:14 GMT, Mandy Chung wrote:
>> 8268829: Provide an optimized way to walk the stack with Class object only
>>
>> `StackWalker::walk` creates one `StackFrame` per frame and the current
>> implementation
>> allocates one `StackFrameInfo` and one `MemberName` objects per fr
On Thu, 24 Aug 2023 22:03:53 GMT, Mandy Chung wrote:
> I like separating this from `Option` as it specifies what information to be
> collected from each frame whereas `Option` controls everything else such as
> what frames to be filtered
In my mind, `Option` _already_ can control what informat
Vote: Yes
On 8/25/23 8:23 AM, Roger Riggs wrote:
I hereby nominate Daniel Fuchs to Membership in the Core Libraries Group
Vote: Yes
On 8/25/23 8:23 AM, Roger Riggs wrote:
I hereby nominate Lance Andersen to Membership in the Core Libraries Group
Vote: Yes
On 8/25/23 8:24 AM, Roger Riggs wrote:
I hereby nominate Michael McMahon to Membership in the Core Libraries Group
On Tue, 29 Aug 2023 20:51:56 GMT, Mandy Chung wrote:
>> 8268829: Provide an optimized way to walk the stack with Class object only
>>
>> `StackWalker::walk` creates one `StackFrame` per frame and the current
>> implementation
>> allocates one `StackFrameInfo` and one `MemberName` objects per fr
On Thu, 31 Aug 2023 17:09:40 GMT, Mandy Chung wrote:
>> 8268829: Provide an optimized way to walk the stack with Class object only
>>
>> `StackWalker::walk` creates one `StackFrame` per frame and the current
>> implementation
>> allocates one `StackFrameInfo` and one `MemberName` objects per fr
1 - 100 of 316 matches
Mail list logo
