On Sat, 15 Apr 2023 07:10:46 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> Brent Christian has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> updates, per review comments
>
> src/java.base/share/classes/java/io/FileInputStream.java line 45:
>
>> 43: * @apiNote
>> 44: * The {@link #close} method should be called to release resources used
>> by this
>> 45: * stream, either directly, or by try-with-resources.
>
> The updated wording looks much better. It pre-dates your change but maybe "or
> by try-with-resources" should be changed to "with the {@code
> try}-with-resources statement" while you are there.
Good idea
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13437#discussion_r1169153013
