On Tue, 18 Oct 2022 18:03:57 GMT, Lance Andersen <lan...@openjdk.org> wrote:
>> test/jdk/java/util/Formatter/BasicTestLauncher.java line 47: >> >>> 45: private static final String TZ_UP = "US/Pacific"; >>> 46: // Asia/Novosibirsk time zone >>> 47: private static final String TZ_AN = "Asia/Novosibirsk"; >> >> IMO it's not necessary to create constants if they'll only be used as a >> ValueSource > > True, but really a personal choice as it makes the ValueSource less wordy ;-) Also, when reading through a ValueSource / DataProvider, it's nice to see the actual values (vs variable/constant names) when practical/possible. ------------- PR: https://git.openjdk.org/jdk/pull/10715
