On Wed, 30 Oct 2024 00:44:14 GMT, Patricio Chilano Mateo
wrote:
>> This is the implementation of JEP 491: Synchronize Virtual Threads without
>> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
>> further details.
>>
>> In order to make the code review easier the change
> A straightforward optimization, to share the signature parsing of method,
> constructor, and field between the root and the copied objects, like how
> method handle accessors are shared.
Chen Liang has updated the pull request with a new target base due to a merge
or a rebase. The pull reques
On Tue, 29 Oct 2024 13:12:56 GMT, Aleksey Shipilev wrote:
>> This is forked from
>> [JDK-8342642](https://bugs.openjdk.org/browse/JDK-8342642) and filed as a
>> general issue for archived boxed Integer cache when it's recreated at
>> runtime. In short, current code drops the entire primitive c
On Fri, 25 Oct 2024 08:25:21 GMT, Axel Boldt-Christmas
wrote:
>> This is the implementation task for `JEP 490: ZGC: Remove the
>> Non-Generational Mode`. See the JEP for details.
>> [JDK-8335850](https://bugs.openjdk.org/browse/JDK-8335850)
>
> Axel Boldt-Christmas has updated the pull request
On Wed, 30 Oct 2024 02:23:20 GMT, David Holmes wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix 32/64-bit confusion in comment in VirtualMachineImpl.c
>
> src/hotspot/os_cpu/windows_x86/os_windows_x86.cpp
On Fri, 25 Oct 2024 06:49:48 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which cleans up references to "JRE"
> from the launcher's code?
>
> No functional changes have been introduced in this change.
>
> No new tests have been introduced and existing tests in tier1, tie
On Wed, 30 Oct 2024 02:18:00 GMT, David Holmes wrote:
>> Yes. As Julian says, it's something we set up in our builds:
>>
>> if test "x$FLAGS_CPU_BITS" = x64; then
>> $1_DEFINES_CPU_JDK="${$1_DEFINES_CPU_JDK} -D_LP64=1"
>> $1_DEFINES_CPU_JVM="${$1_DEFINES_CPU_JVM} -D_LP64=1"
>> fi
>
>
On Sun, 20 Oct 2024 06:50:45 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which does a tiny cleanup in the
>> macosx specific code in `java_props_macosx.c`?
>>
>> As noted in https://bugs.openjdk.org/browse/JDK-8342647 the
>> `setOSNameAndVersion` function used to dynam
> This is forked from
> [JDK-8342642](https://bugs.openjdk.org/browse/JDK-8342642) and filed as a
> general issue for archived boxed Integer cache when it's recreated at
> runtime. In short, current code drops the entire primitive cache when the CDS
> archived version of the cache is too short.
On Wed, 21 Aug 2024 16:03:15 GMT, Chen Liang wrote:
>> A straightforward optimization, to share the signature parsing of method,
>> constructor, and field between the root and the copied objects, like how
>> method handle accessors are shared.
>
> Chen Liang has updated the pull request with a
> This is forked from
> [JDK-8342642](https://bugs.openjdk.org/browse/JDK-8342642) and filed as a
> general issue for archived boxed Integer cache when it's recreated at
> runtime. In short, current code drops the entire primitive cache when the CDS
> archived version of the cache is too short.
On Wed, 30 Oct 2024 07:22:42 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which cleans up references to "JRE"
>> from the launcher's code?
>>
>> No functional changes have been introduced in this change.
>>
>> No new tests have been introduced and existing tests in tier
On Tue, 29 Oct 2024 12:55:32 GMT, Aleksey Shipilev wrote:
>> src/java.base/share/classes/java/lang/Byte.java line 128:
>>
>>> 126: }
>>> 127: archivedCache = c;
>>> 128: } else if (archivedCache.length != size) {
>>
>> The `else` case for the non-int
On Tue, 29 Oct 2024 08:13:22 GMT, Jan Lahoda wrote:
>> This PR is simply adding parameter-less `java.io.IO.{println(),readln()}`,
>> with the (hopefully) obvious semantics, plus the corresponding wiring to
>> make those work. This may become part of JEP 495:
>> https://openjdk.org/jeps/495
>
>
> The Type and AnnotatedType hierarchies have been enigmatic to new users:
> users have no clue how to categorize arbitrary type objects, when it is safe
> to cast to more specific types, and the exact conditions for method contracts.
>
> A manifest is [JDK-8306039](https://bugs.openjdk.org/brow
On Wed, 30 Oct 2024 07:22:42 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which cleans up references to "JRE"
>> from the launcher's code?
>>
>> No functional changes have been introduced in this change.
>>
>> No new tests have been introduced and existing tests in tier
On Tue, 29 Oct 2024 08:13:22 GMT, Jan Lahoda wrote:
>> This PR is simply adding parameter-less `java.io.IO.{println(),readln()}`,
>> with the (hopefully) obvious semantics, plus the corresponding wiring to
>> make those work. This may become part of JEP 495:
>> https://openjdk.org/jeps/495
>
>
On Tue, 29 Oct 2024 10:19:36 GMT, Per Minborg wrote:
>> This PR prevents sequence layout with padding to be used with the Linker.
>
> Per Minborg has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated changes
> brought in
On Tue, 29 Oct 2024 12:42:47 GMT, Jorn Vernee wrote:
>> This PR proposes to add a small text segment on the
>> `MemorySegment::reinterpret` overloads that takes an Arena stating the
>> responsibility of actually freeing reinterpreted segments lies with the
>> *original* arena.
>
> src/java.bas
On Fri, 25 Oct 2024 08:25:21 GMT, Axel Boldt-Christmas
wrote:
>> This is the implementation task for `JEP 490: ZGC: Remove the
>> Non-Generational Mode`. See the JEP for details.
>> [JDK-8335850](https://bugs.openjdk.org/browse/JDK-8335850)
>
> Axel Boldt-Christmas has updated the pull request
On Tue, 29 Oct 2024 23:48:22 GMT, Kim Barrett wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix 32/64-bit confusion in comment in VirtualMachineImpl.c
>
> make/scripts/compare.sh line 79:
>
>> 77:
>> 78:
On Tue, 8 Oct 2024 07:20:49 GMT, Axel Boldt-Christmas
wrote:
> This is the implementation task for `JEP 490: ZGC: Remove the
> Non-Generational Mode`. See the JEP for details.
> [JDK-8335850](https://bugs.openjdk.org/browse/JDK-8335850)
This pull request has now been integrated.
Changeset: 8
On Wed, 30 Oct 2024 00:07:33 GMT, Kim Barrett wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> adlc need _CRT_NONSTDC_NO_WARNINGS as well... *sigh*
>
> src/hotspot/cpu/x86/sharedRuntime_x86_32.cpp line 1433:
>
> This is the implementation of [JEP 479: _Remove the Windows 32-bit x86
> Port_](https://openjdk.org/jeps/479).
>
> This is the summary of JEP 479:
>> Remove the source code and build support for the Windows 32-bit x86 port.
>> This port was [deprecated for removal in JDK
>> 21](https://openjd
> A straightforward optimization, to share the signature parsing of method,
> constructor, and field between the root and the copied objects, like how
> method handle accessors are shared.
Chen Liang has updated the pull request incrementally with one additional
commit since the last revision:
On Tue, 29 Oct 2024 10:43:58 GMT, Vladimir Kozelkov wrote:
> > Should we disallow sequence layouts with an element count of zero?
>
> I think this should be done in specific implementations (if at all), not in
> AbstractLinker, where general rules of "what is definitely wrong" apply. At
> leas
On Wed, 30 Oct 2024 03:05:32 GMT, Kim Barrett wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Error in os_windows.cpp for unknown cpu
>
> src/hotspot/share/adlc/main.cpp line 494:
>
>> 492: }
>> 493:
>> 494
On Wed, 30 Oct 2024 08:54:55 GMT, kabutz wrote:
> The ArrayBlockingQueue has had a readObject() method since Java 7, which
> checks invariants of the deserialized object. However, it does not have a
> writeObject() method. This means that the ArrayBlockingQueue could be
> modified whilst it is
On Tue, 29 Oct 2024 20:22:03 GMT, Magnus Ihse Bursie wrote:
>> This is the implementation of [JEP 479: _Remove the Windows 32-bit x86
>> Port_](https://openjdk.org/jeps/479).
>>
>> This is the summary of JEP 479:
>>> Remove the source code and build support for the Windows 32-bit x86 port.
>>>
On Wed, 30 Oct 2024 12:42:16 GMT, Jorn Vernee wrote:
> I think it's technically correct, but I think it's starting off on the wrong
> foot. There's no transfer of ownership happening, `reinterpret` just returns
> a view of the old memory region with a new scope borrowed from the given
> arena.
This is a partial implementation of JEP 495 - adjustments of the JEP metadata
in `PreviewFeature`. There are no language changes associated with this JEP.
Changes to the `java.io.IO` class are covered by
https://github.com/openjdk/jdk/pull/21693.
-
Commit messages:
- 8335991: Impl
On Wed, 30 Oct 2024 12:30:25 GMT, Julian Waters wrote:
>> I'm glad you're giving some TLC to adlc. It is in desperate need of it.
>
> TLC?
https://www.vocabulary.com/dictionary/TLC
-
PR Review Comment: https://git.openjdk.org/jdk/pull/21744#discussion_r1822628499
On Mon, 28 Oct 2024 08:34:14 GMT, Alan Bateman wrote:
> This is an update to the Virtual thread implementation that we'd like to
> integrate in advance of JEP 491.
>
> The update removes the use of "temporary transitions", basically cases where
> the thread identity switches to the carrier th
On Wed, 30 Oct 2024 12:49:16 GMT, Jan Lahoda wrote:
> Do I miss something?
Okay, so this must have been modified at some point to add/use
isSupportedModuleDescriptorVersion, in which case readModuleAttribute won't be
called. In that case, what you have is okay.
Minor nit, can you fix up the c
On Wed, 30 Oct 2024 05:12:18 GMT, Joe Darcy wrote:
>> src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Float16.java
>> line 504:
>>
>>> 502: // without the period.
>>> 503: hexSignificand.append(s.substring(digitStart,
>>> periodIndex));
On Wed, 30 Oct 2024 13:32:22 GMT, Alexey Semenyuk wrote:
>> Make jpackage correctly handle the output directory (`--dest`) that is:
>> - a subdirectory of the input directory;
>> - the same as the input directory.
>>
>> Make jpackage correctly handle temp directory (`--temp`) that is:
>> - a
Can I please get a review of this change which cleans up a leftover code from
the launcher's java_md_macosx.m file?
In https://bugs.openjdk.org/browse/JDK-8329862 changes were done in the
launcher code to remove checks for `/jre/lib/` when determining the
JDK installation root. Those changes w
> Currently, to efficiently check if a `ClassEntry`, such as one from an
> `InvokeInstruction`, is of a particular class, we use such a pattern (as seen
> in JEP 486 [Appendix](https://openjdk.org/jeps/486#Appendix)):
>
> inst.owner().name().equalsString("java/lang/System")
>
> This pattern has
On Tue, 29 Oct 2024 02:56:30 GMT, Serguei Spitsyn wrote:
>> Patricio Chilano Mateo has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix comment in VThreadWaitReenter
>
> src/hotspot/share/prims/jvmtiEnvBase.cpp line 1082:
>
>> 1080:
> This is the implementation of JEP 491: Synchronize Virtual Threads without
> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
> further details.
>
> In order to make the code review easier the changes have been split into the
> following initial 4 commits:
>
> - Change
On Tue, 29 Oct 2024 18:35:05 GMT, Brent Christian wrote:
>> Sean Mullan has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 186 commits:
>>
>> - Merge remote-tracking branch 'jdk-sandbox/jep486' into JDK-8338411
>> - Update copyrigh
On Fri, 25 Oct 2024 20:44:25 GMT, Roger Riggs wrote:
>> Sean Mullan has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 150 commits:
>>
>> - Merge remote-tracking branch 'jdk-sandbox/jep486' into JDK-8338411
>> - Merge
>> - Update
On Wed, 30 Oct 2024 09:44:42 GMT, Serguei Spitsyn wrote:
>> Patricio Chilano Mateo has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Add klass_name check for is_object_wait0
>> - Fix comment in continuation.hpp
>
> src/hotspot/share/run
On Mon, 28 Oct 2024 20:12:27 GMT, Roger Riggs wrote:
> Reviewed all tests under test/jaxp/javax/xml/jaxp. A few imports moved around
> unnecessarily but otherwise looks fine.
JAXP test comments fixed in
https://github.com/openjdk/jdk/pull/21498/commits/5577e4884710eba498ee5f40fa85d47eaa07364d
Support `win.norestart` application property in jpackage .cfg file. If found in
the .cfg file and set to `true`, it forces the Windows app launcher not to
restart the launcher process.
Collateral changes to the tests:
- Added `WindowsHelper.killProcess()` to kill process by PID;
- Added `Windo
On Wed, 30 Oct 2024 16:58:40 GMT, Eirik Bjørsnøs wrote:
> Please review this PR which makes `ZipFile.Source::initCEN` throw
> `java.util.zip.ZipException` instead of `java.lang.IllegalArgumentException`
> when calling `ZipCoder::checkedHash` during `META-INF/versions/` parsing.
>
> This is a f
On Tue, 29 Oct 2024 13:04:18 GMT, Aleksey Shipilev wrote:
>> src/java.base/share/classes/java/lang/Integer.java line 964:
>>
>>> 962: Integer[] c = new Integer[size];
>>> 963: int j = low;
>>> 964: // Use all cached values from the archive to avoid
On Wed, 30 Oct 2024 12:57:50 GMT, Maurizio Cimadamore
wrote:
> But then, somewhere else say:
>
> "The returned segment is backed by the same memory region as that of the
> original segment. As such, the region of memory backing the returned segment
> is truly deallocated only when the origina
> This is a current patch for module imports declarations, second preview. At
> least the JEP number and preview revision will need to be updated in
> `jdk.internal.javac.PreviewFeature.Feature`, but otherwise I believe this is
> ready to receive feedback.
>
> The main changes are:
> - `require
On Wed, 30 Oct 2024 13:22:21 GMT, Alan Bateman wrote:
>> I believe the check is already being done, right on the next line:
>> https://github.com/openjdk/jdk/blob/821c514a132e809a14648ddbb56f2ffee85fd35a/src/java.base/share/classes/jdk/internal/module/ModuleInfo.java#L192
>> which leads to:
>> ht
On Wed, 30 Oct 2024 16:17:20 GMT, Claes Redestad wrote:
>> src/java.base/share/classes/java/util/zip/ZipFile.java line 1798:
>>
>>> 1796:
>>> metaVersions.computeIfAbsent(hashCode, _ -> new BitSet()).set(version);
>>> 1797: } catch (Ex
On Wed, 30 Oct 2024 18:11:54 GMT, Pavel Rappo wrote:
>> Prepare for JDK 25.
>
> Pavel Rappo has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update --release 24 symbol information for JDK 24 build 21
>
> The macOS/AArch64 build 21 was t
On Tue, 29 Oct 2024 14:51:33 GMT, Per Minborg wrote:
> This PR proposes to improve `MemorySegment::ofBuffer` making it more amenable
> to inlining and generally improving performance.
>
> Testing successfully on tier1-3
src/java.base/share/classes/jdk/internal/foreign/AbstractMemorySegmentImpl
This PR proposes to improve `MemorySegment::ofBuffer` making it more amenable
to inlining and generally improving performance.
Testing successfully on tier1-3
-
Commit messages:
- Remove switch rake and move factories to Buffer impls
- Clean up generated code
- Revert changes
-
On Wed, 30 Oct 2024 19:28:32 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
On Tue, 29 Oct 2024 17:07:56 GMT, Harshitha Onkar wrote:
>> src/java.desktop/share/classes/java/awt/Font.java line 1613:
>>
>>> 1611: * interpreted as a {@code Font} object according to the
>>> 1612: * specification of {@code Font.decode(String)}
>>> 1613: * If the specified prope
On Wed, 30 Oct 2024 11:18:27 GMT, Magnus Ihse Bursie wrote:
>> This is the implementation of [JEP 479: _Remove the Windows 32-bit x86
>> Port_](https://openjdk.org/jeps/479).
>>
>> This is the summary of JEP 479:
>>> Remove the source code and build support for the Windows 32-bit x86 port.
>>>
On Wed, 30 Oct 2024 11:18:27 GMT, Magnus Ihse Bursie wrote:
>> This is the implementation of [JEP 479: _Remove the Windows 32-bit x86
>> Port_](https://openjdk.org/jeps/479).
>>
>> This is the summary of JEP 479:
>>> Remove the source code and build support for the Windows 32-bit x86 port.
>>>
On Wed, 30 Oct 2024 11:18:27 GMT, Magnus Ihse Bursie wrote:
>> This is the implementation of [JEP 479: _Remove the Windows 32-bit x86
>> Port_](https://openjdk.org/jeps/479).
>>
>> This is the summary of JEP 479:
>>> Remove the source code and build support for the Windows 32-bit x86 port.
>>>
On Wed, 30 Oct 2024 16:14:48 GMT, Jaikiran Pai wrote:
>> Eirik Bjørsnøs has updated the pull request incrementally with four
>> additional commits since the last revision:
>>
>> - Map versions by entry name hashcode instead of by entry name. This avoids
>> String allocation and storage
>> -
On Wed, 30 Oct 2024 10:02:22 GMT, Chen Liang wrote:
>> A straightforward optimization, to share the signature parsing of method,
>> constructor, and field between the root and the copied objects, like how
>> method handle accessors are shared.
>
> Chen Liang has updated the pull request increme
On Wed, 30 Oct 2024 12:11:26 GMT, Aleksey Shipilev wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix 32/64-bit confusion in comment in VirtualMachineImpl.c
>
> make/hotspot/gensrc/GensrcAdlc.gmk line 50:
>
On Fri, 18 Oct 2024 13:59:32 GMT, Eirik Bjørsnøs wrote:
>> Please review this PR which speeds up `JarFile::getEntry` lookup
>> significantly for multi-release JAR files.
>>
>> The changes in this PR are motivated by the following insights:
>>
>> * `META-INF/versions/` is sparsely populated.
>>
On Wed, 30 Oct 2024 06:11:27 GMT, Julian Waters wrote:
>> src/java.base/windows/native/libjava/HostLocaleProviderAdapter_md.c line 970:
>>
>>> 968: // int got = 0;
>>> 969:
>>> 970: /*
>>
>> Don't understand this one at all - what did gcc actually complain about
>> here? This code all seems
Please review this PR which makes `ZipFile.Source::initCEN` throw
`java.util.zip.ZipException` instead of `java.lang.IllegalArgumentException`
when calling `ZipCoder::checkedHash` during `META-INF/versions/` parsing.
This is a follow-up to #21489 where the IAE was introduced on the premise that
On Sat, 26 Oct 2024 01:16:05 GMT, Alexey Semenyuk wrote:
> Support `win.norestart` application property in jpackage .cfg file. If found
> in the .cfg file and set to `true`, it forces the Windows app launcher not to
> restart the launcher process.
>
> Collateral changes to the tests:
> - Adde
> Prepare for JDK 25.
Pavel Rappo has updated the pull request incrementally with one additional
commit since the last revision:
Update --release 24 symbol information for JDK 24 build 21
The macOS/AArch64 build 21 was taken from https://jdk.java.net/24/
-
Changes:
- all:
On Wed, 30 Oct 2024 10:07:22 GMT, Aleksey Shipilev wrote:
>> This is forked from
>> [JDK-8342642](https://bugs.openjdk.org/browse/JDK-8342642) and filed as a
>> general issue for archived boxed Integer cache when it's recreated at
>> runtime. In short, current code drops the entire primitive c
On Wed, 30 Oct 2024 16:52:16 GMT, Claes Redestad wrote:
>> Hello Claes,
>>
>>> if there's an encoding error we'd have thrown earlier when hashing over the
>>> full name.
>>
>> If I understand correctly, then I think you are referring to the
>> `ZipCoder.checkedHash()` which throws that `Exce
On Thu, 24 Oct 2024 06:14:18 GMT, John R Rose wrote:
> A thought for a possible cleanup, after this PR is done…
>
> The scratch mirror logic had me… scratching my head. It seems to me that a
> more descriptive name would make the code explain itself better. I suggest
> (for a future cleanup) c
On Wed, 30 Oct 2024 17:37:25 GMT, Naoto Sato wrote:
>> The warning received is that got is set but not used - I had a look at
>> getLocaleInfoWrapper and it seems like it has no side effects, its only
>> purpose is to return a value, which is the variable got in this case. I'm
>> pretty certai
On Wed, 30 Oct 2024 00:44:14 GMT, Patricio Chilano Mateo
wrote:
>> This is the implementation of JEP 491: Synchronize Virtual Threads without
>> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
>> further details.
>>
>> In order to make the code review easier the change
On Tue, 29 Oct 2024 23:16:29 GMT, Dean Long wrote:
>> Patricio Chilano Mateo has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix comment in VThreadWaitReenter
>
> src/hotspot/share/runtime/continuationFreezeThaw.cpp line 1411:
>
>> 1409
On Wed, 30 Oct 2024 19:31:26 GMT, Justin Lu wrote:
>> It does seem a bug, where the return value is not handled correctly. Can you
>> please file a separate bug?
>
>> I had a look at getLocaleInfoWrapper and it seems like it has no side
>> effects, its only purpose is to return a value
>
> Whi
On Wed, 30 Oct 2024 11:18:27 GMT, Magnus Ihse Bursie wrote:
>> This is the implementation of [JEP 479: _Remove the Windows 32-bit x86
>> Port_](https://openjdk.org/jeps/479).
>>
>> This is the summary of JEP 479:
>>> Remove the source code and build support for the Windows 32-bit x86 port.
>>>
> A straightforward optimization, to share the signature parsing of method,
> constructor, and field between the root and the copied objects, like how
> method handle accessors are shared.
Chen Liang has updated the pull request incrementally with one additional
commit since the last revision:
Hi,
This has been discussed when we did JEP 400: UTF-8 by Default and
decided not to do it, mainly because it affects filename/path encoding.
Changing `sun.jnu.encoding` apart from Windows system encoding will make
apps not being able to access those files/directories (e.g. home
directory) if
On Tue, 29 Oct 2024 11:58:44 GMT, Aleksey Shipilev wrote:
> Second problem is the behavior for boxed Integers outside [-128; 127] range.
> JLS 5.1.7 has no provisions about the identity of these boxes: neither a
> guarantee they would be cached, nor a guarantee that they would _not_ be
> cache
> This is the implementation of JEP 486: Permanently Disable the Security
> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
> main changes in the JEP and also includes an apidiff of the specif
On Wed, 30 Oct 2024 11:18:27 GMT, Magnus Ihse Bursie wrote:
>> This is the implementation of [JEP 479: _Remove the Windows 32-bit x86
>> Port_](https://openjdk.org/jeps/479).
>>
>> This is the summary of JEP 479:
>>> Remove the source code and build support for the Windows 32-bit x86 port.
>>>
On Windows, java.exe determines the value of "sun.jnu.encoding" and thus
the encoding of any command-line arguments, environment variables, file
names etc. based on the process' active code page (using the GetACP()
Windows API function). On a vanilla Windows machine, this is typically a
legacy code
On Wed, 30 Oct 2024 16:42:18 GMT, Chen Liang wrote:
>> A straightforward optimization, to share the signature parsing of method,
>> constructor, and field between the root and the copied objects, like how
>> method handle accessors are shared.
>
> Chen Liang has updated the pull request increme
On Wed, 30 Oct 2024 18:11:54 GMT, Pavel Rappo wrote:
>> Prepare for JDK 25.
>
> Pavel Rappo has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update --release 24 symbol information for JDK 24 build 21
>
> The macOS/AArch64 build 21 was t
On Tue, 29 Oct 2024 14:51:33 GMT, Per Minborg wrote:
> This PR proposes to improve `MemorySegment::ofBuffer` making it more amenable
> to inlining and generally improving performance.
>
> Testing successfully on tier1-3
It would be great if we could find a benchmark where inlining doesn't happ
On Tue, 29 Oct 2024 14:51:33 GMT, Per Minborg wrote:
> This PR proposes to improve `MemorySegment::ofBuffer` making it more amenable
> to inlining and generally improving performance.
>
> Testing successfully on tier1-3
src/java.base/share/classes/java/nio/Buffer.java line 33:
> 31: import jd
On Wed, 30 Oct 2024 08:49:56 GMT, Chen Liang wrote:
>> The Type and AnnotatedType hierarchies have been enigmatic to new users:
>> users have no clue how to categorize arbitrary type objects, when it is safe
>> to cast to more specific types, and the exact conditions for method
>> contracts.
>
On Wed, 30 Oct 2024 00:44:14 GMT, Patricio Chilano Mateo
wrote:
>> This is the implementation of JEP 491: Synchronize Virtual Threads without
>> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
>> further details.
>>
>> In order to make the code review easier the change
On Fri, 25 Oct 2024 21:18:41 GMT, Sean Mullan wrote:
> Comments on `java.security` classes.
>
> Also, I'd like to see some clarifications on what "the installed policy" or
> "the current policy" is. The `ProtectionDomain` mentions this when talking
> about dynamic permissions. On the other han
On Tue, 29 Oct 2024 14:19:05 GMT, Weijun Wang wrote:
>> test/jdk/javax/xml/crypto/dsig/ErrorHandlerPermissions.java line 1:
>>
>>> 1: /*
>>
>> @wangweij It looks like this test can be deleted as it was specifically
>> trying to check that a `SecurityException` wasn't thrown, or did you think
On Wed, 30 Oct 2024 19:11:46 GMT, Ioi Lam wrote:
>> A thought for a possible cleanup, after this PR is done…
>>
>> The scratch mirror logic had me… scratching my head. It seems to me that a
>> more descriptive name would make the code explain itself better. I suggest
>> (for a future cleanup
On Wed, 30 Oct 2024 18:43:45 GMT, Maurizio Cimadamore
wrote:
>> This PR proposes to improve `MemorySegment::ofBuffer` making it more
>> amenable to inlining and generally improving performance.
>>
>> Testing successfully on tier1-3
>
> It would be great if we could find a benchmark where inlin
On Wed, 30 Oct 2024 03:13:02 GMT, Kim Barrett wrote:
>> It's something we do in our build. For us, _LP64 really means 64 bit
>
> It seems like the `_WIN64` check here was never useful. It's also been there
> since before the
> mercurial age.
The "mercurial age". Sounds like something in-betwee
> Make jpackage correctly handle the output directory (`--dest`) that is:
> - a subdirectory of the input directory;
> - the same as the input directory.
>
> Make jpackage correctly handle temp directory (`--temp`) that is:
> - a subdirectory of the input directory.
>
> jpackage will produce a
On Wed, 30 Oct 2024 03:24:48 GMT, Kim Barrett wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Error in os_windows.cpp for unknown cpu
>
> src/java.base/windows/native/libjava/gdefs_md.h line 31:
>
>> 29:
>>
On Wed, 30 Oct 2024 08:17:02 GMT, Jaikiran Pai wrote:
>> Jan Lahoda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixing test for Console.readln/readLine, ensuring the proper methods are
>> called.
>
> src/java.base/share/classes/java
On Wed, 30 Oct 2024 11:05:17 GMT, Magnus Ihse Bursie wrote:
>> make/scripts/compare.sh line 1457:
>>
>>> 1455: THIS_SEC_BIN="$THIS_SEC_DIR/sec-bin.zip"
>>> 1456: if [ "$OPENJDK_TARGET_OS" = "windows" ]; then
>>> 1457: JGSS_WINDOWS_BIN="jgss-windows-x64-bin.zip"
>>
>>
On Wed, 30 Oct 2024 09:07:47 GMT, Evemose wrote:
>> src/java.base/share/classes/java/io/Console.java line 240:
>>
>>> 238: * if an end of stream has been reached without having
>>> read
>>> 239: * any characters.
>>> 240: *
>>
>> Should we specify (both here an
On Wed, 30 Oct 2024 11:19:03 GMT, Magnus Ihse Bursie wrote:
>> src/hotspot/share/adlc/main.cpp line 494:
>>
>>> 492: }
>>> 493:
>>> 494: #if !defined(_WIN32) || defined(_WIN64)
>>
>> Removing the conditionalization is fine for this change. But see also
>> https://bugs.openjdk.org/browse/JDK-
> This is the implementation of [JEP 479: _Remove the Windows 32-bit x86
> Port_](https://openjdk.org/jeps/479).
>
> This is the summary of JEP 479:
>> Remove the source code and build support for the Windows 32-bit x86 port.
>> This port was [deprecated for removal in JDK
>> 21](https://openjd
On Wed, 30 Oct 2024 10:58:22 GMT, Maurizio Cimadamore
wrote:
>> src/java.base/share/classes/java/lang/foreign/MemorySegment.java line 766:
>>
>>> 764: * method returns a segment that behaves as if it had been
>>> allocated using the
>>> 765: * provided arena except, the returned segm
1 - 100 of 177 matches
Mail list logo
