On Wed, 30 Oct 2024 06:11:27 GMT, Julian Waters <jwat...@openjdk.org> wrote:
>> src/java.base/windows/native/libjava/HostLocaleProviderAdapter_md.c line 970: >> >>> 968: // int got = 0; >>> 969: >>> 970: /* >> >> Don't understand this one at all - what did gcc actually complain about >> here? This code all seems used. > > The warning received is that got is set but not used - I had a look at > getLocaleInfoWrapper and it seems like it has no side effects, its only > purpose is to return a value, which is the variable got in this case. I'm > pretty certain got not being used is a bug, and that it is needed somewhere, > but someone forgot to hook it up to whatever needs it It does seem a bug, where the return value is not handled correctly. Can you please file a separate bug? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21654#discussion_r1823108884
