On Fri, 13 Sep 2024 06:53:19 GMT, Per Minborg wrote:
>> I think we need the try block anyhow as we have to deal with a String. But
>> might be slightly better. We could revisit this later.
>
> It would look like this:
>
>
> static int powerOfPropertyOr(String name, int defaultPower) {
>
On Fri, 13 Sep 2024 06:56:20 GMT, Per Minborg wrote:
>> It would look like this:
>>
>>
>> static int powerOfPropertyOr(String name, int defaultPower) {
>> final String property =
>> GetPropertyAction.privilegedGetProperty(PROPERTY_PATH + name,
>> Integer.toString(defaultPower));
>
This PR suggests to simplify the. method
`SegmebtBulkOperations::powerOfPropertyOr`.
-
Commit messages:
- Fix merge error
- Merge master
- Simplify further
- Simplify method
- Use privilegedGetProperty
Changes: https://git.openjdk.org/jdk/pull/20985/files
Webrev: https://webr
On Fri, 13 Sep 2024 06:58:22 GMT, Jaikiran Pai wrote:
>> https://bugs.openjdk.org/browse/JDK-8340089
>
> I think there's a oversight here. What we meant was a separate
> GetIntegerAction class instead of GetPropertyAction. The code would then look
> like:
>
>
> final int power =
> sun.securi
On Fri, 13 Sep 2024 07:04:24 GMT, Per Minborg wrote:
> This PR suggests to simplify the. method
> `SegmebtBulkOperations::powerOfPropertyOr`.
This looks good to me.
-
Marked as reviewed by jpai (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/20985#pullrequestreview-230229
On Fri, 13 Sep 2024 02:47:18 GMT, Joe Darcy wrote:
> Candidates for this refactoring were found programmatically; the program to
> find candidates is in a comment on the bug.
The old version of the doc comments had a `.` at the end of the first sentence:
src/java.base/share/classes/java/io/Obj
On Thu, 12 Sep 2024 19:29:47 GMT, Chen Liang wrote:
> I think we can elide the `Lookup` argument to perform a
> always-full-permission lookup operation to simplify call sequence; or, to
> elide the `recv` receiver argument as it is almost always
> `lookup.lookupClass()` (except for a few lazy
> This PR suggests introducing an internal class in `java.base` to simplify the
> use of some `MethodHandles.Lookup` operations.
>
> While the utility of the methods might appear to be limited in classes with
> many static `VarHandle`/`MethodHandle` variables, it should be noted that the
> clas
On Fri, 13 Sep 2024 07:39:40 GMT, Per Minborg wrote:
> If we could access `MethodHandles.Lookup.IMPL_LOOKUP `, we could use this as
> a lookup and elide the lookup arg. Any ideas to do this in a "polite" way?
Lookup.IMPL_LOOKUP should be guarded closely, I don't think we should remove
the need
On Fri, 13 Sep 2024 07:04:24 GMT, Per Minborg wrote:
> This PR suggests to simplify the. method
> `SegmebtBulkOperations::powerOfPropertyOr`.
This pull request has now been integrated.
Changeset: 0c36177f
Author:Per Minborg
URL:
https://git.openjdk.org/jdk/commit/0c36177fead8b64a4c
> `Math.scalb(double)` can be simplified, removing a loop and using
> larger/smaller factors.
Raffaello Giulietti has updated the pull request incrementally with one
additional commit since the last revision:
Slight improvement.
-
Changes:
- all: https://git.openjdk.org/jdk/pu
On Fri, 13 Sep 2024 07:29:00 GMT, ExE Boss wrote:
> The old version of the doc comments had a `.` at the end of the first
> sentence:
The new version has it too, but in the final, generated form:
https://docs.oracle.com/en/java/javase/22/docs/specs/javadoc/doc-comment-spec.html#return
`{@retu
On Wed, 11 Sep 2024 00:29:30 GMT, Srinivas Vamsi Parasa
wrote:
>> The goal of this PR is to implement an x86_64 intrinsic for
>> java.lang.Math.tanh() using libm
>>
>> Benchmark (ops/ms) | Stock JDK | Tanh intrinsic | Speedup
>> -- | -- | -- | --
>> MathBench.tanhDouble | 70900 | 95618 | 1.35x
On Thu, 12 Sep 2024 12:44:41 GMT, Per Minborg wrote:
>> This PR proposes to add a new overload to `MemorySegment::getString` whereby
>> it is possible to pass in a known byte length of the content in a segment
>> that should be converted to a String. This is useful in case one already
>> knows
On Thu, 12 Sep 2024 19:30:45 GMT, Chen Liang wrote:
>> Per Minborg has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Rename and reformat
>
> src/java.base/share/classes/jdk/internal/reflect/MethodHandlesInternal.java
> line 1:
>
>> 1: /*
Hello!
JEP 471 says that 79 methods out of 87 have been deprecated in
sun.misc.Unsafe. However, I have a different number.
Deprecated for removal in Java 18:
1. public long objectFieldOffset(Field f)
2. public Object staticFieldBase(Field f)
3. public long staticFieldOffset(Field f)
Deprecated f
On Fri, 13 Sep 2024 02:47:18 GMT, Joe Darcy wrote:
> Candidates for this refactoring were found programmatically; the program to
> find candidates is in a comment on the bug.
Thanks, Joe. This looks good, especially considering that the change was
produced with the help of a quick-and-dirty, r
> This PR proposes to add a new overload to `MemorySegment::getString` whereby
> it is possible to pass in a known byte length of the content in a segment
> that should be converted to a String. This is useful in case one already
> knows the byte length and thereby does not need to scan for a nu
On Fri, 13 Sep 2024 10:27:27 GMT, Per Minborg wrote:
>> This PR proposes to add a new overload to `MemorySegment::getString` whereby
>> it is possible to pass in a known byte length of the content in a segment
>> that should be converted to a String. This is useful in case one already
>> knows
On Tue, 10 Sep 2024 06:15:57 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which cleans up the code in the
> `java` launcher? The original motivation for the change was to prevent the
> `java` launcher's C code from parsing a jar's manifest when launching an
> application
On Fri, 13 Sep 2024 02:47:18 GMT, Joe Darcy wrote:
> Candidates for this refactoring were found programmatically; the program to
> find candidates is in a comment on the bug.
I went through the changes and they look fine.
-
Marked as reviewed by lancea (Reviewer).
PR Review: http
Can I please get a review of this change which proposes to remove the
(internal) `SelectVersion()` function from the java launcher and also update
the code comments in the launcher to match the current implementation?
As noted in https://bugs.openjdk.org/browse/JDK-8340114, the `SelectVersion()`
On Fri, 13 Sep 2024 07:50:49 GMT, Per Minborg wrote:
>> This PR suggests introducing an internal class in `java.base` to simplify
>> the use of some `MethodHandles.Lookup` operations.
>>
>> While the utility of the methods might appear to be limited in classes with
>> many static `VarHandle`/`
On Wed, 11 Sep 2024 13:15:57 GMT, Per Minborg wrote:
>> src/java.base/share/classes/jdk/internal/foreign/SegmentBulkOperations.java
>> line 244:
>>
>>> 242: return (Architecture.isLittleEndian()
>>> 243: ? Long.numberOfTrailingZeros(x)
>>> 244: : Long.num
This PR fixes a build error where we addressed out of bounds.
-
Commit messages:
- Remove redundant code
Changes: https://git.openjdk.org/jdk/pull/20998/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=20998&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8340120
Sta
On Fri, 13 Sep 2024 02:47:18 GMT, Joe Darcy wrote:
> Candidates for this refactoring were found programmatically; the program to
> find candidates is in a comment on the bug.
This patch only captures one-line returns without extra sentences. Is it
possible for us to handle slightly more comple
On Fri, 13 Sep 2024 13:02:05 GMT, Per Minborg wrote:
> This PR fixes a build error where we addressed out of bounds.
Can we please add a regression test to cover it?
-
PR Review: https://git.openjdk.org/jdk/pull/20998#pullrequestreview-2303088571
On Fri, 13 Sep 2024 13:07:03 GMT, Chen Liang wrote:
> This patch only captures one-line returns without extra sentences. Is it
> possible for us to handle slightly more complex documentations like
> `ParameterizedType::getActualTypeArguments`?
Sure, it is possible. However, there's a tradeoff
On Fri, 13 Sep 2024 02:47:18 GMT, Joe Darcy wrote:
> Candidates for this refactoring were found programmatically; the program to
> find candidates is in a comment on the bug.
Marked as reviewed by djelinski (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/20981#pullreques
On Fri, 13 Sep 2024 13:02:05 GMT, Per Minborg wrote:
> This PR fixes a build error where we addressed out of bounds.
This title has been changed as this code segment was never invoked. So, we
could not add a test that touches the code. Also, this will not fix any
out-of-bounds addressing but w
On Thu, 12 Sep 2024 16:14:34 GMT, Alexey Semenyuk wrote:
> Correct jpackage man errors
This pull request has now been integrated.
Changeset: 3c4d15bd
Author:Alexey Semenyuk
URL:
https://git.openjdk.org/jdk/commit/3c4d15bdceaf94698af99d6b6fb12b3a28e13fdf
Stats: 24 lines in 1 file
On Mon, 12 Aug 2024 17:23:15 GMT, Nizar Benalla wrote:
> The test is inspired from [FFM API's
> TestNulls](https://github.com/openjdk/jdk/blob/master/test/jdk/java/foreign/TestNulls.java),
> I customized their Null checking framework it to work with ClassFile API.
>
> The framework for for tes
On Tue, 27 Aug 2024 09:36:56 GMT, Per Minborg wrote:
> This PR proposes to add a new overload to `MemorySegment::getString` whereby
> it is possible to pass in a known byte length of the content in a segment
> that should be converted to a String. This is useful in case one already
> knows the
On 13/09/2024 10:49, Zheka Kozlov wrote:
Hello!
JEP 471 says that 79 methods out of 87 have been deprecated in
sun.misc.Unsafe. However, I have a different number.
Deprecated for removal in Java 18:
1. public long objectFieldOffset(Field f)
2. public Object staticFieldBase(Field f)
3. public
On Fri, 13 Sep 2024 12:40:33 GMT, Chen Liang wrote:
>> Per Minborg has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Rename and reformat
>
> src/java.base/share/classes/jdk/internal/reflect/MethodHandlesInternal.java
> line 50:
>
>> 48:
On Fri, 6 Sep 2024 18:08:04 GMT, Jatin Bhateja wrote:
>> test/jdk/jdk/incubator/vector/ShortMaxVectorTests.java line 1048:
>>
>>> 1046: return
>>> SHORT_GENERATOR_SELECT_FROM_TRIPLES.stream().map(List::toArray).
>>> 1047: toArray(Object[][]::new);
>>> 1048: }
>>
>>
On Tue, 3 Sep 2024 11:45:53 GMT, Emanuel Peter wrote:
>> Jatin Bhateja has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Adding descriptive comments
>
> src/jdk.incubator.vector/share/classes/jdk/incubator/vector/ByteVector.java
> line 54
On Fri, 6 Sep 2024 18:13:34 GMT, Jatin Bhateja wrote:
>> Hi All,
>>
>> As per the discussion on panama-dev mailing list[1], patch adds the support
>> for following new two vector permutation APIs.
>>
>>
>> Declaration:-
>> Vector.selectFrom(Vector v1, Vector v2)
>>
>>
>> Semantics:-
>>
Could I get a review for this small change?
The page linked in `SplittableRandom` was moved at some point, this change
points to the correct page to avoid redirects.
TIA
-
Commit messages:
- Broken link to the dieharder distribution website in SplittableRandom
Changes: https://git
On Fri, 13 Sep 2024 14:48:44 GMT, Nizar Benalla wrote:
> Could I get a review for this small change?
> The page linked in `SplittableRandom` was moved at some point, this change
> points to the correct page to avoid redirects.
>
> TIA
Confirmed. New link appears to be correct.
-
On Fri, 13 Sep 2024 13:02:05 GMT, Per Minborg wrote:
> This PR fixes a build error where we addressed out of bounds.
I am now convinced that this was just about dead code - please mark the JBS
issue as `noreg-hard`.
-
Marked as reviewed by mcimadamore (Reviewer).
PR Review: https
On Fri, 13 Sep 2024 13:59:54 GMT, Per Minborg wrote:
> This title has been changed as this code segment was never invoked. So, we
> could not add a test that touches the code. Also, this will not fix any
> out-of-bounds addressing but will only reduce the code surface.
To be clear for future r
On Fri, 13 Sep 2024 13:02:05 GMT, Per Minborg wrote:
> This PR removes redundant code.
This pull request has now been integrated.
Changeset: 1a0a5388
Author:Per Minborg
URL:
https://git.openjdk.org/jdk/commit/1a0a53883f7c6f523b5fefb722e137258d527362
Stats: 9 lines in 1 file chan
On Fri, 13 Sep 2024 14:48:44 GMT, Nizar Benalla wrote:
> Could I get a review for this small change?
> The page linked in `SplittableRandom` was moved at some point, this change
> points to the correct page to avoid redirects.
>
> TIA
I think this counts as "trivial" change and can be integrat
On Fri, 13 Sep 2024 14:48:44 GMT, Nizar Benalla wrote:
> Could I get a review for this small change?
> The page linked in `SplittableRandom` was moved at some point, this change
> points to the correct page to avoid redirects.
>
> TIA
@nizarbenalla
Your change (at version f7cead81b09d392d673b
Simple internal refactor to load a few classes less on startup. Arguably
cleaner.
-
Commit messages:
- Refactor makeHiddenClassDefiner to take ClassOption ...
Changes: https://git.openjdk.org/jdk/pull/21002/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21002&range=00
I
On Fri, 13 Sep 2024 15:40:46 GMT, Claes Redestad wrote:
> Simple internal refactor to load a few classes less on startup. Arguably
> cleaner.
src/java.base/share/classes/java/lang/invoke/MethodHandles.java line 2223:
> 2221: }
> :
> 2223: return makeHiddenClassDefi
On Thu, 12 Sep 2024 15:40:27 GMT, Brian Burkhalter wrote:
>> Moved to `NTLMAuthentication` static initializer. 853d349
>
> @dfuch Would you please check whether the change at line 71 in the updated
> version of `NTLMAuthentication` is the correct place for this load?
hmm... I don't see any iss
On Fri, 13 Sep 2024 16:05:37 GMT, Daniel Fuchs wrote:
>> @dfuch Would you please check whether the change at line 71 in the updated
>> version of `NTLMAuthentication` is the correct place for this load?
>
> hmm... I don't see any issue in adding the load call to `NTLMAuthentication`
> but I'm
On Fri, 13 Sep 2024 16:06:26 GMT, Daniel Fuchs wrote:
>> hmm... I don't see any issue in adding the load call to
>> `NTLMAuthentication` but I'm surprised that it's even needed: I'd expect
>> that libnet would have been loaded before we reach NTLMAuthentication.
>
> I wonder - do you see any f
On Fri, 13 Sep 2024 16:08:50 GMT, Brian Burkhalter wrote:
>> I wonder - do you see any failure if you don't load libnet from there?
>
> Yes, there was an `UnsatisfiedLinkError` in the native method
> `isTrustedSiteAvailable()` in `NTLMAuthentication`.
> [...] I'd expect that libnet would have b
On Fri, 13 Sep 2024 14:48:44 GMT, Nizar Benalla wrote:
> Could I get a review for this small change?
> The page linked in `SplittableRandom` was moved at some point, this change
> points to the correct page to avoid redirects.
>
> TIA
Marked as reviewed by liach (Reviewer).
Requesting @rgiuli
> Hi All,
>
> As per the discussion on panama-dev mailing list[1], patch adds the support
> following new vector operators.
>
>
> . SUADD : Saturating unsigned addition.
> . SADD: Saturating signed addition.
> . SUSUB : Saturating unsigned subtraction.
> . SSUB:
On Thu, 12 Sep 2024 23:11:31 GMT, Justin Lu wrote:
>> Please review this PR which restores the correct exception message when the
>> current working directory can not be found during java startup in
>> `initPhase1`.
>>
>> Both MacOS and Linux are expected to fail with `java.lang.Error: Propert
On Fri, 13 Sep 2024 16:12:28 GMT, Brian Burkhalter wrote:
>> Yes, there was an `UnsatisfiedLinkError` in the native method
>> `isTrustedSiteAvailable()` in `NTLMAuthentication`.
>
>> [...] I'd expect that libnet would have been loaded before we reach
>> NTLMAuthentication.
>
> In the (as of no
On Thu, 12 Sep 2024 23:11:31 GMT, Justin Lu wrote:
>> Please review this PR which restores the correct exception message when the
>> current working directory can not be found during java startup in
>> `initPhase1`.
>>
>> Both MacOS and Linux are expected to fail with `java.lang.Error: Propert
On Fri, 13 Sep 2024 14:48:44 GMT, Nizar Benalla wrote:
> Could I get a review for this small change?
> The page linked in `SplittableRandom` was moved at some point, this change
> points to the correct page to avoid redirects.
>
> TIA
Looks good
-
PR Comment: https://git.openjdk.
On Fri, 13 Sep 2024 02:47:18 GMT, Joe Darcy wrote:
> Candidates for this refactoring were found programmatically; the program to
> find candidates is in a comment on the bug.
`java.nio.charset` and `java.time.format` changes look good
-
Marked as reviewed by naoto (Reviewer).
PR
On Fri, 13 Sep 2024 13:13:58 GMT, Pavel Rappo wrote:
> > This patch only captures one-line returns without extra sentences. Is it
> > possible for us to handle slightly more complex documentations like
> > `ParameterizedType::getActualTypeArguments`?
>
> Sure, it is possible. However, there's
On Fri, 13 Sep 2024 16:31:36 GMT, Daniel Fuchs wrote:
>>> [...] I'd expect that libnet would have been loaded before we reach
>>> NTLMAuthentication.
>>
>> In the (as of now) penultimate webrev 4f47d5a (Merge),
>> `WindowsNativeDispatcher` loaded it during boot phase 2. I think that
>> withou
> Please review this PR which restores the correct exception message when the
> current working directory can not be found during java startup in
> `initPhase1`.
>
> Both MacOS and Linux are expected to fail with `java.lang.Error: Properties
> init: Could not determine current working directory
On Fri, 13 Sep 2024 16:33:54 GMT, Justin Lu wrote:
> AFAICT this would be correcting a faulty error message with a proper one, and
> so there is no behavioral change. What do you think?
Hello Justin, for this current PR, I think it's OK to just go ahead with the
current changes that you have f
On Fri, 6 Sep 2024 18:08:09 GMT, Jatin Bhateja wrote:
>> src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Vector.java line
>> 2770:
>>
>>> 2768:
>>> 2769: /**
>>> 2770: * Rearranges the lane elements of two vectors, selecting lanes
>>
>> I have a bit of a name concern here
On Fri, 13 Sep 2024 16:35:04 GMT, Brian Burkhalter wrote:
>> Do we know what code loaded NTLMAuthentication? I'd expect it to be loaded
>> by HttpURLConnection, which should have triggered the loading of libnet long
>> before it cares about NTLM.
>
> I would have to check. The failure I observe
On Fri, 13 Sep 2024 02:47:18 GMT, Joe Darcy wrote:
> Candidates for this refactoring were found programmatically; the program to
> find candidates is in a comment on the bug.
Looks good. It might be feasible to run a more complex tool that analyzes the
tokenized javadoc AST from javac as later
On Fri, 13 Sep 2024 02:47:18 GMT, Joe Darcy wrote:
> Candidates for this refactoring were found programmatically; the program to
> find candidates is in a comment on the bug.
This pull request has now been integrated.
Changeset: 89c172ac
Author:Joe Darcy
URL:
https://git.openjdk.or
On Fri, 13 Sep 2024 14:48:44 GMT, Nizar Benalla wrote:
> Could I get a review for this small change?
> The page linked in `SplittableRandom` was moved at some point, this change
> points to the correct page to avoid redirects.
>
> TIA
Thanks Raffaello for the confirmation.
-
PR C
On Fri, 13 Sep 2024 14:48:44 GMT, Nizar Benalla wrote:
> Could I get a review for this small change?
> The page linked in `SplittableRandom` was moved at some point, this change
> points to the correct page to avoid redirects.
>
> TIA
This pull request has now been integrated.
Changeset: 37bf
On Fri, 13 Sep 2024 16:45:22 GMT, Daniel Fuchs wrote:
>> I would have to check. The failure I observed occurred in both of these tests
>>
>> test/jdk/sun/net/www/protocol/http/NoNTLM.java
>> test/jdk/sun/net/www/protocol/http/TestTransparentNTLM.java
>>
>> and nowhere else.
>
> I see. The test
On Sat, 7 Sep 2024 08:51:25 GMT, Shaojin Wen wrote:
>> PR #20772 introduced an optimization for writeUTF, which can also be used in
>> DataOutputStream::writeUTF.
>
> Shaojin Wen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> reduce JDKUT
> This is a large method. By splitting it into multiple methods with the same
> name, the caller can automatically select based on the different types of
> parameters, avoiding this large call that cannot be inlined, which can also
> improve startup performance.
>
> * current
>
> CodeBuilder {
On Mon, 19 Aug 2024 21:47:23 GMT, Sandhya Viswanathan
wrote:
> Currently the rearrange and selectFrom APIs check shuffle indices and throw
> IndexOutOfBoundsException if there is any exceptional source index in the
> shuffle. This causes the generated code to be less optimal. This PR modifies
On Mon, 19 Aug 2024 21:47:23 GMT, Sandhya Viswanathan
wrote:
> Currently the rearrange and selectFrom APIs check shuffle indices and throw
> IndexOutOfBoundsException if there is any exceptional source index in the
> shuffle. This causes the generated code to be less optimal. This PR modifies
> PR #20772 introduced an optimization for writeUTF, which can also be used in
> DataOutputStream::writeUTF.
Shaojin Wen has updated the pull request incrementally with two additional
commits since the last revision:
- rename JDKUTF to ModifiedUtf
- suggestion from @liach
-
Chan
On Fri, 13 Sep 2024 17:05:11 GMT, Chen Liang wrote:
>> Shaojin Wen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> reduce JDKUTF#utflen codeSize
>
> src/java.base/share/classes/jdk/internal/util/JDKUTF.java line 37:
>
>> 35: public abst
On Fri, 13 Sep 2024 14:45:29 GMT, Emanuel Peter wrote:
>> Existing vectorAPI inline expansion entry points explicitly pass lane type
>> and count as intrinsic arguments, this is used to create concrete ideal
>> vector types.
>
> That does not answer my question. If the backend operations you im
On Fri, 13 Sep 2024 17:20:40 GMT, Quan Anh Mai wrote:
> Given `rearrange` with 1 vector gets wrapping indices semantics. I think we
> should stop normalizing indices when converting a `Vector` into a
> `VectorShuffle` (currently we wrap all out-of-bound elements to `[-VLEN,
> 0)`). Then the re
On Fri, 13 Sep 2024 05:30:36 GMT, Jatin Bhateja wrote:
>> Currently the rearrange and selectFrom APIs check shuffle indices and throw
>> IndexOutOfBoundsException if there is any exceptional source index in the
>> shuffle. This causes the generated code to be less optimal. This PR modifies
>>
On Fri, 13 Sep 2024 14:53:18 GMT, Emanuel Peter wrote:
> Can you please **define** somewhere what it means to `prune indexes`? It does
> not help me much more than the previous "massaging indexes" you had before I
> asked you to change it.
>
> > Also: I'm a little worried about the semantics c
On Fri, 13 Sep 2024 15:40:46 GMT, Claes Redestad wrote:
> Simple internal refactor to load a few classes less on startup. Arguably
> cleaner.
The private methods don’t need to be `ACC_VARARGS`, also remove excess
whitespace between `ClassOption` and `...` to match the code style of the rest
o
> Yet another preparation for upgrading the time zone data to 2024b, which
> introduced a new abbreviation format "%z". The update includes:
> ...
> The main source files' time zone abbreviations now use %z,
> supported by zic since release 2015f and used in vanguard form
> since
> Hi All,
>
> As per the discussion on panama-dev mailing list[1], patch adds the support
> for following new two vector permutation APIs.
>
>
> Declaration:-
> Vector.selectFrom(Vector v1, Vector v2)
>
>
> Semantics:-
> Using index values stored in the lanes of "this" vector, assembl
On Fri, 13 Sep 2024 08:56:39 GMT, Raffaello Giulietti
wrote:
>> `Math.scalb(double)` can be simplified, removing a loop and using
>> larger/smaller factors.
>
> Raffaello Giulietti has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Slight im
On Fri, 13 Sep 2024 18:44:36 GMT, Joe Darcy wrote:
>> Raffaello Giulietti has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Slight improvement.
>
> src/java.base/share/classes/java/lang/Math.java line 3325:
>
>> 3323: if (scaleFac
On Fri, 13 Sep 2024 18:56:35 GMT, Raffaello Giulietti
wrote:
> I considered using `powerOfTwoD` but it uses a `long` `+`, and performs an
> additional masking which seems useless or over-cautious and does not help if
> `n` is out of range (assuming the assert is not enabled).
>
> What about a
On Fri, 13 Sep 2024 18:24:04 GMT, Sandhya Viswanathan
wrote:
>> src/hotspot/share/opto/vectorIntrinsics.cpp line 2206:
>>
>>> 2204: const Type * byte_bt = Type::get_const_basic_type(T_BYTE);
>>> 2205: const TypeVect * byte_vt = TypeVect::make(byte_bt, num_elem);
>>> 2206: Node* byte_shuf
On Fri, 13 Sep 2024 19:04:12 GMT, Jatin Bhateja wrote:
>> @jatin-bhateja If you could expand on this comment with specific cases it
>> will be helpful. The loadShuffle generation is needed for platform specific
>> handling of shuffles and cannot be optimized out here.
>
> Hi @sviswa7, I was sug
On Thu, 12 Sep 2024 02:10:00 GMT, Brian Burkhalter wrote:
>> This proposed change would move the native objects required for NIO file
>> interaction from the libnio native library to the libjava native library on
>> Linux, macOS, and Windows.
>
> Brian Burkhalter has updated the pull request in
> `Math.scalb(double)` can be simplified, removing a loop and using
> larger/smaller factors.
Raffaello Giulietti has updated the pull request incrementally with one
additional commit since the last revision:
Introduce primPowerOfTwoD and make use of it.
-
Changes:
- all: http
On Fri, 13 Sep 2024 18:17:21 GMT, Sandhya Viswanathan
wrote:
>
> The guidance from Paul Sandoz and John Rose is to keep the the partial
> wrapping at shuffle construction as is for now and only change the rearrange
> and selectFrom apis.
Yes, we are trying to take smaller incremental steps.
On Fri, 13 Sep 2024 17:14:17 GMT, Shaojin Wen wrote:
>> This is a large method. By splitting it into multiple methods with the same
>> name, the caller can automatically select based on the different types of
>> parameters, avoiding this large call that cannot be inlined, which can also
>> imp
On Mon, 19 Aug 2024 21:47:23 GMT, Sandhya Viswanathan
wrote:
> Currently the rearrange and selectFrom APIs check shuffle indices and throw
> IndexOutOfBoundsException if there is any exceptional source index in the
> shuffle. This causes the generated code to be less optimal. This PR modifies
Please review the following PR which addresses that ZipOutputStream should
validate the CEN header fields similar to what was done via
[JDK-8316141](https://bugs.openjdk.org/browse/JDK-8316141)
As part of this change, the javadoc for ZipEntry has been updated to indicate
that the CEN Header(46
On Fri, 13 Sep 2024 17:40:21 GMT, Lance Andersen wrote:
> Please review the following PR which addresses that ZipOutputStream should
> validate the CEN header fields similar to what was done via
> [JDK-8316141](https://bugs.openjdk.org/browse/JDK-8316141)
>
> As part of this change, the javado
> This proposed change would move the native objects required for NIO file
> interaction from the libnio native library to the libjava native library on
> Linux, macOS, and Windows.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
On Fri, 13 Sep 2024 19:30:42 GMT, Magnus Ihse Bursie wrote:
>> Brian Burkhalter has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8337143: Clean up to address reviewer comments
>
> make/modules/java.base/lib/CoreLibraries.gmk line 68:
>
>
On Fri, 13 Sep 2024 16:20:28 GMT, Jatin Bhateja wrote:
>> Hi All,
>>
>> As per the discussion on panama-dev mailing list[1], patch adds the support
>> following new vector operators.
>>
>>
>> . SUADD : Saturating unsigned addition.
>> . SADD: Saturating signed addition.
>>
On Fri, 13 Sep 2024 16:20:28 GMT, Jatin Bhateja wrote:
>> Hi All,
>>
>> As per the discussion on panama-dev mailing list[1], patch adds the support
>> following new vector operators.
>>
>>
>> . SUADD : Saturating unsigned addition.
>> . SADD: Saturating signed addition.
>>
> Make explicit how the `java.io.File` methods `isDirectory`, `isFile`, and
> `isHidden` behave when the `File` represents a symbolic link.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8339574: Move symbolic link verbiage from
On Tue, 10 Sep 2024 18:05:13 GMT, Brian Burkhalter wrote:
>> src/java.base/share/classes/java/io/File.java line 1440:
>>
>>> 1438: * Renames the file denoted by this abstract pathname. If this
>>> pathname
>>> 1439: * denotes a symbolic link, then the link itself, not its target,
>>
1 - 100 of 113 matches
Mail list logo
