On Fri, 13 Sep 2024 06:53:19 GMT, Per Minborg <pminb...@openjdk.org> wrote:
>> I think we need the try block anyhow as we have to deal with a String. But >> might be slightly better. We could revisit this later. > > It would look like this: > > > static int powerOfPropertyOr(String name, int defaultPower) { > final String property = > GetPropertyAction.privilegedGetProperty(PROPERTY_PATH + name, > Integer.toString(defaultPower)); > try { > return 1 << Math.clamp(Integer.parseInt(property), 0, > Integer.SIZE - 2); > } catch (NumberFormatException _) { > // ignore > } > return defaultPower; > } > ``` https://bugs.openjdk.org/browse/JDK-8340089 ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20983#discussion_r1758284454