On Fri, 6 Jan 2023 06:35:31 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which fixes an issue in the javadoc
> text of the internal class IteratorSpliterator? This addresses the issue
> reported at https://bugs.openjdk.org/browse/JDK-8297306.
This looks okay although th
On Thu, 5 Jan 2023 13:24:08 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this doc only change which addresses the
>> javadoc issue noted in https://bugs.openjdk.org/browse/JDK-8258776?
>>
>> As noted in that issue, the `ThreadLocal.initialValue()` API javadoc
>> suggests subclassi
On Tue, 3 Jan 2023 09:39:59 GMT, Aleksey Shipilev wrote:
> This should help to speed up tests significantly. Currently, if we run "make
> test" with a subset of tests, JTReg would still read the entirety of test
> root to report on tests that were not run. Even with current suite of tests
> it
On Thu, 5 Jan 2023 17:33:05 GMT, Brian Burkhalter wrote:
>> I have added a new proposal in the hope that the `requireNonNegative` method
>> name and parameters should be trivial enough for users to directly
>> understand without scrolling down. Let me know your thought on this.
>
> That is defi
On Thu, 5 Jan 2023 12:34:12 GMT, Per Minborg wrote:
>> Code in java.io contains many legacy constructs and semantics not
>> recommended including:
>>
>> * C-style array declaration
>> * Unnecessary visibility
>> * Redundant keywords in interfaces (e.g. public, static)
>> * Non-standard nami
This patch adds `@Preview` to the CaptureCallState interface.
-
Commit messages:
- Add @Preview annotation to CaptureCallState
Changes: https://git.openjdk.org/jdk20/pull/86/files
Webrev: https://webrevs.openjdk.org/?repo=jdk20&pr=86&range=00
Issue: https://bugs.openjdk.org/brows
On Thu, 5 Jan 2023 12:18:58 GMT, Per Minborg wrote:
>> Currently, `java.io.Bits` is using explicit logic to read/write various
>> primitive types to/from byte arrays. Switching to the use of `VarHandle`
>> access would provide better performance and less code.
>>
>> Also, using a standard API
On Fri, 6 Jan 2023 14:10:52 GMT, Maurizio Cimadamore
wrote:
> This patch adds `@Preview` to the CaptureCallState interface.
Marked as reviewed by alanb (Reviewer).
-
PR: https://git.openjdk.org/jdk20/pull/86
On Fri, 6 Jan 2023 04:48:27 GMT, David Holmes wrote:
> The associated JBS issue has been dormant for 6+ years and this is a very
> intrusive change affecting many, many files. Has the resurrection of this
> project previously been discussed somewhere?
Hi @dholmes-ora,
The work to add this war
On Fri, 6 Jan 2023 14:10:52 GMT, Maurizio Cimadamore
wrote:
> This patch adds `@Preview` to the CaptureCallState interface.
This pull request has now been integrated.
Changeset: 5eee2a07
Author:Maurizio Cimadamore
URL:
https://git.openjdk.org/jdk20/commit/5eee2a07f5db5979149cc3e96d
On Fri, 6 Jan 2023 14:49:16 GMT, Archie L. Cobbs wrote:
> Sounds reasonable... so I take it you would also be in favor of patching
> `make/modules` instead of adding `@SuppressWarnings` annotations
> everywhere... is that correct?
>
> If this is generally agreed as a better route then let me k
On Fri, 6 Jan 2023 15:38:31 GMT, Alan Bateman wrote:
>>> The associated JBS issue has been dormant for 6+ years and this is a very
>>> intrusive change affecting many, many files. Has the resurrection of this
>>> project previously been discussed somewhere?
>>
>> Hi @dholmes-ora,
>>
>> The wo
On Fri, 6 Jan 2023 06:35:31 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which fixes an issue in the javadoc
> text of the internal class IteratorSpliterator? This addresses the issue
> reported at https://bugs.openjdk.org/browse/JDK-8297306.
Marked as reviewed by iris
On Fri, 23 Dec 2022 22:28:34 GMT, Markus KARG wrote:
> I/O had always been much slower than CPU and memory access, and thanks to
> physical constraints, always will be.
> While CPUs can get shrinked more and more, and can hold more and more memory
> cache on or nearby a CPU core, the distance b
On Fri, 6 Jan 2023 06:35:31 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which fixes an issue in the javadoc
> text of the internal class IteratorSpliterator? This addresses the issue
> reported at https://bugs.openjdk.org/browse/JDK-8297306.
Hi Jai, the fix looks good
Removed constructors of primitive wrapper classes (deprecated for removal) for
the following
- _java.text.ChoiceFormat_
- _java.text.MessageFormat_
Replaced with .valueOf() method
-
Commit messages:
- Fix ChoiceFormat
- Fix MessageFormat
Changes: https://git.openjdk.org/jdk/pull
On Fri, 6 Jan 2023 17:42:53 GMT, Justin Lu wrote:
> Removed constructors of primitive wrapper classes (deprecated for removal)
> for the following
> - _java.text.ChoiceFormat_
> - _java.text.MessageFormat_
>
> Replaced with .valueOf() method
LGTM
src/java.base/share/classes/java/text/Message
Due to the fact that JLine spawns native processes to obtain terminal
information on macOS/Linux, we decided to disable the JLine by default for
performance degradation reasons. It is still possible to enable it by
specifying it on the command line with `jdk.console` system property (not a
publ
> Removed constructors of primitive wrapper classes (deprecated for removal)
> for the following
> - _java.text.ChoiceFormat_
> - _java.text.MessageFormat_
>
> Replaced with .valueOf() method
Justin Lu has updated the pull request incrementally with one additional commit
since the last revisio
On Fri, 6 Jan 2023 18:36:08 GMT, Naoto Sato wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove objs=null
>
> src/java.base/share/classes/java/text/MessageFormat.java line 313:
>
>> 311: * String result = mf.form
Removed constructors of primitive wrapper classes (deprecated for removal) in
_java.util.Arrays_
Replaced with .valueOf() method
-
Commit messages:
- Fix java.util.Arrays
Changes: https://git.openjdk.org/jdk/pull/11885/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=11885
On Fri, 6 Jan 2023 18:51:12 GMT, Justin Lu wrote:
>> Removed constructors of primitive wrapper classes (deprecated for removal)
>> for the following
>> - _java.text.ChoiceFormat_
>> - _java.text.MessageFormat_
>>
>> Replaced with .valueOf() method
>
> Justin Lu has updated the pull request inc
On Fri, 6 Jan 2023 19:10:57 GMT, Lance Andersen wrote:
> Looks fine Justin, thanks for doing this.
>
> At some point we should convert the examples to be a snippet which we can do
> at a later time
Sounds good 👍
-
PR: https://git.openjdk.org/jdk/pull/11884
On Fri, 6 Jan 2023 18:54:07 GMT, Justin Lu wrote:
> Removed constructors of primitive wrapper classes (deprecated for removal) in
> _java.util.Arrays_
>
> Replaced with .valueOf() method
LGTM
-
Marked as reviewed by naoto (Reviewer).
PR: https://git.openjdk.org/jdk/pull/11885
On Fri, 6 Jan 2023 18:54:07 GMT, Justin Lu wrote:
> Removed constructors of primitive wrapper classes (deprecated for removal) in
> _java.util.Arrays_
>
> Replaced with .valueOf() method
Marked as reviewed by lancea (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/11885
On Thu, 22 Dec 2022 13:10:02 GMT, Claes Redestad wrote:
>> @cl4es Thanks for passing the constant node through, the code looks much
>> cleaner now. The attached patch should handle the signed bytes/shorts as
>> well. Please take a look.
>> [signed.patch](https://github.com/openjdk/jdk/files/10
Removed constructors of primitive wrapper classes (deprecated for removal) in
_javax.xml.stream.XMLOutputFactory_
Replaced with Boolean static fields: Boolean.TRUE and Boolean.FALSE
-
Commit messages:
- Copyright year
- Replace constructor with static field
Changes: https://git.
On Thu, 5 Jan 2023 21:59:30 GMT, Justin Lu wrote:
> Removed constructors of primitive wrapper classes (deprecated for removal) in
> _javax.xml.stream.XMLOutputFactory_
>
> Replaced with Boolean static fields: Boolean.TRUE and Boolean.FALSE
src/java.xml/share/classes/javax/xml/stream/XMLOutput
On Wed, 4 Jan 2023 15:50:35 GMT, Sergey Tsypanov wrote:
> Use the following methods instead of hand-written code:
> - Objects.checkFromIndexSize()
> - Objects.checkFromToIndex()
This pull request has now been integrated.
Changeset: d086e82b
Author:Sergey Tsypanov
Committer: Brian Burkhalte
On Fri, 6 Jan 2023 01:05:40 GMT, Jaikiran Pai wrote:
>> Trivial fix. Fix `Invokers.checkExactType` to call
>> `newWrongMethodTypeException(actual, expected)` with parameters in right
>> order.
>
> Hello Mandy, this looks good to me. The copyright year on the file will need
> an update.
>
> T
> Trivial fix. Fix `Invokers.checkExactType` to call
> `newWrongMethodTypeException(actual, expected)` with parameters in right
> order.
Mandy Chung has updated the pull request incrementally with two additional
commits since the last revision:
- Add a regression test
- further cleanup newW
On Fri, 6 Jan 2023 19:56:20 GMT, Justin Lu wrote:
>> Removed constructors of primitive wrapper classes (deprecated for removal)
>> in _javax.xml.stream.XMLOutputFactory_
>>
>> Replaced with Boolean static fields: Boolean.TRUE and Boolean.FALSE
>
> src/java.xml/share/classes/javax/xml/stream/XM
On Fri, 6 Jan 2023 21:20:45 GMT, Joe Wang wrote:
>> src/java.xml/share/classes/javax/xml/stream/XMLOutputFactory.java line 59:
>>
>>> 57: *
>>> 58: * The property can be set with the following code line:
>>> 59: * {@code setProperty("javax.xml.stream.isRepairingNamespaces",
>>> Boolean.TRUE|
On Fri, 6 Jan 2023 21:34:00 GMT, Lance Andersen wrote:
>> I think the later, that the value can be true or false. As an example, one
>> value is fine, e.g.
>> {@code setProperty("javax.xml.stream.isRepairingNamespaces",
>> Boolean.TRUE);}
>> or
>> {@code setProperty("javax.xml.stream.is
> Removed constructors of primitive wrapper classes (deprecated for removal) in
> _javax.xml.stream.XMLOutputFactory_
>
> Replaced with Boolean static fields: Boolean.TRUE and Boolean.FALSE
Justin Lu has updated the pull request incrementally with one additional commit
since the last revision:
When ID is null, TimeZone.getTimeZone(String ID) throws a NullPointerException.
For example,
String someID = null;
TimeZone tz1 = TimeZone.getTimeZone(someID);
```
throws a `NullPointerException`
This change updates the documentation to make this apparent.
-
Commit messages:
-
> This PR adds a new lint warning category `this-escape`.
>
> It also adds `@SuppressWarnings` annotations as needed to the JDK itself to
> allow the JDK to continue to compile with `-Xlint:all`.
>
> A 'this' escape warning is generated for a constructor `A()` in a class `A`
> when the compiler
On Fri, 6 Jan 2023 15:38:31 GMT, Alan Bateman wrote:
>>> The associated JBS issue has been dormant for 6+ years and this is a very
>>> intrusive change affecting many, many files. Has the resurrection of this
>>> project previously been discussed somewhere?
>>
>> Hi @dholmes-ora,
>>
>> The wo
On Fri, 6 Jan 2023 21:59:13 GMT, Justin Lu wrote:
>> Removed constructors of primitive wrapper classes (deprecated for removal)
>> in _javax.xml.stream.XMLOutputFactory_
>>
>> Replaced with Boolean static fields: Boolean.TRUE and Boolean.FALSE
>
> Justin Lu has updated the pull request increme
On Fri, 6 Jan 2023 21:59:13 GMT, Justin Lu wrote:
>> Removed constructors of primitive wrapper classes (deprecated for removal)
>> in _javax.xml.stream.XMLOutputFactory_
>>
>> Replaced with Boolean static fields: Boolean.TRUE and Boolean.FALSE
>
> Justin Lu has updated the pull request increme
Forwardport JDK 20 -> JDK 21
-
Commit messages:
- Merge remote-tracking branch 'jdk20/master' into Merge_jdk20
- 8299705: JCov coverage runs depend on jdk_symbols
- 8299740: CaptureCallState is missing @Preview annotation
- 8299528: IR test: TestEor3AArch64.java fails on aarch64
Within _test/jdk/java/util/Calendar/CalendarTestScripts/Symbol.java_
GregorianCalendar alone handles all the necessary imports, Calendar is not
needed
-
Commit messages:
- Update copyright
- Remove redundant import
Changes: https://git.openjdk.org/jdk/pull/11855/files
Webrev: ht
On Sat, 7 Jan 2023 01:08:48 GMT, Jesper Wilhelmsson
wrote:
> Forwardport JDK 20 -> JDK 21
This pull request has now been integrated.
Changeset: 5393dc9a
Author:Jesper Wilhelmsson
URL:
https://git.openjdk.org/jdk/commit/5393dc9a48064505f0b79b7059f87bec33c1c8fe
Stats: 54 lines in
On Wed, 4 Jan 2023 21:48:26 GMT, Justin Lu wrote:
> Added the missing copyright header
This pull request has now been integrated.
Changeset: d5b80abc
Author:Justin Lu
Committer: Jaikiran Pai
URL:
https://git.openjdk.org/jdk/commit/d5b80abcbfff57c7728d3e42a696a762f08bc7ad
Stats:
On Thu, 5 Jan 2023 13:24:08 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this doc only change which addresses the
>> javadoc issue noted in https://bugs.openjdk.org/browse/JDK-8258776?
>>
>> As noted in that issue, the `ThreadLocal.initialValue()` API javadoc
>> suggests subclassi
On Wed, 4 Jan 2023 14:37:13 GMT, Jaikiran Pai wrote:
> Can I please get a review of this doc only change which addresses the javadoc
> issue noted in https://bugs.openjdk.org/browse/JDK-8258776?
>
> As noted in that issue, the `ThreadLocal.initialValue()` API javadoc suggests
> subclassing `T
46 matches
Mail list logo
