On Fri, 6 Jan 2023 14:49:16 GMT, Archie L. Cobbs <d...@openjdk.org> wrote:
> Sounds reasonable... so I take it you would also be in favor of patching > `make/modules` instead of adding `@SuppressWarnings` annotations > everywhere... is that correct? > > If this is generally agreed as a better route then let me know and I'll > update the patch. Yes, I think that would be better. It would remove most of the noise, 1200+ files, and 10+ mailing lists from this PR. I assume there will be at least some iteration on compiler-dev about the details and changes to javac. Once you get to the JDK changes then I suspect that some areas may want to fix issues rather than adding SW. Sadly, I see a few examples in your list where there have been attempts to avoid leaking "this" but where we backed away out of concern that 3rd party code was extending some class and overriding a method known to be invoked by the constructor. Also we have places that register themselves to cleaners. I suspect some of the suggestions to document leaking this in implNotes will need discussion too because they amount to documenting "hooks" that people will rely on, e.g. documenting in ArrayDeque that its constructor invokes addList could be read as an invite to override it. ------------- PR: https://git.openjdk.org/jdk/pull/11874
