RFR: Merge jdk20

2022-12-20 Thread Jesper Wilhelmsson
Forwardport JDK 20 -> JDK 21 - Commit messages: - Merge remote-tracking branch 'jdk20/master' into Merge_jdk20 - 8298784: JFR: Test chunk integrity - 8298215: gc/g1/TestVerifyGCType.java failed with "Missing expected verification pattern Verifying After GC for: Pause Young (Prepar

Re: RFR: Merge jdk20 [v2]

2022-12-20 Thread Jesper Wilhelmsson
> Forwardport JDK 20 -> JDK 21 Jesper Wilhelmsson has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 107 commits: - Merge remote-tracking branch 'jdk20/master' into Merge_jdk20 - 8298865: Excessive memory allocation in CipherOutputStre

Integrated: Merge jdk20

2022-12-20 Thread Jesper Wilhelmsson
On Tue, 20 Dec 2022 10:57:44 GMT, Jesper Wilhelmsson wrote: > Forwardport JDK 20 -> JDK 21 This pull request has now been integrated. Changeset: c5a4a7a6 Author:Jesper Wilhelmsson URL: https://git.openjdk.org/jdk/commit/c5a4a7a679ec76cb08a999a198e5c73e9cd9d2f0 Stats: 2286 lines

Re: RFR: 8298971: Move Console implementation into jdk internal package

2022-12-20 Thread Jaikiran Pai
On Mon, 19 Dec 2022 19:23:25 GMT, Naoto Sato wrote: > Moving the built-in implementation of `Console` from `java.io` package into > `jdk.internal.io` package. It now implements `JdkConsole` interface and is > accessed through `ProxyingConsole`. src/java.base/share/classes/jdk/internal/io/JdkCo

Re: RFR: 8298971: Move Console implementation into jdk internal package

2022-12-20 Thread Jaikiran Pai
On Mon, 19 Dec 2022 19:23:25 GMT, Naoto Sato wrote: > Moving the built-in implementation of `Console` from `java.io` package into > `jdk.internal.io` package. It now implements `JdkConsole` interface and is > accessed through `ProxyingConsole`. src/java.base/share/classes/jdk/internal/io/JdkCo

Re: RFR: 8298971: Move Console implementation into jdk internal package

2022-12-20 Thread Jaikiran Pai
On Mon, 19 Dec 2022 19:23:25 GMT, Naoto Sato wrote: > Moving the built-in implementation of `Console` from `java.io` package into > `jdk.internal.io` package. It now implements `JdkConsole` interface and is > accessed through `ProxyingConsole`. src/java.base/share/classes/jdk/internal/io/JdkCo

Re: RFR: 8298971: Move Console implementation into jdk internal package

2022-12-20 Thread Jaikiran Pai
On Tue, 20 Dec 2022 14:17:32 GMT, Jaikiran Pai wrote: >> Moving the built-in implementation of `Console` from `java.io` package into >> `jdk.internal.io` package. It now implements `JdkConsole` interface and is >> accessed through `ProxyingConsole`. > > src/java.base/share/classes/jdk/internal/

Re: RFR: 8298971: Move Console implementation into jdk internal package

2022-12-20 Thread Jaikiran Pai
On Tue, 20 Dec 2022 14:37:10 GMT, Jaikiran Pai wrote: >> src/java.base/share/classes/jdk/internal/io/JdkConsoleImpl.java line 179: >> >>> 177: private Writer out; >>> 178: private PrintWriter pw; >>> 179: private Formatter formatter; >> >> Hello Naoto, I think some of these can be m

Re: RFR: 8298875: A module requiring "java.base" with flags ACC_SYNTHETIC should be rejected

2022-12-20 Thread Jaikiran Pai
On Fri, 16 Dec 2022 19:30:24 GMT, Alan Bateman wrote: > A small oversight with ModuleDescriptor.read when checking the requires table > of a Module attribute. The requires entry for java.base should not have > ACC_SYNTHETIC set. > > A new test is added. Some of the existing tests used > `@Tes

Re: RFR: 8298875: A module requiring "java.base" with flags ACC_SYNTHETIC should be rejected

2022-12-20 Thread Jaikiran Pai
On Fri, 16 Dec 2022 19:30:24 GMT, Alan Bateman wrote: > A small oversight with ModuleDescriptor.read when checking the requires table > of a Module attribute. The requires entry for java.base should not have > ACC_SYNTHETIC set. > > A new test is added. Some of the existing tests used > `@Tes

Re: RFR: JDK-8295087: Manual Test to Automated Test Conversion [v5]

2022-12-20 Thread Bill Huang
On Fri, 16 Dec 2022 11:48:54 GMT, Sibabrata Sahoo wrote: >> Bill Huang has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains five additional >> commit

Re: RFR: JDK-8295087: Manual Test to Automated Test Conversion [v5]

2022-12-20 Thread Bill Huang
On Fri, 16 Dec 2022 12:06:14 GMT, Sibabrata Sahoo wrote: >> Bill Huang has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains five additional >> commit

Re: RFR: JDK-8295087: Manual Test to Automated Test Conversion [v6]

2022-12-20 Thread Bill Huang
> This task converts 5 manual tests to automated tests. > > sun/security/provider/PolicyParser/ExtDirsDefaultPolicy.java > sun/security/provider/PolicyParser/ExtDirsChange.java > sun/security/provider/PolicyParser/ExtDirs.java > java/security/Policy/Root/Root.javajava/security/Policy/Root/Root.

Re: RFR: 8282664: Unroll by hand StringUTF16 and StringLatin1 polynomial hash loops [v13]

2022-12-20 Thread Claes Redestad
On Fri, 16 Dec 2022 22:58:23 GMT, Sandhya Viswanathan wrote: >> Claes Redestad has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Missing & 0xff in StringLatin1::hashCode > > src/hotspot/cpu/x86/vm_version_x86.cpp line 1671: > >> 1669:

Re: RFR: 8282664: Unroll by hand StringUTF16 and StringLatin1 polynomial hash loops [v13]

2022-12-20 Thread Claes Redestad
On Fri, 16 Dec 2022 23:00:53 GMT, Sandhya Viswanathan wrote: >> Claes Redestad has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Missing & 0xff in StringLatin1::hashCode > > src/hotspot/cpu/x86/stubRoutines_x86.cpp line 230: > >> 228: #e

Re: RFR: 8282664: Unroll by hand StringUTF16 and StringLatin1 polynomial hash loops [v14]

2022-12-20 Thread Claes Redestad
> Continuing the work initiated by @luhenry to unroll and then intrinsify > polynomial hash loops. > > I've rewired the library changes to route via a single `@IntrinsicCandidate` > method. To make this work I've harmonized how they are invoked so that > there's less special handling and checks

Re: RFR: 8282664: Unroll by hand StringUTF16 and StringLatin1 polynomial hash loops [v13]

2022-12-20 Thread Claes Redestad
On Mon, 14 Nov 2022 18:28:53 GMT, Vladimir Ivanov wrote: >>> Also, I'd like to note that C2 auto-vectorization support is not too far >>> away from being able to optimize hash code computations. At some point, I >>> was able to achieve some promising results with modest tweaking of >>> SuperWo

Re: RFR: 8298971: Move Console implementation into jdk internal package [v2]

2022-12-20 Thread Naoto Sato
> Moving the built-in implementation of `Console` from `java.io` package into > `jdk.internal.io` package. It now implements `JdkConsole` interface and is > accessed through `ProxyingConsole`. Naoto Sato has updated the pull request incrementally with one additional commit since the last revisi

Re: RFR: 8298971: Move Console implementation into jdk internal package [v2]

2022-12-20 Thread Naoto Sato
On Tue, 20 Dec 2022 14:44:38 GMT, Jaikiran Pai wrote: >> Actually, I see that it isn't possible for these to be final because we set >> these up in the `console(...)` instance method of this class. That's because >> this `JdkConsoleImpl` implements both the `JdkConsole` interface and the >> `J

Re: RFR: 8298971: Move Console implementation into jdk internal package [v2]

2022-12-20 Thread Naoto Sato
On Tue, 20 Dec 2022 14:24:28 GMT, Jaikiran Pai wrote: >> Naoto Sato has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Removed JdkConsoleProviderImpl, caching INSTANCE > > src/java.base/share/classes/jdk/internal/io/JdkConsoleImpl.java line

Re: RFR: 8298875: A module requiring "java.base" with flags ACC_SYNTHETIC should be rejected

2022-12-20 Thread Mandy Chung
On Fri, 16 Dec 2022 19:30:24 GMT, Alan Bateman wrote: > A small oversight with ModuleDescriptor.read when checking the requires table > of a Module attribute. The requires entry for java.base should not have > ACC_SYNTHETIC set. > > A new test is added. Some of the existing tests used > `@Tes

RFR: JDK-8299052: ViewportOverlapping test fails on Win10 & Win11

2022-12-20 Thread Harshitha Onkar
ViewportOverlapping was failing intermittently on Windows (Win10 & 11). Added robot.setAutoWaitForIdle() to ViewportOverlapping and its base class (OverlappingTestBase) to stabilize the test. Additionally added awt & swings tests to exclusiveAccess.dir in TEST.ROOT. - Commit messag

Re: RFR: 8282664: Unroll by hand StringUTF16 and StringLatin1 polynomial hash loops [v13]

2022-12-20 Thread Sandhya Viswanathan
On Tue, 20 Dec 2022 21:11:18 GMT, Claes Redestad wrote: >>> How far off is this ...? >> >> Back then it looked way too constrained (tight constraints on code shapes). >> But I considered it as a generally applicable optimization. >> >>> ... do you think it'll be able to match the efficiency

Re: RFR: 8298971: Move Console implementation into jdk internal package [v2]

2022-12-20 Thread Jaikiran Pai
On Tue, 20 Dec 2022 22:06:26 GMT, Naoto Sato wrote: >> Moving the built-in implementation of `Console` from `java.io` package into >> `jdk.internal.io` package. It now implements `JdkConsole` interface and is >> accessed through `ProxyingConsole`. > > Naoto Sato has updated the pull request inc

Re: RFR: JDK-8299052: ViewportOverlapping test fails intermittently on Win10 & Win11

2022-12-20 Thread Jaikiran Pai
On Tue, 20 Dec 2022 23:25:30 GMT, Harshitha Onkar wrote: > ViewportOverlapping was failing intermittently on Windows (Win10 & 11). Added > robot.setAutoWaitForIdle() to ViewportOverlapping and its base class > (OverlappingTestBase) to stabilize the test. > > Additionally added awt & swings tes

Re: RFR: 8282664: Unroll by hand StringUTF16 and StringLatin1 polynomial hash loops [v14]

2022-12-20 Thread Sandhya Viswanathan
On Tue, 20 Dec 2022 21:11:40 GMT, Claes Redestad wrote: >> Continuing the work initiated by @luhenry to unroll and then intrinsify >> polynomial hash loops. >> >> I've rewired the library changes to route via a single `@IntrinsicCandidate` >> method. To make this work I've harmonized how they

Re: RFR: 8282664: Unroll by hand StringUTF16 and StringLatin1 polynomial hash loops [v13]

2022-12-20 Thread Sandhya Viswanathan
On Tue, 20 Dec 2022 19:52:34 GMT, Claes Redestad wrote: >> src/java.base/share/classes/java/lang/StringUTF16.java line 418: >> >>> 416: return 0; >>> 417: } else { >>> 418: return ArraysSupport.vectorizedHashCode(value, >>> ArraysSupport.UTF16); >> >> Special ca

Re: RFR: 8298971: Move Console implementation into jdk internal package [v3]

2022-12-20 Thread Naoto Sato
> Moving the built-in implementation of `Console` from `java.io` package into > `jdk.internal.io` package. It now implements `JdkConsole` interface and is > accessed through `ProxyingConsole`. Naoto Sato has updated the pull request incrementally with one additional commit since the last revisi

Re: RFR: 8298971: Move Console implementation into jdk internal package [v2]

2022-12-20 Thread Naoto Sato
On Wed, 21 Dec 2022 00:33:09 GMT, Jaikiran Pai wrote: >> Naoto Sato has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Removed JdkConsoleProviderImpl, caching INSTANCE > > src/java.base/share/classes/jdk/internal/io/JdkConsoleImpl.java line

Re: RFR: 8298971: Move Console implementation into jdk internal package [v3]

2022-12-20 Thread Jaikiran Pai
On Wed, 21 Dec 2022 02:30:21 GMT, Naoto Sato wrote: >> Moving the built-in implementation of `Console` from `java.io` package into >> `jdk.internal.io` package. It now implements `JdkConsole` interface and is >> accessed through `ProxyingConsole`. > > Naoto Sato has updated the pull request inc

Re: RFR: JDK-8295087: Manual Test to Automated Test Conversion [v6]

2022-12-20 Thread Sibabrata Sahoo
On Tue, 20 Dec 2022 19:23:10 GMT, Bill Huang wrote: >> This task converts 5 manual tests to automated tests. >> >> sun/security/provider/PolicyParser/ExtDirsDefaultPolicy.java >> sun/security/provider/PolicyParser/ExtDirsChange.java >> sun/security/provider/PolicyParser/ExtDirs.java >> java/s

Re: RFR: JDK-8295087: Manual Test to Automated Test Conversion [v5]

2022-12-20 Thread Sibabrata Sahoo
On Tue, 20 Dec 2022 19:05:13 GMT, Bill Huang wrote: >> test/jdk/javax/crypto/CryptoPermissions/InconsistentEntries.java line 52: >> >>> 50: private static final String JDK_HOME = >>> System.getProperty("test.jdk"); >>> 51: private static final String TEST_SRC = >>> System.getProperty("