On Fri, 16 Dec 2022 19:30:24 GMT, Alan Bateman <al...@openjdk.org> wrote:

> A small oversight with ModuleDescriptor.read when checking the requires table 
> of a Module attribute. The requires entry for java.base should not have 
> ACC_SYNTHETIC set.
> 
> A new test is added. Some of the existing tests used 
> `@Test(expectedExceptions=...)`. I've changed some of these to use 
> assertThrows to narrow it down to method that is expected to throw.

This change looks good.

-------------

Marked as reviewed by mchung (Reviewer).

PR: https://git.openjdk.org/jdk/pull/11714

Reply via email to