Re: RFR: 8349689: Several virtual thread tests missing /native keyword [v3]

2025-02-11 Thread SendaoYan
On Tue, 11 Feb 2025 09:00:46 GMT, SendaoYan wrote: >> Can you remove this change from the PR as it this is a separate discussion? >> My guess is that in your environment the Thread.yield is somehow taking more >> than 5 seconds, is that right? In that case, we can modify the test to use a >> l

Re: RFR: 8349689: Several virtual thread tests missing /native keyword [v3]

2025-02-11 Thread SendaoYan
On Tue, 11 Feb 2025 08:53:41 GMT, Alan Bateman wrote: >> Reason description as >> https://github.com/openjdk/jdk/pull/23550#issuecomment-2650141187. > > Can you remove this change from the PR as it this is a separate discussion? > My guess is that in your environment the Thread.yield is somehow

Re: RFR: 8349689: Several virtual thread tests missing /native keyword [v3]

2025-02-11 Thread Alan Bateman
On Tue, 11 Feb 2025 08:44:15 GMT, SendaoYan wrote: >> test/jdk/java/lang/Thread/virtual/ThreadPollOnYield.java line 69: >> >>> 67: if (flag != true) { >>> 68: throw new RuntimeException("flag = " + flag); >>> 69: } >> >> What are these other changes about? > > Reason

Re: RFR: 8349689: Several virtual thread tests missing /native keyword [v3]

2025-02-11 Thread SendaoYan
On Tue, 11 Feb 2025 08:44:15 GMT, Alan Bateman wrote: >> SendaoYan has updated the pull request incrementally with one additional >> commit since the last revision: >> >> add /native for test/jdk/java/lang/Thread/virtual/ThreadPollOnYield.java >> test/jdk/java/lang/Thread/virtual/Starvation.

Re: RFR: 8349689: Several virtual thread tests missing /native keyword [v3]

2025-02-11 Thread SendaoYan
On Tue, 11 Feb 2025 08:41:44 GMT, Alan Bateman wrote: >> SendaoYan has updated the pull request incrementally with one additional >> commit since the last revision: >> >> add /native for test/jdk/java/lang/Thread/virtual/ThreadPollOnYield.java >> test/jdk/java/lang/Thread/virtual/Starvation.

Re: RFR: 8349689: Several virtual thread tests missing /native keyword [v3]

2025-02-11 Thread Alan Bateman
On Tue, 11 Feb 2025 08:38:48 GMT, SendaoYan wrote: >> H all, >> >> This PR add `/native` keyword in the test header for virtual thread tests. >> The `/native` keyword will make run the related tests by jtreg standalone >> more friendly. >> >> I runed all the tests without -nativepath argument

Re: RFR: 8349689: Several virtual thread tests missing /native keyword [v3]

2025-02-11 Thread SendaoYan
> H all, > > This PR add `/native` keyword in the test header for virtual thread tests. > The `/native` keyword will make run the related tests by jtreg standalone > more friendly. > > I runed all the tests without -nativepath argument and find the fail tests. > This will find all the virtual