On Tue, 11 Feb 2025 08:41:44 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> SendaoYan has updated the pull request incrementally with one additional >> commit since the last revision: >> >> add /native for test/jdk/java/lang/Thread/virtual/ThreadPollOnYield.java >> test/jdk/java/lang/Thread/virtual/Starvation.java > > test/jdk/java/lang/Thread/virtual/Starvation.java line 28: > >> 26: * @library /test/lib >> 27: * @bug 8345294 >> 28: * @run main/othervm/timeout=200/native >> --enable-native-access=ALL-UNNAMED Starvation 100000 > > Did you mean to add /timeout=200 to this test? Test test/jdk/java/lang/Thread/virtual/Starvation.java execute over 120 seconds on my local environment. So I add timeout=200 also. > test/jdk/java/lang/Thread/virtual/ThreadPollOnYield.java line 69: > >> 67: if (flag != true) { >> 68: throw new RuntimeException("flag = " + flag); >> 69: } > > What are these other changes about? Reason description as https://github.com/openjdk/jdk/pull/23550#issuecomment-2650141187. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/23550#discussion_r1950440123 PR Review Comment: https://git.openjdk.org/jdk/pull/23550#discussion_r1950439898