On Tue, 11 Feb 2025 08:44:15 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> SendaoYan has updated the pull request incrementally with one additional >> commit since the last revision: >> >> add /native for test/jdk/java/lang/Thread/virtual/ThreadPollOnYield.java >> test/jdk/java/lang/Thread/virtual/Starvation.java > > test/jdk/java/lang/Thread/virtual/ThreadPollOnYield.java line 39: > >> 37: * @requires vm.continuations & vm.compMode != "Xcomp" >> 38: * @library /test/lib >> 39: * @run junit/othervm/native --enable-native-access=ALL-UNNAMED -Xcomp >> -XX:-TieredCompilation -XX:CompileCommand=inline,*::yield* >> -XX:CompileCommand=inline,*::*Yield ThreadPollOnYield > > Would you mind splitting this line (jtreg is okay with that) as it's nearly > 190 chars now so getting too long. Okey, this line has been split two lines. > test/jdk/java/lang/management/ThreadMXBean/VirtualThreads.java line 30: > >> 28: * @modules java.base/java.lang:+open java.management >> 29: * @library /test/lib >> 30: * @run junit/othervm/native --enable-native-access=ALL-UNNAMED >> VirtualThreads > > Can you check if the end copyright date needs to be updated on this one. Sorry, the copyright date has been updated. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/23550#discussion_r1950447560 PR Review Comment: https://git.openjdk.org/jdk/pull/23550#discussion_r1950448055
