Re: RFR: 8347825: Make IDEA ide support use proper build system mechanisms [v2]

2025-01-24 Thread Magnus Ihse Bursie
On Wed, 15 Jan 2025 16:13:04 GMT, Magnus Ihse Bursie wrote: >> The idea.sh script which creates a configuration for IDEA does at some point >> call a makefile, to extract information from the build system. However, this >> is done in an ad-hoc manner that does not fit properly in the build syst

Re: RFR: 8347825: Make IDEA ide support use proper build system mechanisms [v2]

2025-01-24 Thread Magnus Ihse Bursie
On Fri, 24 Jan 2025 15:45:19 GMT, Maurizio Cimadamore wrote: > The additional warnings seem to be creating some confusion among new adopters > of the script Ok, that's bad. I'll fix it. - PR Comment: https://git.openjdk.org/jdk/pull/23140#issuecomment-2612943000

Re: RFR: 8347825: Make IDEA ide support use proper build system mechanisms [v2]

2025-01-24 Thread Maurizio Cimadamore
On Wed, 15 Jan 2025 16:13:04 GMT, Magnus Ihse Bursie wrote: >> The idea.sh script which creates a configuration for IDEA does at some point >> call a makefile, to extract information from the build system. However, this >> is done in an ad-hoc manner that does not fit properly in the build syst

Re: RFR: 8347825: Make IDEA ide support use proper build system mechanisms [v2]

2025-01-16 Thread Magnus Ihse Bursie
On Wed, 15 Jan 2025 16:13:04 GMT, Magnus Ihse Bursie wrote: >> The idea.sh script which creates a configuration for IDEA does at some point >> call a makefile, to extract information from the build system. However, this >> is done in an ad-hoc manner that does not fit properly in the build syst

Re: RFR: 8347825: Make IDEA ide support use proper build system mechanisms [v2]

2025-01-16 Thread Erik Joelsson
On Wed, 15 Jan 2025 16:13:04 GMT, Magnus Ihse Bursie wrote: >> The idea.sh script which creates a configuration for IDEA does at some point >> call a makefile, to extract information from the build system. However, this >> is done in an ad-hoc manner that does not fit properly in the build syst

Re: RFR: 8347825: Make IDEA ide support use proper build system mechanisms [v2]

2025-01-16 Thread Maurizio Cimadamore
On Wed, 15 Jan 2025 16:13:04 GMT, Magnus Ihse Bursie wrote: >> The idea.sh script which creates a configuration for IDEA does at some point >> call a makefile, to extract information from the build system. However, this >> is done in an ad-hoc manner that does not fit properly in the build syst

Re: RFR: 8347825: Make IDEA ide support use proper build system mechanisms [v2]

2025-01-15 Thread Julian Waters
On Wed, 15 Jan 2025 16:13:04 GMT, Magnus Ihse Bursie wrote: >> The idea.sh script which creates a configuration for IDEA does at some point >> call a makefile, to extract information from the build system. However, this >> is done in an ad-hoc manner that does not fit properly in the build syst

Re: RFR: 8347825: Make IDEA ide support use proper build system mechanisms [v2]

2025-01-15 Thread Jorn Vernee
On Wed, 15 Jan 2025 16:13:04 GMT, Magnus Ihse Bursie wrote: >> The idea.sh script which creates a configuration for IDEA does at some point >> call a makefile, to extract information from the build system. However, this >> is done in an ad-hoc manner that does not fit properly in the build syst

Re: RFR: 8347825: Make IDEA ide support use proper build system mechanisms [v2]

2025-01-15 Thread Magnus Ihse Bursie
On Wed, 15 Jan 2025 16:13:04 GMT, Magnus Ihse Bursie wrote: >> The idea.sh script which creates a configuration for IDEA does at some point >> call a makefile, to extract information from the build system. However, this >> is done in an ad-hoc manner that does not fit properly in the build syst

Re: RFR: 8347825: Make IDEA ide support use proper build system mechanisms [v2]

2025-01-15 Thread Jorn Vernee
On Wed, 15 Jan 2025 16:13:04 GMT, Magnus Ihse Bursie wrote: >> The idea.sh script which creates a configuration for IDEA does at some point >> call a makefile, to extract information from the build system. However, this >> is done in an ad-hoc manner that does not fit properly in the build syst

Re: RFR: 8347825: Make IDEA ide support use proper build system mechanisms

2025-01-15 Thread Julian Waters
On Wed, 15 Jan 2025 16:26:26 GMT, Maurizio Cimadamore wrote: > We should probably also ask somebody with Windows Hey, don't forget about me! How do I test this, just set up an IDEA Workspace as instructed in the docs? - PR Comment: https://git.openjdk.org/jdk/pull/23140#issuecomm

Re: RFR: 8347825: Make IDEA ide support use proper build system mechanisms

2025-01-15 Thread Maurizio Cimadamore
On Wed, 15 Jan 2025 16:40:10 GMT, Julian Waters wrote: > > We should probably also ask somebody with Windows > > Hey, don't forget about me! How do I test this, just set up an IDEA Workspace > as instructed in the docs? Yes, that would be the case. E.g. run `sh bin/idea.sh java.base` or someth

Re: RFR: 8347825: Make IDEA ide support use proper build system mechanisms

2025-01-15 Thread Maurizio Cimadamore
On Wed, 15 Jan 2025 15:34:30 GMT, Magnus Ihse Bursie wrote: > @mcimadamore Can you please verify that the IDEA generation still works > properly? I've tried it locally and it seems fine to me, but I'd like you to > verify it as well. I will take a look. Thanks for the headsup. We should probab

Re: RFR: 8347825: Make IDEA ide support use proper build system mechanisms

2025-01-15 Thread Magnus Ihse Bursie
On Wed, 15 Jan 2025 15:33:14 GMT, Magnus Ihse Bursie wrote: > The idea.sh script which creates a configuration for IDEA does at some point > call a makefile, to extract information from the build system. However, this > is done in an ad-hoc manner that does not fit properly in the build system.

Re: RFR: 8347825: Make IDEA ide support use proper build system mechanisms [v2]

2025-01-15 Thread Magnus Ihse Bursie
> The idea.sh script which creates a configuration for IDEA does at some point > call a makefile, to extract information from the build system. However, this > is done in an ad-hoc manner that does not fit properly in the build system. > > I ran into this as a problem when trying to implement an

Re: RFR: 8347825: Make IDEA ide support use proper build system mechanisms

2025-01-15 Thread Magnus Ihse Bursie
On Wed, 15 Jan 2025 15:33:14 GMT, Magnus Ihse Bursie wrote: > The idea.sh script which creates a configuration for IDEA does at some point > call a makefile, to extract information from the build system. However, this > is done in an ad-hoc manner that does not fit properly in the build system.