On Wed, 15 Jan 2025 16:13:04 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
>> The idea.sh script which creates a configuration for IDEA does at some point >> call a makefile, to extract information from the build system. However, this >> is done in an ad-hoc manner that does not fit properly in the build system. >> >> I ran into this as a problem when trying to implement another change, so >> this needs to be fixed, and should be fixed separately. > > Magnus Ihse Bursie has updated the pull request incrementally with one > additional commit since the last revision: > > Fix broken make:idea test I do see a couple of warnings being printed when I run the script: $ bash bin/idea.sh Note: Command line contains non-control variables: * MODULES= * IDEA_OUTPUT=/mnt/h/openjdk/git-jdk2/.idea Make sure it is not mistyped, and that you intend to override this variable. 'make help' will list known control variables. Note: Command line contains non-control variables: * MODULES= * IDEA_OUTPUT=/mnt/h/openjdk/git-jdk2/.idea Make sure it is not mistyped, and that you intend to override this variable. 'make help' will list known control variables. Building target 'idea-gen-config' in configuration 'windows-release' Finished building target 'idea-gen-config' in configuration 'windows-release' Other than that, the generated project files seem to work fine. ------------- PR Comment: https://git.openjdk.org/jdk/pull/23140#issuecomment-2593812470
