On Wed, 15 Jan 2025 16:13:04 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
>> The idea.sh script which creates a configuration for IDEA does at some point >> call a makefile, to extract information from the build system. However, this >> is done in an ad-hoc manner that does not fit properly in the build system. >> >> I ran into this as a problem when trying to implement another change, so >> this needs to be fixed, and should be fixed separately. > > Magnus Ihse Bursie has updated the pull request incrementally with one > additional commit since the last revision: > > Fix broken make:idea test Marked as reviewed by mcimadamore (Reviewer). Works as expected (except for the warnings). I think it's good to go, at least for the time being. I tried creating project (with `java.base` and `jdk.compiler`), tried to open files, build the jdk from the IDE and opening and run some tests using the jtreg plugin. All worked as expected. ------------- PR Review: https://git.openjdk.org/jdk/pull/23140#pullrequestreview-2555502061 PR Comment: https://git.openjdk.org/jdk/pull/23140#issuecomment-2595141302
