On Mon, 18 Nov 2024 20:34:26 GMT, Eirik Bjørsnøs wrote:
>> Please review this PR which cleans up SecurityManager-related code in
>> `java.sql` and `java.sql.rowset` modules post JEP-486
>>
>> There are quite a few changes to review, but all relatively straightforward:
>>
>> `DriverManager`
>>
On Mon, 18 Nov 2024 20:34:26 GMT, Eirik Bjørsnøs wrote:
>> Please review this PR which cleans up SecurityManager-related code in
>> `java.sql` and `java.sql.rowset` modules post JEP-486
>>
>> There are quite a few changes to review, but all relatively straightforward:
>>
>> `DriverManager`
>>
On Mon, 18 Nov 2024 21:20:02 GMT, Chen Liang wrote:
>> Eirik Bjørsnøs has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove ObjectStreamField#getType from UNSUPPORTED_VIRTUAL_METHODS, a
>> leftover from JDK-8344034
>
> test/jdk/jdk/int
On Mon, 18 Nov 2024 20:34:26 GMT, Eirik Bjørsnøs wrote:
>> Please review this PR which cleans up SecurityManager-related code in
>> `java.sql` and `java.sql.rowset` modules post JEP-486
>>
>> There are quite a few changes to review, but all relatively straightforward:
>>
>> `DriverManager`
>>
On Mon, 18 Nov 2024 20:34:26 GMT, Eirik Bjørsnøs wrote:
>> Please review this PR which cleans up SecurityManager-related code in
>> `java.sql` and `java.sql.rowset` modules post JEP-486
>>
>> There are quite a few changes to review, but all relatively straightforward:
>>
>> `DriverManager`
>>
> Please review this PR which cleans up SecurityManager-related code in
> `java.sql` and `java.sql.rowset` modules post JEP-486
>
> There are quite a few changes to review, but all relatively straightforward:
>
> `DriverManager`
> * Remove `SecurityManager::checkPermission` calls in the `setLogW
On Mon, 18 Nov 2024 20:27:20 GMT, Roger Riggs wrote:
> Yes, please cleanup the leftover mention, in CheckCSMs. of
> ObjectStreamField.getType(). And I'll re-review.
Thanks, see 0278c59. This leaves `UNSUPPORTED_VIRTUAL_METHODS` as an empty set.
Should I remove this field and the code using thi
On Mon, 18 Nov 2024 19:47:25 GMT, Eirik Bjørsnøs wrote:
>> Please review this PR which cleans up SecurityManager-related code in
>> `java.sql` and `java.sql.rowset` modules post JEP-486
>>
>> There are quite a few changes to review, but all relatively straightforward:
>>
>> `DriverManager`
>>
On Mon, 18 Nov 2024 19:30:08 GMT, Roger Riggs wrote:
>> Eirik Bjørsnøs has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Revert caller-sensitive inlining of ReflectUtil.forName
>> - SerialJavaObject::getFields is no longer @CallerSensit
> Please review this PR which cleans up SecurityManager-related code in
> `java.sql` and `java.sql.rowset` modules post JEP-486
>
> There are quite a few changes to review, but all relatively straightforward:
>
> `DriverManager`
> * Remove `SecurityManager::checkPermission` calls in the `setLogW
On Mon, 18 Nov 2024 08:37:26 GMT, Eirik Bjørsnøs wrote:
>> Please review this PR which cleans up SecurityManager-related code in
>> `java.sql` and `java.sql.rowset` modules post JEP-486
>>
>> There are quite a few changes to review, but all relatively straightforward:
>>
>> `DriverManager`
>>
On Mon, 18 Nov 2024 08:37:26 GMT, Eirik Bjørsnøs wrote:
>> Please review this PR which cleans up SecurityManager-related code in
>> `java.sql` and `java.sql.rowset` modules post JEP-486
>>
>> There are quite a few changes to review, but all relatively straightforward:
>>
>> `DriverManager`
>>
> Please review this PR which cleans up SecurityManager-related code in
> `java.sql` and `java.sql.rowset` modules post JEP-486
>
> There are quite a few changes to review, but all relatively straightforward:
>
> `DriverManager`
> * Remove `SecurityManager::checkPermission` calls in the `setLogW
On Mon, 18 Nov 2024 08:11:03 GMT, Eirik Bjørsnøs wrote:
> Seems like a clean inline, how does this introduce a behavioural change?
Class.forName's behavior depends on the caller's defining class loader. I don't
know where Brent and/or Lance is on the changes for this module but if you are
taki
On Mon, 18 Nov 2024 08:23:20 GMT, Alan Bateman wrote:
> Class.forName's behavior depends on the caller's defining class loader. I
> don't know where Brent and/or Lance is on the changes for this module but if
> you are taking it then I would prefer if the changes to
> XmlReaderContentHandler w
On Mon, 18 Nov 2024 07:16:32 GMT, Alan Bateman wrote:
> I think Brent and/or Lance have been working on this already.
Happy to yield if Brent/Lance has something cooking. Otherwise, perhaps their
time is better spent as reviewers.
> If you are taking this, can you remove
> src/java.sql.rowset
On Sun, 17 Nov 2024 19:01:24 GMT, Eirik Bjørsnøs wrote:
> Please review this PR which cleans up SecurityManager-related code in
> `java.sql` and `java.sql.rowset` modules post JEP-486
>
> There are quite a few changes to review, but all relatively straightforward:
>
> `DriverManager`
> * Remov
17 matches
Mail list logo
