On Thu, 12 Oct 2023 20:58:21 GMT, Justin Lu wrote:
>> Please review this PR which refactors a number of tests under
>> `test/text/NumberFormat` to use JUnit.
>>
>> During the switch to JUnit, the tests had the following updates (to improve
>> readability)
>> - separate the test data generation
> Please review this PR which refactors a number of tests under
> `test/text/NumberFormat` to use JUnit.
>
> During the switch to JUnit, the tests had the following updates (to improve
> readability)
> - separate the test data generation from the actual execution of the test
> - create distinct
On Wed, 11 Oct 2023 21:15:42 GMT, Justin Lu wrote:
>> test/jdk/java/text/Format/NumberFormat/CurrencyFormat.java line 62:
>>
>>> 60: // currencySymbolsTest() is only ran for COMPAT
>>> 61: private static final boolean isCompat =
>>> 62:
>>> "COMPAT".equals(System.getProperty
On Wed, 11 Oct 2023 21:20:47 GMT, Justin Lu wrote:
>> Please review this PR which refactors a number of tests under
>> `test/text/NumberFormat` to use JUnit.
>>
>> During the switch to JUnit, the tests had the following updates (to improve
>> readability)
>> - separate the test data generation
> Please review this PR which refactors a number of tests under
> `test/text/NumberFormat` to use JUnit.
>
> During the switch to JUnit, the tests had the following updates (to improve
> readability)
> - separate the test data generation from the actual execution of the test
> - create distinct
On Mon, 9 Oct 2023 20:13:39 GMT, Naoto Sato wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Reflect review comments
>
> test/jdk/java/text/Format/NumberFormat/BigDecimalCompatibilityTest.java line
> 162:
>
>> 160:
On Tue, 3 Oct 2023 22:23:11 GMT, Justin Lu wrote:
> Please review this PR which refactors a number of tests under
> `test/text/NumberFormat` to use JUnit.
>
> During the switch to JUnit, the tests had the following updates (to improve
> readability)
> - separate the test data generation from t
Please review this PR which refactors a number of tests under
`test/text/NumberFormat` to use JUnit.
During the switch to JUnit, the tests had the following updates (to improve
readability)
- separate the test data generation from the actual execution of the test
- create distinct test methods s
