On Wed, 11 Oct 2023 21:15:42 GMT, Justin Lu <j...@openjdk.org> wrote:
>> test/jdk/java/text/Format/NumberFormat/CurrencyFormat.java line 62: >> >>> 60: // currencySymbolsTest() is only ran for COMPAT >>> 61: private static final boolean isCompat = >>> 62: >>> "COMPAT".equals(System.getProperty("java.locale.providers")); >> >> This check could be moved into `currencySymbolsTest()` > > I left it as a static declaration as although it is used in > `currencySymbolsTest()`, it is also used in the data provider of > `CurrencyFormatTest()`. Missed that. Thanks. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/16035#discussion_r1355821515