On Wed, 11 Oct 2023 21:20:47 GMT, Justin Lu <j...@openjdk.org> wrote:
>> Please review this PR which refactors a number of tests under >> `test/text/NumberFormat` to use JUnit. >> >> During the switch to JUnit, the tests had the following updates (to improve >> readability) >> - separate the test data generation from the actual execution of the test >> - create distinct test methods so that all the tests aren't just run under >> one big method (e.g. main) > > Justin Lu has updated the pull request incrementally with one additional > commit since the last revision: > > Reflect review comments test/jdk/java/text/Format/NumberFormat/Bug8132125.java line 47: > 45: NumberFormat nf = NumberFormat.getInstance(deCH); > 46: > 47: // "\u2019" as decimal separator, "\u002E" as grouping separator "\u002E" is decimal, "\u2019" is grouping. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/16035#discussion_r1355824830
