Re: RFR: JDK-8295087: Manual Test to Automated Test Conversion [v6]

2022-12-21 Thread Rajan Halade
On Tue, 20 Dec 2022 19:23:10 GMT, Bill Huang wrote: >> This task converts 5 manual tests to automated tests. >> >> sun/security/provider/PolicyParser/ExtDirsDefaultPolicy.java >> sun/security/provider/PolicyParser/ExtDirsChange.java >> sun/security/provider/PolicyParser/ExtDirs.java >> java/s

Re: RFR: JDK-8295087: Manual Test to Automated Test Conversion [v6]

2022-12-21 Thread Rajan Halade
On Wed, 21 Dec 2022 21:37:27 GMT, Bill Huang wrote: >> I have not seen this used in any other tests. It is a good learning, I >> didn't knew that multiple tests in single file are run in parallel. It seems >> like good option. Do you know of any other regression test written this way? > > I did

Re: RFR: JDK-8295087: Manual Test to Automated Test Conversion [v6]

2022-12-21 Thread Bill Huang
On Wed, 21 Dec 2022 20:39:03 GMT, Rajan Halade wrote: >> Multiple "run" in a single test fails the whole test when one test run fails >> and all subsequent test run get terminated. Multiple tests with only one >> "run" each allows all test run to be excused, and they can be run in >> parallel.

Re: RFR: JDK-8295087: Manual Test to Automated Test Conversion [v6]

2022-12-21 Thread Rajan Halade
On Wed, 21 Dec 2022 19:58:18 GMT, Bill Huang wrote: >> test/jdk/sun/security/provider/PolicyParser/ExtDirs.java line 33: >> >>> 31: >>> 32: /* >>> 33: * @test >> >> Why are these tags duplicated here? > > Multiple "run" in a single test fails the whole test when one test run fails > and all

Re: RFR: JDK-8295087: Manual Test to Automated Test Conversion [v6]

2022-12-21 Thread Bill Huang
On Wed, 21 Dec 2022 18:51:32 GMT, Rajan Halade wrote: >> Bill Huang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Implemented review comments. > > test/jdk/sun/security/provider/PolicyParser/ExtDirs.java line 33: > >> 31: >> 32: /* >

Re: RFR: JDK-8295087: Manual Test to Automated Test Conversion [v3]

2022-12-21 Thread Rajan Halade
On Wed, 19 Oct 2022 16:49:33 GMT, Mahendra Chhipa wrote: >> Are you saying that we don't need to run the ExtDir2.policy and >> ExtDir3.policy? > > Its fine, ignore my previous comment. you can add multiple run tags under same test tag, no need to repeat tag, bug, and summary tags. ---

Re: RFR: JDK-8295087: Manual Test to Automated Test Conversion [v6]

2022-12-21 Thread Rajan Halade
On Tue, 20 Dec 2022 19:23:10 GMT, Bill Huang wrote: >> This task converts 5 manual tests to automated tests. >> >> sun/security/provider/PolicyParser/ExtDirsDefaultPolicy.java >> sun/security/provider/PolicyParser/ExtDirsChange.java >> sun/security/provider/PolicyParser/ExtDirs.java >> java/s

Re: RFR: JDK-8295087: Manual Test to Automated Test Conversion [v5]

2022-12-20 Thread Sibabrata Sahoo
On Tue, 20 Dec 2022 19:05:13 GMT, Bill Huang wrote: >> test/jdk/javax/crypto/CryptoPermissions/InconsistentEntries.java line 52: >> >>> 50: private static final String JDK_HOME = >>> System.getProperty("test.jdk"); >>> 51: private static final String TEST_SRC = >>> System.getProperty("

Re: RFR: JDK-8295087: Manual Test to Automated Test Conversion [v6]

2022-12-20 Thread Sibabrata Sahoo
On Tue, 20 Dec 2022 19:23:10 GMT, Bill Huang wrote: >> This task converts 5 manual tests to automated tests. >> >> sun/security/provider/PolicyParser/ExtDirsDefaultPolicy.java >> sun/security/provider/PolicyParser/ExtDirsChange.java >> sun/security/provider/PolicyParser/ExtDirs.java >> java/s

Re: RFR: JDK-8295087: Manual Test to Automated Test Conversion [v6]

2022-12-20 Thread Bill Huang
> This task converts 5 manual tests to automated tests. > > sun/security/provider/PolicyParser/ExtDirsDefaultPolicy.java > sun/security/provider/PolicyParser/ExtDirsChange.java > sun/security/provider/PolicyParser/ExtDirs.java > java/security/Policy/Root/Root.javajava/security/Policy/Root/Root.

Re: RFR: JDK-8295087: Manual Test to Automated Test Conversion [v5]

2022-12-20 Thread Bill Huang
On Fri, 16 Dec 2022 12:06:14 GMT, Sibabrata Sahoo wrote: >> Bill Huang has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains five additional >> commit

Re: RFR: JDK-8295087: Manual Test to Automated Test Conversion [v5]

2022-12-20 Thread Bill Huang
On Fri, 16 Dec 2022 11:48:54 GMT, Sibabrata Sahoo wrote: >> Bill Huang has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains five additional >> commit

Re: RFR: JDK-8295087: Manual Test to Automated Test Conversion [v5]

2022-12-16 Thread Sibabrata Sahoo
On Mon, 5 Dec 2022 19:52:18 GMT, Bill Huang wrote: >> This task converts 5 manual tests to automated tests. >> >> sun/security/provider/PolicyParser/ExtDirsDefaultPolicy.java >> sun/security/provider/PolicyParser/ExtDirsChange.java >> sun/security/provider/PolicyParser/ExtDirs.java >> java/se

Re: RFR: JDK-8295087: Manual Test to Automated Test Conversion [v5]

2022-12-05 Thread Bill Huang
> This task converts 5 manual tests to automated tests. > > sun/security/provider/PolicyParser/ExtDirsDefaultPolicy.java > sun/security/provider/PolicyParser/ExtDirsChange.java > sun/security/provider/PolicyParser/ExtDirs.java > java/security/Policy/Root/Root.javajava/security/Policy/Root/Root.

Re: RFR: JDK-8295087: Manual Test to Automated Test Conversion [v4]

2022-10-19 Thread Bill Huang
> This task converts 5 manual tests to automated tests. > > sun/security/provider/PolicyParser/ExtDirsDefaultPolicy.java > sun/security/provider/PolicyParser/ExtDirsChange.java > sun/security/provider/PolicyParser/ExtDirs.java > java/security/Policy/Root/Root.javajava/security/Policy/Root/Root.

Re: RFR: JDK-8295087: Manual Test to Automated Test Conversion [v3]

2022-10-19 Thread Mahendra Chhipa
On Mon, 17 Oct 2022 16:57:06 GMT, Bill Huang wrote: >> This task converts 5 manual tests to automated tests. >> >> sun/security/provider/PolicyParser/ExtDirsDefaultPolicy.java >> sun/security/provider/PolicyParser/ExtDirsChange.java >> sun/security/provider/PolicyParser/ExtDirs.java >> java/s

Re: RFR: JDK-8295087: Manual Test to Automated Test Conversion [v3]

2022-10-19 Thread Mahendra Chhipa
On Tue, 18 Oct 2022 22:11:57 GMT, Bill Huang wrote: >> test/jdk/javax/crypto/CryptoPermissions/default_local.policy line 4: >> >>> 2: permission javax.crypto.CryptoAllPermission; >>> 3: permission javax.crypto.CryptoPermission "DES", 64; >>> 4: } >> >> please remove extra line. > > I do

Re: RFR: JDK-8295087: Manual Test to Automated Test Conversion [v3]

2022-10-18 Thread Bill Huang
On Tue, 18 Oct 2022 19:53:50 GMT, Mahendra Chhipa wrote: >> Bill Huang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> AssertThrows an exception in InconsistentEntries test. > > test/jdk/javax/crypto/CryptoPermissions/default_local.polic

Re: RFR: JDK-8295087: Manual Test to Automated Test Conversion [v3]

2022-10-18 Thread Mahendra Chhipa
On Mon, 17 Oct 2022 16:57:06 GMT, Bill Huang wrote: >> This task converts 5 manual tests to automated tests. >> >> sun/security/provider/PolicyParser/ExtDirsDefaultPolicy.java >> sun/security/provider/PolicyParser/ExtDirsChange.java >> sun/security/provider/PolicyParser/ExtDirs.java >> java/s

Re: RFR: JDK-8295087: Manual Test to Automated Test Conversion [v3]

2022-10-18 Thread Mahendra Chhipa
On Mon, 17 Oct 2022 16:57:06 GMT, Bill Huang wrote: >> This task converts 5 manual tests to automated tests. >> >> sun/security/provider/PolicyParser/ExtDirsDefaultPolicy.java >> sun/security/provider/PolicyParser/ExtDirsChange.java >> sun/security/provider/PolicyParser/ExtDirs.java >> java/s

Re: RFR: JDK-8295087: Manual Test to Automated Test Conversion [v3]

2022-10-17 Thread Bill Huang
> This task converts 5 manual tests to automated tests. > > sun/security/provider/PolicyParser/ExtDirsDefaultPolicy.java > sun/security/provider/PolicyParser/ExtDirsChange.java > sun/security/provider/PolicyParser/ExtDirs.java > java/security/Policy/Root/Root.javajava/security/Policy/Root/Root.

Re: RFR: JDK-8295087: Manual Test to Automated Test Conversion [v2]

2022-10-17 Thread Bill Huang
On Fri, 14 Oct 2022 15:50:30 GMT, Bill Huang wrote: >> test/jdk/java/security/Policy/Root/Root.java line 48: >> >>> 46: private static final Path TARGET = Paths.get(ROOT, ".java.policy"); >>> 47: public static void main(String[] args) throws Exception { >>> 48: Files.copy(SOURCE,

Re: RFR: JDK-8295087: Manual Test to Automated Test Conversion [v2]

2022-10-17 Thread Bill Huang
> This task converts 5 manual tests to automated tests. > > sun/security/provider/PolicyParser/ExtDirsDefaultPolicy.java > sun/security/provider/PolicyParser/ExtDirsChange.java > sun/security/provider/PolicyParser/ExtDirs.java > java/security/Policy/Root/Root.javajava/security/Policy/Root/Root.

Re: RFR: JDK-8295087: Manual Test to Automated Test Conversion

2022-10-14 Thread Bill Huang
On Fri, 14 Oct 2022 11:00:44 GMT, Mahendra Chhipa wrote: >> This task converts 5 manual tests to automated tests. >> >> sun/security/provider/PolicyParser/ExtDirsDefaultPolicy.java >> sun/security/provider/PolicyParser/ExtDirsChange.java >> sun/security/provider/PolicyParser/ExtDirs.java >> j

Re: RFR: JDK-8295087: Manual Test to Automated Test Conversion

2022-10-14 Thread Mahendra Chhipa
On Mon, 10 Oct 2022 21:39:05 GMT, Bill Huang wrote: > This task converts 5 manual tests to automated tests. > > sun/security/provider/PolicyParser/ExtDirsDefaultPolicy.java > sun/security/provider/PolicyParser/ExtDirsChange.java > sun/security/provider/PolicyParser/ExtDirs.java > java/securit

RFR: JDK-8295087: Manual Test to Automated Test Conversion

2022-10-10 Thread Bill Huang
This task converts 5 manual tests to automated tests. sun/security/provider/PolicyParser/ExtDirsDefaultPolicy.java sun/security/provider/PolicyParser/ExtDirsChange.java sun/security/provider/PolicyParser/ExtDirs.java java/security/Policy/Root/Root.javajava/security/Policy/Root/Root.java javax/