On Mon, 5 Dec 2022 19:52:18 GMT, Bill Huang <bhu...@openjdk.org> wrote:
>> This task converts 5 manual tests to automated tests.
>>
>> sun/security/provider/PolicyParser/ExtDirsDefaultPolicy.java
>> sun/security/provider/PolicyParser/ExtDirsChange.java
>> sun/security/provider/PolicyParser/ExtDirs.java
>> java/security/Policy/Root/Root.javajava/security/Policy/Root/Root.java
>> javax/crypto/CryptoPermissions/InconsistentEntries.java
>
> Bill Huang has updated the pull request with a new target base due to a merge
> or a rebase. The incremental webrev excludes the unrelated changes brought in
> by the merge/rebase. The pull request contains five additional commits since
> the last revision:
>
> - Merge branch 'master' into JDK-8295087
> - Added an extra line to the end of the policy file.
> - AssertThrows an exception in InconsistentEntries test.
> - Refactored to use testng framework for test enviroment setup.
> - Converted security manual tests to automated tests.
test/jdk/javax/crypto/CryptoPermissions/InconsistentEntries.java line 52:
> 50: private static final String JDK_HOME = System.getProperty("test.jdk");
> 51: private static final String TEST_SRC = System.getProperty("test.src");
> 52: private static final Path POLICY_DIR = Paths.get(JDK_HOME, "conf",
> "security",
This doesn't looks like a safe Test to be automated. Can it create conflict
with any other existing Test requiring "testlimited" with
default_local.policy? This need to be verified. Also changing anything inside
an installed JDK probably not a good choice. It's just a thought from my side
and it could be different for others.
test/jdk/sun/security/provider/PolicyParser/ExtDirs.java line 37:
> 35: * @summary standard extensions path is hard-coded in default
> 36: * system policy file
> 37: * @run main/othervm/policy=ExtDirs.policy/secure=default ExtDirs
May be "/secure=default" is optional here.
-------------
PR: https://git.openjdk.org/jdk/pull/10637
