Re: RFR: 8353786: Migrate Vector API math library support to FFM API [v5]

2025-04-18 Thread Vladimir Ivanov
On Thu, 17 Apr 2025 01:36:39 GMT, Xiaohong Gong wrote: >> How does it work now? The code in `generate_vector_math_stubs()` in >> `stubGenerator_aarch64.cpp` only populates `VEC_SIZE_SCALABLE` shapes with >> SVE versions. > > Please see the `addr` definition code in > https://github.com/openjdk

Re: RFR: 8353786: Migrate Vector API math library support to FFM API [v5]

2025-04-17 Thread Xiaohong Gong
On Thu, 17 Apr 2025 18:08:21 GMT, Vladimir Ivanov wrote: >> Please see the `addr` definition code in >> https://github.com/openjdk/jdk/blob/master/src/hotspot/share/opto/vectorIntrinsics.cpp#L1877 >> . If queried `addr` returns `nullptr` for 256-bit vectors, and the arch >> supports scalable v

Re: RFR: 8353786: Migrate Vector API math library support to FFM API [v5]

2025-04-16 Thread Xiaohong Gong
On Wed, 16 Apr 2025 18:26:18 GMT, Vladimir Ivanov wrote: >> src/jdk.incubator.vector/share/classes/jdk/incubator/vector/VectorMathLibrary.java >> line 240: >> >>> 238: if (isAARCH64() && vspecies.vectorBitSize() > 128) { >>> 239: return false; // FIXME: SVE s

Re: RFR: 8353786: Migrate Vector API math library support to FFM API [v5]

2025-04-16 Thread Vladimir Ivanov
On Wed, 16 Apr 2025 02:11:09 GMT, Xiaohong Gong wrote: >> Vladimir Ivanov has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 19 additional >> commi

Re: RFR: 8353786: Migrate Vector API math library support to FFM API [v5]

2025-04-16 Thread Vladimir Ivanov
On Wed, 16 Apr 2025 00:25:59 GMT, Paul Sandoz wrote: >> Vladimir Ivanov has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 19 additional >> commits

Re: RFR: 8353786: Migrate Vector API math library support to FFM API [v5]

2025-04-16 Thread Vladimir Ivanov
On Wed, 16 Apr 2025 01:47:02 GMT, Xiaohong Gong wrote: >> src/hotspot/share/opto/vectorIntrinsics.cpp line 488: >> >>> 486: // V binaryOp(long address, Class vClass, Class >>> elementType, int length, >>> 487: //V v1, V v2, >>> 488: //BinaryOperation defaultImpl) >> >>

Re: RFR: 8353786: Migrate Vector API math library support to FFM API [v5]

2025-04-15 Thread Xiaohong Gong
On Fri, 11 Apr 2025 21:23:52 GMT, Vladimir Ivanov wrote: >> Migrate Vector API math library (SVML and SLEEF) linkage from native code >> (in JVM) to Java FFM API. >> >> Since FFM API doesn't support vector calling conventions yet, migration >> affects only symbol lookup for now. But it still e

Re: RFR: 8353786: Migrate Vector API math library support to FFM API [v5]

2025-04-15 Thread Xiaohong Gong
On Wed, 16 Apr 2025 00:20:07 GMT, Paul Sandoz wrote: >> Vladimir Ivanov has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 19 additional >> commits

Re: RFR: 8353786: Migrate Vector API math library support to FFM API [v5]

2025-04-15 Thread Xiaohong Gong
On Tue, 15 Apr 2025 17:43:52 GMT, Vladimir Ivanov wrote: >> src/jdk.incubator.vector/share/classes/jdk/incubator/vector/VectorMathLibrary.java >> line 198: >> >>> 196: if (vspecies.vectorBitSize() < 128) { >>> 197: return false; // 64-bit vectors are not supported >>

Re: RFR: 8353786: Migrate Vector API math library support to FFM API [v5]

2025-04-15 Thread Paul Sandoz
On Fri, 11 Apr 2025 21:23:52 GMT, Vladimir Ivanov wrote: >> Migrate Vector API math library (SVML and SLEEF) linkage from native code >> (in JVM) to Java FFM API. >> >> Since FFM API doesn't support vector calling conventions yet, migration >> affects only symbol lookup for now. But it still e

Re: RFR: 8353786: Migrate Vector API math library support to FFM API [v5]

2025-04-15 Thread Vladimir Ivanov
On Tue, 15 Apr 2025 09:29:32 GMT, Xiaohong Gong wrote: >> Vladimir Ivanov has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 19 additional >> commi

Re: RFR: 8353786: Migrate Vector API math library support to FFM API [v5]

2025-04-15 Thread Xiaohong Gong
On Fri, 11 Apr 2025 21:23:52 GMT, Vladimir Ivanov wrote: >> Migrate Vector API math library (SVML and SLEEF) linkage from native code >> (in JVM) to Java FFM API. >> >> Since FFM API doesn't support vector calling conventions yet, migration >> affects only symbol lookup for now. But it still e

Re: RFR: 8353786: Migrate Vector API math library support to FFM API [v5]

2025-04-11 Thread Vladimir Ivanov
> Migrate Vector API math library (SVML and SLEEF) linkage from native code (in > JVM) to Java FFM API. > > Since FFM API doesn't support vector calling conventions yet, migration > affects only symbol lookup for now. But it still enables significant > simplifications on JVM side. > > The patc