Re: RFR: 8353786: Migrate Vector API math library support to FFM API [v10]

2025-04-23 Thread Vladimir Ivanov
On Wed, 23 Apr 2025 08:54:23 GMT, Hamlin Li wrote: >> The intention is to align `_features_string` with `_features` which >> enumerates well-known CPU capabilities JVM manages. As of now, >> `_features_string` contains more information, so I introduced >> `_cpu_info_string` to keep it. >> >>

Re: RFR: 8353786: Migrate Vector API math library support to FFM API [v10]

2025-04-23 Thread Hamlin Li
On Wed, 23 Apr 2025 00:23:46 GMT, Vladimir Ivanov wrote: >> A simple fix could be: >> >> diff --git a/src/hotspot/os_cpu/linux_riscv/vm_version_linux_riscv.cpp >> b/src/hotspot/os_cpu/linux_riscv/vm_version_linux_riscv.cpp >> index 484a2a645aa..a785dc65c9e 100644 >> --- a/src/hotspot/os_cpu/lin

Re: RFR: 8353786: Migrate Vector API math library support to FFM API [v10]

2025-04-22 Thread Vladimir Ivanov
On Fri, 18 Apr 2025 16:16:28 GMT, Jorn Vernee wrote: >> Vladimir Ivanov has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 24 additional >> commits

Re: RFR: 8353786: Migrate Vector API math library support to FFM API [v10]

2025-04-22 Thread Vladimir Ivanov
On Tue, 22 Apr 2025 14:46:21 GMT, Ludovic Henry wrote: >> Vladimir Ivanov has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 24 additional >> commi

Re: RFR: 8353786: Migrate Vector API math library support to FFM API [v10]

2025-04-22 Thread Vladimir Ivanov
On Tue, 22 Apr 2025 16:46:44 GMT, Hamlin Li wrote: >> src/hotspot/share/runtime/abstract_vm_version.cpp line 349: >> >>> 347: assert(features_offset <= cpu_info_string_len, ""); >>> 348: if (features_offset < cpu_info_string_len) { >>> 349: assert(cpu_info_string[features_offset + 0] ==

Re: RFR: 8353786: Migrate Vector API math library support to FFM API [v10]

2025-04-22 Thread Vladimir Ivanov
On Tue, 22 Apr 2025 13:45:26 GMT, Hamlin Li wrote: >> Vladimir Ivanov has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 24 additional >> commits s

Re: RFR: 8353786: Migrate Vector API math library support to FFM API [v10]

2025-04-22 Thread Hamlin Li
On Thu, 17 Apr 2025 18:03:47 GMT, Vladimir Ivanov wrote: >> Migrate Vector API math library (SVML and SLEEF) linkage from native code >> (in JVM) to Java FFM API. >> >> Since FFM API doesn't support vector calling conventions yet, migration >> affects only symbol lookup for now. But it still e

Re: RFR: 8353786: Migrate Vector API math library support to FFM API [v10]

2025-04-22 Thread Hamlin Li
On Tue, 22 Apr 2025 16:34:21 GMT, Hamlin Li wrote: >> Vladimir Ivanov has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 24 additional >> commits s

Re: RFR: 8353786: Migrate Vector API math library support to FFM API [v10]

2025-04-22 Thread Ludovic Henry
On Thu, 17 Apr 2025 18:03:47 GMT, Vladimir Ivanov wrote: >> Migrate Vector API math library (SVML and SLEEF) linkage from native code >> (in JVM) to Java FFM API. >> >> Since FFM API doesn't support vector calling conventions yet, migration >> affects only symbol lookup for now. But it still e

Re: RFR: 8353786: Migrate Vector API math library support to FFM API [v10]

2025-04-18 Thread Jorn Vernee
On Thu, 17 Apr 2025 18:03:47 GMT, Vladimir Ivanov wrote: >> Migrate Vector API math library (SVML and SLEEF) linkage from native code >> (in JVM) to Java FFM API. >> >> Since FFM API doesn't support vector calling conventions yet, migration >> affects only symbol lookup for now. But it still e

Re: RFR: 8353786: Migrate Vector API math library support to FFM API [v10]

2025-04-17 Thread Xiaohong Gong
On Thu, 17 Apr 2025 18:03:47 GMT, Vladimir Ivanov wrote: >> Migrate Vector API math library (SVML and SLEEF) linkage from native code >> (in JVM) to Java FFM API. >> >> Since FFM API doesn't support vector calling conventions yet, migration >> affects only symbol lookup for now. But it still e

Re: RFR: 8353786: Migrate Vector API math library support to FFM API [v10]

2025-04-17 Thread Vladimir Ivanov
> Migrate Vector API math library (SVML and SLEEF) linkage from native code (in > JVM) to Java FFM API. > > Since FFM API doesn't support vector calling conventions yet, migration > affects only symbol lookup for now. But it still enables significant > simplifications on JVM side. > > The patc