On Thu, 9 Jan 2025 22:44:15 GMT, Naoto Sato wrote:
>> A simple refinement to the test makes diagnosing failures easier.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Addresses review comments
Thanks for the reviews!
-
On Thu, 9 Jan 2025 22:44:15 GMT, Naoto Sato wrote:
>> A simple refinement to the test makes diagnosing failures easier.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Addresses review comments
Marked as reviewed by joehw (R
On Thu, 9 Jan 2025 22:44:15 GMT, Naoto Sato wrote:
>> A simple refinement to the test makes diagnosing failures easier.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Addresses review comments
Marked as reviewed by jlu (Com
On Thu, 9 Jan 2025 21:43:57 GMT, Justin Lu wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Addresses review comments
>
> test/jdk/tools/jlink/plugins/IncludeLocalesPluginTest.java line 417:
>
>> 415: helper
> A simple refinement to the test makes diagnosing failures easier.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Addresses review comments
-
Changes:
- all: https://git.openjdk.org/jdk/pull/23016/files
- new: https:
On Thu, 9 Jan 2025 18:28:19 GMT, Naoto Sato wrote:
> A simple refinement to the test makes diagnosing failures easier.
Looked through the changes and the swap to a JUnit ParameterizedTest looks good
to me.
test/jdk/tools/jlink/plugins/IncludeLocalesPluginTest.java line 417:
> 415: hel
A simple refinement to the test makes diagnosing failures easier.
-
Commit messages:
- initial commit
Changes: https://git.openjdk.org/jdk/pull/23016/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=23016&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8347146
Stats:
