On Thu, 9 Jan 2025 18:28:19 GMT, Naoto Sato <na...@openjdk.org> wrote:
> A simple refinement to the test makes diagnosing failures easier.
Looked through the changes and the swap to a JUnit ParameterizedTest looks good
to me.
test/jdk/tools/jlink/plugins/IncludeLocalesPluginTest.java line 417:
> 415: helper = Helper.newHelper(isLinkableRuntime);
> 416: if (helper == null) {
> 417: fail("Helper could not be initialized");
Could be `assertNotNull`, but probably best to not use an assertion in the
setup method.
-------------
Marked as reviewed by jlu (Committer).
PR Review: https://git.openjdk.org/jdk/pull/23016#pullrequestreview-2540984215
PR Review Comment: https://git.openjdk.org/jdk/pull/23016#discussion_r1909466470
