On Thu, 9 Jan 2025 21:43:57 GMT, Justin Lu <j...@openjdk.org> wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Addresses review comments
>
> test/jdk/tools/jlink/plugins/IncludeLocalesPluginTest.java line 417:
>
>> 415: helper = Helper.newHelper(isLinkableRuntime);
>> 416: if (helper == null) {
>> 417: fail("Helper could not be initialized");
>
> Could be `assertNotNull`, but probably best to not use an assertion in the
> setup method.
Replaced with assertion here, and one other location. I think it is fine
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23016#discussion_r1909551683
