Re: [jdk24] RFR: 8346739: jpackage tests failed after JDK-8345259

2025-01-08 Thread Severin Gehwolf
On Wed, 8 Jan 2025 15:08:31 GMT, Severin Gehwolf wrote: > Clean backport of a test follow-up for #22849 targeting JDK 24. Please > review! Thanks in advance. Thanks for the reviews! - PR Comment: https://git.openjdk.org/jdk/pull/22972#issuecomment-2578544126

Re: [jdk24] RFR: 8346739: jpackage tests failed after JDK-8345259

2025-01-08 Thread Alexey Semenyuk
On Wed, 8 Jan 2025 15:08:31 GMT, Severin Gehwolf wrote: > Clean backport of a test follow-up for #22849 targeting JDK 24. Please > review! Thanks in advance. LGTM - Marked as reviewed by asemenyuk (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/22972#pullrequestreview-253

Re: [jdk24] RFR: 8346739: jpackage tests failed after JDK-8345259

2025-01-08 Thread Mandy Chung
On Wed, 8 Jan 2025 15:08:31 GMT, Severin Gehwolf wrote: > Clean backport of a test follow-up for #22849 targeting JDK 24. Please > review! Thanks in advance. Marked as reviewed by mchung (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/22972#pullrequestreview-2537763599

Re: [jdk24] RFR: 8346739: jpackage tests failed after JDK-8345259

2025-01-08 Thread Severin Gehwolf
On Wed, 8 Jan 2025 15:08:31 GMT, Severin Gehwolf wrote: > Clean backport of a test follow-up for #22849 targeting JDK 24. Please > review! Thanks in advance. @alexeysemenyukoracle Could you please help review this for JDK 24? The change needing this is about to go into JDK 24 as well in #22849

Re: [jdk24] RFR: 8346739: jpackage tests failed after JDK-8345259

2025-01-08 Thread Aleksey Shipilev
On Wed, 8 Jan 2025 15:08:31 GMT, Severin Gehwolf wrote: > Clean backport of a test follow-up for #22849 targeting JDK 24. Please > review! Thanks in advance. Backport looks fine. - Marked as reviewed by shade (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/22972#pullreque

[jdk24] RFR: 8346739: jpackage tests failed after JDK-8345259

2025-01-08 Thread Severin Gehwolf
Clean backport of a test follow-up for #22849 targeting JDK 24. Please review! Thanks in advance. - Commit messages: - Backport 7ba969a576eb92446e40587fecf98e1e4aba8883 Changes: https://git.openjdk.org/jdk/pull/22972/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22972&ra

Re: RFR: 8346739: jpackage tests failed after JDK-8345259

2024-12-20 Thread Mandy Chung
On Fri, 20 Dec 2024 19:02:38 GMT, Mandy Chung wrote: > A few jpackage tests invoke `jlink --add-modules ALL-MODULE-PATH` without > `--module-path` and they now fail because of JDK-8345259 which requires > `--module-path` to be set when `ALL-MODULE-PATH` is used. The fix is to add > `--add-mod

Re: RFR: 8346739: jpackage tests failed after JDK-8345259

2024-12-20 Thread Mandy Chung
On Fri, 20 Dec 2024 19:02:38 GMT, Mandy Chung wrote: > A few jpackage tests invoke `jlink --add-modules ALL-MODULE-PATH` without > `--module-path` and they now fail because of JDK-8345259 which requires > `--module-path` to be set when `ALL-MODULE-PATH` is used. The fix is to add > `--add-mod

Re: RFR: 8346739: jpackage tests failed after JDK-8345259

2024-12-20 Thread Alexey Semenyuk
On Fri, 20 Dec 2024 19:02:38 GMT, Mandy Chung wrote: > A few jpackage tests invoke `jlink --add-modules ALL-MODULE-PATH` without > `--module-path` and they now fail because of JDK-8345259 which requires > `--module-path` to be set when `ALL-MODULE-PATH` is used. The fix is to add > `--add-mod

Re: RFR: 8346739: jpackage tests failed after JDK-8345259

2024-12-20 Thread Kevin Rushforth
On Fri, 20 Dec 2024 19:02:38 GMT, Mandy Chung wrote: > A few jpackage tests invoke `jlink --add-modules ALL-MODULE-PATH` without > `--module-path` and they now fail because of JDK-8345259 which requires > `--module-path` to be set when `ALL-MODULE-PATH` is used. The fix is to add > `--add-mod

Re: RFR: 8346739: jpackage tests failed after JDK-8345259

2024-12-20 Thread Kevin Rushforth
On Fri, 20 Dec 2024 19:02:38 GMT, Mandy Chung wrote: > A few jpackage tests invoke `jlink --add-modules ALL-MODULE-PATH` without > `--module-path` and they now fail because of JDK-8345259 which requires > `--module-path` to be set when `ALL-MODULE-PATH` is used. The fix is to add > `--add-mod

Re: RFR: 8346739: jpackage tests failed after JDK-8345259

2024-12-20 Thread Kevin Rushforth
On Fri, 20 Dec 2024 19:02:38 GMT, Mandy Chung wrote: > A few jpackage tests invoke `jlink --add-modules ALL-MODULE-PATH` without > `--module-path` and they now fail because of JDK-8345259 which requires > `--module-path` to be set when `ALL-MODULE-PATH` is used. The fix is to add > `--add-mod

RFR: 8346739: jpackage tests failed after JDK-8345259

2024-12-20 Thread Mandy Chung
A few jpackage tests invoke `jlink --add-modules ALL-MODULE-PATH` without `--module-path` and they now fail because of JDK-8345259 which requires `--module-path` to be set when `ALL-MODULE-PATH` is used. The fix is to add `--add-modules $JAVA_HOME/jmods` which was the default before JDK-8345259