On Fri, 20 Dec 2024 19:02:38 GMT, Mandy Chung <mch...@openjdk.org> wrote:

> A few jpackage tests invoke `jlink --add-modules ALL-MODULE-PATH` without 
> `--module-path` and they now fail because of JDK-8345259 which requires 
> `--module-path` to be set when `ALL-MODULE-PATH` is used.  The fix is to add 
> `--add-modules $JAVA_HOME/jmods` which was the default before JDK-8345259.  A 
> separate issue is needed to skip these tests when running on a linkable 
> runtime image without the packaged modules.

Looks good to me.

-------------

Marked as reviewed by kcr (Author).

PR Review: https://git.openjdk.org/jdk/pull/22853#pullrequestreview-2518208291

Reply via email to