On Fri, 20 Dec 2024 19:02:38 GMT, Mandy Chung <mch...@openjdk.org> wrote:
> A few jpackage tests invoke `jlink --add-modules ALL-MODULE-PATH` without > `--module-path` and they now fail because of JDK-8345259 which requires > `--module-path` to be set when `ALL-MODULE-PATH` is used. The fix is to add > `--add-modules $JAVA_HOME/jmods` which was the default before JDK-8345259. A > separate issue is needed to skip these tests when running on a linkable > runtime image without the packaged modules. Thanks Kevin. You point out that PR [22644](https://github.com/openjdk/jdk/pull/22644) changes `ALL-MODULE-PATH` to use `java.desktop`. I prefer to keep this PR to focus on fixing the tests by adding `--module-path` as that's the expected test cases. I will let @jerboaa to do the proper fix for these tests via JDK-8345185. ------------- PR Comment: https://git.openjdk.org/jdk/pull/22853#issuecomment-2557605256
