Re: RFR: 8344086: Remove security manager dependency in FFM

2024-11-13 Thread Sean Mullan
On Wed, 13 Nov 2024 13:48:14 GMT, Per Minborg wrote: > This PR proposes to remove the security manager dependencies in the FFM > implementing classes. I didn't get a chance to review until now, had one small comment. src/java.base/share/classes/jdk/internal/foreign/abi/fallback/LibFallback.jav

Re: RFR: 8344086: Remove security manager dependency in FFM

2024-11-13 Thread Per Minborg
On Wed, 13 Nov 2024 16:37:19 GMT, Per Minborg wrote: >> src/java.base/share/classes/jdk/internal/foreign/SystemLookup.java line 128: >> >>> 126: */ >>> 127: private static Path jdkLibraryPath(String name) { >>> 128: Path javahome = Path.of(System.getProperty("java.home")); >> >

Re: RFR: 8344086: Remove security manager dependency in FFM

2024-11-13 Thread Per Minborg
On Wed, 13 Nov 2024 15:24:26 GMT, Roger Riggs wrote: >> This PR proposes to remove the security manager dependencies in the FFM >> implementing classes. > > src/java.base/share/classes/jdk/internal/foreign/SystemLookup.java line 128: > >> 126: */ >> 127: private static Path jdkLibraryP

Re: RFR: 8344086: Remove security manager dependency in FFM

2024-11-13 Thread Jorn Vernee
On Wed, 13 Nov 2024 13:48:14 GMT, Per Minborg wrote: > This PR proposes to remove the security manager dependencies in the FFM > implementing classes. Marked as reviewed by jvernee (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/22071#pullrequestreview-2433649735

Re: RFR: 8344086: Remove security manager dependency in FFM

2024-11-13 Thread Roger Riggs
On Wed, 13 Nov 2024 13:48:14 GMT, Per Minborg wrote: > This PR proposes to remove the security manager dependencies in the FFM > implementing classes. lgtm src/java.base/share/classes/jdk/internal/foreign/SystemLookup.java line 128: > 126: */ > 127: private static Path jdkLibraryPath

Re: RFR: 8344086: Remove security manager dependency in FFM

2024-11-13 Thread Maurizio Cimadamore
On Wed, 13 Nov 2024 13:48:14 GMT, Per Minborg wrote: > This PR proposes to remove the security manager dependencies in the FFM > implementing classes. Nice cleanup! - Marked as reviewed by mcimadamore (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/22071#pullrequestreview

RFR: 8344086: Remove security manager dependency in FFM

2024-11-13 Thread Per Minborg
This PR proposes to remove the security manager dependencies in the FFM implementing classes. - Commit messages: - Remove security manager related code Changes: https://git.openjdk.org/jdk/pull/22071/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22071&range=00 Issue: h