On Wed, 13 Nov 2024 15:24:26 GMT, Roger Riggs <rri...@openjdk.org> wrote:

>> This PR proposes to remove the security manager dependencies in the FFM 
>> implementing classes.
>
> src/java.base/share/classes/jdk/internal/foreign/SystemLookup.java line 128:
> 
>> 126:      */
>> 127:     private static Path jdkLibraryPath(String name) {
>> 128:         Path javahome = Path.of(System.getProperty("java.home"));
> 
> If not out of scope for this PR:
> System property java.home is available in a static; will need an `import 
> jdk.internal.util.StaticProperty`
> Suggestion:
> 
>         Path javahome = StaticProperty.javaHome();

Let's do that change under a separate PR.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22071#discussion_r1840778192

Reply via email to