On Wed, 13 Nov 2024 16:37:19 GMT, Per Minborg <pminb...@openjdk.org> wrote:
>> src/java.base/share/classes/jdk/internal/foreign/SystemLookup.java line 128:
>>
>>> 126: */
>>> 127: private static Path jdkLibraryPath(String name) {
>>> 128: Path javahome = Path.of(System.getProperty("java.home"));
>>
>> If not out of scope for this PR:
>> System property java.home is available in a static; will need an `import
>> jdk.internal.util.StaticProperty`
>> Suggestion:
>>
>> Path javahome = StaticProperty.javaHome();
>
> Let's do that change under a separate PR.
https://bugs.openjdk.org/browse/JDK-8344134
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22071#discussion_r1840786281
