Re: [jdk24] RFR: 8342469: Improve API documentation for java.lang.classfile.instruction

2024-12-11 Thread Chen Liang
On Tue, 10 Dec 2024 20:51:33 GMT, Chen Liang wrote: > Hi all, > > This pull request contains a backport of commit > [0f035545](https://github.com/openjdk/jdk/commit/0f035545e5c0cd02d11ab8edd5786c1f1f6043a7) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > This is a noreg-

Re: [jdk24] RFR: 8342469: Improve API documentation for java.lang.classfile.instruction

2024-12-11 Thread Adam Sotona
On Tue, 10 Dec 2024 20:51:33 GMT, Chen Liang wrote: > Hi all, > > This pull request contains a backport of commit > [0f035545](https://github.com/openjdk/jdk/commit/0f035545e5c0cd02d11ab8edd5786c1f1f6043a7) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > This is a noreg-

[jdk24] RFR: 8342469: Improve API documentation for java.lang.classfile.instruction

2024-12-10 Thread Chen Liang
Hi all, This pull request contains a backport of commit [0f035545](https://github.com/openjdk/jdk/commit/0f035545e5c0cd02d11ab8edd5786c1f1f6043a7) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. This is a noreg-doc backport - these additions are clarifications to the ClassFile

Re: RFR: 8342469: Improve API documentation for java.lang.classfile.instruction [v6]

2024-12-10 Thread Chen Liang
On Wed, 4 Dec 2024 18:41:53 GMT, Chen Liang wrote: >> Improve the documentation for classfile instructions. Includes links to all >> opcodes, usage notes for instructions, and other various fixes. >> >> API Diff: >> https://cr.openjdk.org/~liach/apidiff/cf-instr/java.base/module-summary.html >

Re: RFR: 8342469: Improve API documentation for java.lang.classfile.instruction [v6]

2024-12-10 Thread Adam Sotona
On Wed, 4 Dec 2024 18:41:53 GMT, Chen Liang wrote: >> Improve the documentation for classfile instructions. Includes links to all >> opcodes, usage notes for instructions, and other various fixes. >> >> API Diff: >> https://cr.openjdk.org/~liach/apidiff/cf-instr/java.base/module-summary.html >

Re: RFR: 8342469: Improve API documentation for java.lang.classfile.instruction [v6]

2024-12-04 Thread Chen Liang
> Improve the documentation for classfile instructions. Includes links to all > opcodes, usage notes for instructions, and other various fixes. > > API Diff: > https://cr.openjdk.org/~liach/apidiff/cf-instr/java.base/module-summary.html > Javadoc: > https://cr.openjdk.org/~liach/javadoc/cf-inst

Re: RFR: 8342469: Improve API documentation for java.lang.classfile.instruction [v5]

2024-11-21 Thread Chen Liang
> Improve the documentation for classfile instructions. Includes links to all > opcodes, usage notes for instructions, and other various fixes. > > API Diff: > https://cr.openjdk.org/~liach/apidiff/cf-instr/java.base/module-summary.html > Javadoc: > https://cr.openjdk.org/~liach/javadoc/cf-inst

Re: RFR: 8342469: Improve API documentation for java.lang.classfile.instruction [v4]

2024-11-21 Thread Chen Liang
On Thu, 21 Nov 2024 10:52:56 GMT, Adam Sotona wrote: >> Chen Liang has updated the pull request incrementally with four additional >> commits since the last revision: >> >> - typo >> - More cleanup >> - Remove a few confusions around bad modeling, some missing exceptions, >> also the labell

Re: RFR: 8342469: Improve API documentation for java.lang.classfile.instruction [v4]

2024-11-21 Thread Adam Sotona
On Wed, 20 Nov 2024 23:03:43 GMT, Chen Liang wrote: >> Improve the documentation for classfile instructions. Includes links to all >> opcodes, usage notes for instructions, and other various fixes. >> >> API Diff: >> https://cr.openjdk.org/~liach/apidiff/cf-instr/java.base/module-summary.html

Re: RFR: 8342469: Improve API documentation for java.lang.classfile.instruction [v4]

2024-11-21 Thread Adam Sotona
On Wed, 20 Nov 2024 23:03:43 GMT, Chen Liang wrote: >> Improve the documentation for classfile instructions. Includes links to all >> opcodes, usage notes for instructions, and other various fixes. >> >> API Diff: >> https://cr.openjdk.org/~liach/apidiff/cf-instr/java.base/module-summary.html

Re: RFR: 8342469: Improve API documentation for java.lang.classfile.instruction [v4]

2024-11-21 Thread Adam Sotona
On Wed, 20 Nov 2024 23:03:43 GMT, Chen Liang wrote: >> Improve the documentation for classfile instructions. Includes links to all >> opcodes, usage notes for instructions, and other various fixes. >> >> API Diff: >> https://cr.openjdk.org/~liach/apidiff/cf-instr/java.base/module-summary.html

Re: RFR: 8342469: Improve API documentation for java.lang.classfile.instruction [v4]

2024-11-20 Thread Chen Liang
On Wed, 20 Nov 2024 23:03:43 GMT, Chen Liang wrote: >> Improve the documentation for classfile instructions. Includes links to all >> opcodes, usage notes for instructions, and other various fixes. >> >> API Diff: >> https://cr.openjdk.org/~liach/apidiff/cf-instr/java.base/module-summary.html

Re: RFR: 8342469: Improve API documentation for java.lang.classfile.instruction [v3]

2024-11-20 Thread Chen Liang
On Tue, 19 Nov 2024 09:40:25 GMT, Adam Sotona wrote: >> Chen Liang has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains six commits: >> >> - Further facelift >> - Merge branch 'master' of https://github.com/openjdk/jdk into >> docs/

Re: RFR: 8342469: Improve API documentation for java.lang.classfile.instruction [v4]

2024-11-20 Thread Chen Liang
> Improve the documentation for classfile instructions. Includes links to all > opcodes, usage notes for instructions, and other various fixes. > > API Diff: > https://cr.openjdk.org/~liach/apidiff/cf-instr/java.base/module-summary.html > Javadoc: > https://cr.openjdk.org/~liach/javadoc/cf-inst

Re: RFR: 8342469: Improve API documentation for java.lang.classfile.instruction [v3]

2024-11-19 Thread Adam Sotona
On Mon, 18 Nov 2024 02:58:31 GMT, Chen Liang wrote: >> Improve the documentation for classfile instructions. Includes links to all >> opcodes, usage notes for instructions, and other various fixes. >> >> API Diff: >> https://cr.openjdk.org/~liach/apidiff/cf-instr/java.base/module-summary.html

Re: RFR: 8342469: Improve API documentation for java.lang.classfile.instruction [v3]

2024-11-19 Thread Adam Sotona
On Mon, 18 Nov 2024 02:58:31 GMT, Chen Liang wrote: >> Improve the documentation for classfile instructions. Includes links to all >> opcodes, usage notes for instructions, and other various fixes. >> >> API Diff: >> https://cr.openjdk.org/~liach/apidiff/cf-instr/java.base/module-summary.html

Re: RFR: 8342469: Improve API documentation for java.lang.classfile.instruction [v3]

2024-11-19 Thread Adam Sotona
On Mon, 18 Nov 2024 02:58:31 GMT, Chen Liang wrote: >> Improve the documentation for classfile instructions. Includes links to all >> opcodes, usage notes for instructions, and other various fixes. >> >> API Diff: >> https://cr.openjdk.org/~liach/apidiff/cf-instr/java.base/module-summary.html

Re: RFR: 8342469: Improve API documentation for java.lang.classfile.instruction [v3]

2024-11-17 Thread Chen Liang
On Mon, 18 Nov 2024 02:58:31 GMT, Chen Liang wrote: >> Improve the documentation for classfile instructions. Includes links to all >> opcodes, usage notes for instructions, and other various fixes. >> >> API Diff: >> https://cr.openjdk.org/~liach/apidiff/cf-instr/java.base/module-summary.html

Re: RFR: 8342469: Improve API documentation for java.lang.classfile.instruction [v3]

2024-11-17 Thread Chen Liang
> Improve the documentation for classfile instructions. Includes links to all > opcodes, usage notes for instructions, and other various fixes. Chen Liang has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains six commits: - Further faceli

Re: RFR: 8342469: Improve API documentation for java.lang.classfile.instruction [v2]

2024-11-15 Thread Chen Liang
> Improve the documentation for classfile instructions. Includes links to all > opcodes, usage notes for instructions, and other various fixes. Chen Liang has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits: - Merge branch

Re: RFR: 8342469: Improve API documentation for java.lang.classfile.instruction [v2]

2024-11-15 Thread Joe Darcy
On Fri, 15 Nov 2024 17:49:58 GMT, Chen Liang wrote: >> Improve the documentation for classfile instructions. Includes links to all >> opcodes, usage notes for instructions, and other various fixes. > > Chen Liang has updated the pull request with a new target base due to a merge > or a rebase.

Re: RFR: 8342469: Improve API documentation for java.lang.classfile.instruction

2024-10-23 Thread Adam Sotona
On Mon, 21 Oct 2024 22:43:42 GMT, Chen Liang wrote: > Improve the documentation for classfile instructions. Includes links to all > opcodes, usage notes for instructions, and other various fixes. Great job done! It would be good to have another pair of eyes to read the new doc, however it look

Re: RFR: 8342469: Improve API documentation for java.lang.classfile.instruction

2024-10-21 Thread Chen Liang
On Mon, 21 Oct 2024 22:43:42 GMT, Chen Liang wrote: > Improve the documentation for classfile instructions. Includes links to all > opcodes, usage notes for instructions, and other various fixes. Proofread a little bit. Since this is huge and there may be mistakes, I will only create a CSR aft

RFR: 8342469: Improve API documentation for java.lang.classfile.instruction

2024-10-21 Thread Chen Liang
Improve the documentation for classfile instructions. Includes links to all opcodes, usage notes for instructions, and other various fixes. - Commit messages: - Typos, long lines - Labels - Wip instr Changes: https://git.openjdk.org/jdk/pull/21625/files Webrev: https://webrevs.