On Wed, 20 Nov 2024 23:03:43 GMT, Chen Liang <li...@openjdk.org> wrote:
>> Improve the documentation for classfile instructions. Includes links to all >> opcodes, usage notes for instructions, and other various fixes. >> >> API Diff: >> https://cr.openjdk.org/~liach/apidiff/cf-instr/java.base/module-summary.html >> Javadoc: >> https://cr.openjdk.org/~liach/javadoc/cf-instr/java.base/java/lang/classfile/instruction/package-summary.html >> >> Please review the associated CSR as well. > > Chen Liang has updated the pull request incrementally with four additional > commits since the last revision: > > - typo > - More cleanup > - Remove a few confusions around bad modeling, some missing exceptions, also > the labelless info models > - Non-int constant values src/java.base/share/classes/java/lang/classfile/instruction/StoreInstruction.java line 76: > 74: * {@return the {@linkplain TypeKind##computational-type > computational type} > 75: * of the value to be stored} The {@link TypeKind#REFERENCE > reference} > 76: * type store instructions also operate on the {@code returnAddress} > type, Where do we expose a TypeKind related to a return address? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21625#discussion_r1851860391
