On Tue, 8 Oct 2024 06:48:59 GMT, Markus KARG wrote:
>> src/java.base/share/classes/java/io/Reader.java line 154:
>>
>>> 152: * have no effect.
>>> 153: *
>>> 154: * After the reader has been closed, the {@code read()},
>>
>> This paragraph is okay but the Reader methods should r
On Mon, 7 Oct 2024 04:43:49 GMT, Chen Liang wrote:
>> src/java.base/share/classes/java/io/Reader.java line 203:
>>
>>> 201: int n = Math.min(length - next, len);
>>> 202: switch (cs) {
>>> 203: case String s -> s.getChars(next, next + n, cbuf,
On Sun, 6 Oct 2024 18:13:14 GMT, Bernd wrote:
>> Markus KARG has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fixup! Reader.of(String)
>>
>> Dropping non-public JavaDocs
>
> test/jdk/java/io/Reader/Of.java line 63:
>
>> 61: @Tes
On Sun, 6 Oct 2024 18:25:15 GMT, Bernd wrote:
>> src/java.base/share/classes/java/io/Reader.java line 231:
>>
>>> 229: public boolean ready() throws IOException {
>>> 230: ensureOpen();
>>> 231: return true;
>>
>> I guess it’s not wrong, but can this
On Mon, 7 Oct 2024 04:44:43 GMT, Chen Liang wrote:
>> src/java.base/share/classes/java/io/Reader.java line 172:
>>
>>> 170: Objects.requireNonNull(source);
>>> 171:
>>> 172: return new Reader() {
>>
>> Maybe make this into a package‑private `CharSequenceReader` so that
>> [`St
On Sun, 6 Oct 2024 18:12:33 GMT, Alan Bateman wrote:
>> Markus KARG has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fixup! Reader.of(String)
>>
>> Dropping non-public JavaDocs
>
> src/java.base/share/classes/java/io/Reader.java line
On Sun, 6 Oct 2024 14:50:48 GMT, Markus KARG wrote:
>> src/java.base/share/classes/java/io/Reader.java line 174:
>>
>>> 172: * @since 24
>>> 173: */
>>> 174: public static Reader of(CharSequence c) {
>>
>> Should we give this factory a more specific name so we don't clash in the
On Sun, 6 Oct 2024 19:24:07 GMT, Brett Okken wrote:
>> Markus KARG has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fixup! Reader.of(String)
>>
>> Dropping non-public JavaDocs
>
> src/java.base/share/classes/java/io/Reader.java line
On Mon, 7 Oct 2024 00:04:40 GMT, ExE Boss wrote:
>> Markus KARG has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fixup! Reader.of(String)
>>
>> Dropping non-public JavaDocs
>
> src/java.base/share/classes/java/io/Reader.java line 172
On Sun, 6 Oct 2024 17:44:53 GMT, Markus KARG wrote:
>> This Pull Requests proposes an implementation for
>> [JDK-8341566](https://bugs.openjdk.org/browse/JDK-8341566): Adding the new
>> method `public static Reader Reader.of(CharSequence)` will return an
>> anonymous, non-synchronized implemen
On Sun, 6 Oct 2024 17:44:53 GMT, Markus KARG wrote:
>> This Pull Requests proposes an implementation for
>> [JDK-8341566](https://bugs.openjdk.org/browse/JDK-8341566): Adding the new
>> method `public static Reader Reader.of(CharSequence)` will return an
>> anonymous, non-synchronized implemen
On Sun, 6 Oct 2024 18:05:28 GMT, Bernd wrote:
>> Markus KARG has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fixup! Reader.of(String)
>>
>> Dropping non-public JavaDocs
>
> src/java.base/share/classes/java/io/Reader.java line 231:
>
On Sun, 6 Oct 2024 17:44:53 GMT, Markus KARG wrote:
>> This Pull Requests proposes an implementation for
>> [JDK-8341566](https://bugs.openjdk.org/browse/JDK-8341566): Adding the new
>> method `public static Reader Reader.of(CharSequence)` will return an
>> anonymous, non-synchronized implemen
On Sun, 6 Oct 2024 17:44:53 GMT, Markus KARG wrote:
>> This Pull Requests proposes an implementation for
>> [JDK-8341566](https://bugs.openjdk.org/browse/JDK-8341566): Adding the new
>> method `public static Reader Reader.of(CharSequence)` will return an
>> anonymous, non-synchronized implemen
On Sun, 6 Oct 2024 17:44:53 GMT, Markus KARG wrote:
>> This Pull Requests proposes an implementation for
>> [JDK-8341566](https://bugs.openjdk.org/browse/JDK-8341566): Adding the new
>> method `public static Reader Reader.of(CharSequence)` will return an
>> anonymous, non-synchronized implemen
On Sun, 6 Oct 2024 17:31:42 GMT, Markus KARG wrote:
>> I recommend adding another test case against an ad-hoc `CharSequence`
>> implementation wrapping a `char[]` in a record, to ensure the generic paths
>> in `read(char[], int, int)` works as intended.
>
> Good idea. But instead, we could also
On Sun, 6 Oct 2024 17:44:53 GMT, Markus KARG wrote:
>> This Pull Requests proposes an implementation for
>> [JDK-8341566](https://bugs.openjdk.org/browse/JDK-8341566): Adding the new
>> method `public static Reader Reader.of(CharSequence)` will return an
>> anonymous, non-synchronized implemen
On Sun, 6 Oct 2024 14:54:22 GMT, Markus KARG wrote:
>> src/java.base/share/classes/java/io/Reader.java line 163:
>>
>>> 161: * {@code transferTo()} methods all throw {@code IOException}.
>>> 162: *
>>> 163: * The {@code markSupported()} method returns {@code true}.
>>
>> Suggest
> This Pull Requests proposes an implementation for
> [JDK-8341566](https://bugs.openjdk.org/browse/JDK-8341566): Adding the new
> method `public static Reader Reader.of(CharSequence)` will return an
> anonymous, non-synchronized implementation of a `Reader` for each kind of
> `CharSequence` im
19 matches
Mail list logo
