On Sun, 6 Oct 2024 18:05:28 GMT, Bernd <d...@openjdk.org> wrote:
>> Markus KARG has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fixup! Reader.of(String)
>>
>> Dropping non-public JavaDocs
>
> src/java.base/share/classes/java/io/Reader.java line 231:
>
>> 229: public boolean ready() throws IOException {
>> 230: ensureOpen();
>> 231: return true;
>
> I guess it’s not wrong, but can this be false when end of source is reached?
> Related to this you already described it is not synchronized but should we
> also describe it does not support changes to the length during “iteration”
> (could be in the same thread).
Ignore my “thinko”/comment. of course it needs to return true for the EOD.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21371#discussion_r1789197653
