On Thu, 5 Sep 2024 00:48:26 GMT, Shaojin Wen wrote:
>> Use fast path for ascii characters 1 to 127 to improve the performance of
>> writing Utf8Entry to BufferWriter.
>
> Shaojin Wen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> suggesti
On Thu, 5 Sep 2024 00:48:26 GMT, Shaojin Wen wrote:
>> Use fast path for ascii characters 1 to 127 to improve the performance of
>> writing Utf8Entry to BufferWriter.
>
> Shaojin Wen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> suggesti
On Thu, 5 Sep 2024 00:48:26 GMT, Shaojin Wen wrote:
>> Use fast path for ascii characters 1 to 127 to improve the performance of
>> writing Utf8Entry to BufferWriter.
>
> Shaojin Wen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> suggesti
> Use fast path for ascii characters 1 to 127 to improve the performance of
> writing Utf8Entry to BufferWriter.
Shaojin Wen has updated the pull request incrementally with one additional
commit since the last revision:
suggestion from @liach
-
Changes:
- all: https://git.open
On Wed, 4 Sep 2024 23:14:35 GMT, Shaojin Wen wrote:
>> test/jdk/java/lang/String/CountNonZeroAscii.java line 35:
>>
>>> 33: * @modules java.base/jdk.internal.access
>>> 34: * @summary test latin1 String countNonZeroAscii
>>> 35: * @run testng/othervm -XX:+CompactStrings CountNonZeroAscii
>>
On Wed, 4 Sep 2024 18:09:31 GMT, Chen Liang wrote:
>> Shaojin Wen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> from @cl4es 's suggestion
>
> test/jdk/java/lang/String/CountNonZeroAscii.java line 35:
>
>> 33: * @modules java.base/jdk
On Wed, 4 Sep 2024 12:01:37 GMT, Shaojin Wen wrote:
>> Use fast path for ascii characters 1 to 127 to improve the performance of
>> writing Utf8Entry to BufferWriter.
>
> Shaojin Wen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> from @cl
On Wed, 4 Sep 2024 11:54:48 GMT, Claes Redestad wrote:
>> Let’s not add this, because normal logic should not pay the cost for
>> abnormal logic
>
> Agreed in principle, but not sure the cost of this quick fail-fast sanity
> test would be noticeable?
If we add this, we should add this before t
On Wed, 4 Sep 2024 12:01:37 GMT, Shaojin Wen wrote:
>> Use fast path for ascii characters 1 to 127 to improve the performance of
>> writing Utf8Entry to BufferWriter.
>
> Shaojin Wen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> from @cl
On Wed, 4 Sep 2024 12:01:37 GMT, Shaojin Wen wrote:
>> Use fast path for ascii characters 1 to 127 to improve the performance of
>> writing Utf8Entry to BufferWriter.
>
> Shaojin Wen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> from @cl
On Wed, 4 Sep 2024 12:01:37 GMT, Shaojin Wen wrote:
>> Use fast path for ascii characters 1 to 127 to improve the performance of
>> writing Utf8Entry to BufferWriter.
>
> Shaojin Wen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> from @cl
> Use fast path for ascii characters 1 to 127 to improve the performance of
> writing Utf8Entry to BufferWriter.
Shaojin Wen has updated the pull request incrementally with one additional
commit since the last revision:
from @cl4es 's suggestion
-
Changes:
- all: https://git.o
On Wed, 4 Sep 2024 11:48:46 GMT, Shaojin Wen wrote:
>> src/java.base/share/classes/jdk/internal/classfile/impl/BufWriterImpl.java
>> line 165:
>>
>>> 163: int countNonZeroAscii = JLA.countNonZeroAscii(str);
>>> 164: int utflen = strlen;
>>> 165: if (countNonZeroAscii !=
On Wed, 4 Sep 2024 10:59:33 GMT, Claes Redestad wrote:
>> Shaojin Wen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> optimize for utf16
>
> src/java.base/share/classes/jdk/internal/classfile/impl/BufWriterImpl.java
> line 165:
>
>> 16
> Use fast path for ascii characters 1 to 127 to improve the performance of
> writing Utf8Entry to BufferWriter.
Shaojin Wen has updated the pull request incrementally with one additional
commit since the last revision:
Unused local variable
-
Changes:
- all: https://git.openj
> Use fast path for ascii characters 1 to 127 to improve the performance of
> writing Utf8Entry to BufferWriter.
Shaojin Wen has updated the pull request incrementally with one additional
commit since the last revision:
Update src/java.base/share/classes/jdk/internal/access/JavaLangAccess.jav
On Tue, 3 Sep 2024 16:27:58 GMT, Shaojin Wen wrote:
>> Use fast path for ascii characters 1 to 127 to improve the performance of
>> writing Utf8Entry to BufferWriter.
>
> Shaojin Wen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> optimize
On Tue, 3 Sep 2024 16:27:58 GMT, Shaojin Wen wrote:
>> Use fast path for ascii characters 1 to 127 to improve the performance of
>> writing Utf8Entry to BufferWriter.
>
> Shaojin Wen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> optimize
On Tue, 3 Sep 2024 16:27:58 GMT, Shaojin Wen wrote:
>> Use fast path for ascii characters 1 to 127 to improve the performance of
>> writing Utf8Entry to BufferWriter.
>
> Shaojin Wen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> optimize
> Use fast path for ascii characters 1 to 127 to improve the performance of
> writing Utf8Entry to BufferWriter.
Shaojin Wen has updated the pull request incrementally with one additional
commit since the last revision:
optimize for utf16
-
Changes:
- all: https://git.openjdk.
On Tue, 3 Sep 2024 15:24:02 GMT, Shaojin Wen wrote:
>> Use fast path for ascii characters 1 to 127 to improve the performance of
>> writing Utf8Entry to BufferWriter.
>
> Shaojin Wen has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - sugges
> Use fast path for ascii characters 1 to 127 to improve the performance of
> writing Utf8Entry to BufferWriter.
Shaojin Wen has updated the pull request incrementally with two additional
commits since the last revision:
- suggestion from @cl4es
- Revert "countGreaterThanZero -> CountNonNegat
On Tue, 3 Sep 2024 14:32:16 GMT, Shaojin Wen wrote:
>> We might rename these to `countAscii` and `countModifiedUtf8Compatible`.
>
> ascii includes '\0', `CountModifiedUtf8Compatible` Newbies don't seem to know
> what it means
I think naming internal low-level methods based precisely on what the
On Tue, 3 Sep 2024 13:22:41 GMT, Shaojin Wen wrote:
>> Use fast path for ascii characters 1 to 127 to improve the performance of
>> writing Utf8Entry to BufferWriter.
>
> Shaojin Wen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> countGre
On Tue, 3 Sep 2024 13:45:26 GMT, Chen Liang wrote:
>> src/java.base/share/classes/jdk/internal/access/JavaLangAccess.java line 397:
>>
>>> 395:
>>> 396: /**
>>> 397: * if string#coder() is Latin1 return the count of string#value()
>>> leading greater than zero, else return 0
>>
>> Ca
On Tue, 3 Sep 2024 12:42:08 GMT, Claes Redestad wrote:
>> Shaojin Wen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update src/java.base/share/classes/java/lang/System.java
>>
>> Co-authored-by: Claes Redestad
>
> src/java.base/s
> Use fast path for ascii characters 1 to 127 to improve the performance of
> writing Utf8Entry to BufferWriter.
Shaojin Wen has updated the pull request incrementally with one additional
commit since the last revision:
countGreaterThanZero -> CountNonNegatives
-
Changes:
- al
On Tue, 3 Sep 2024 12:37:05 GMT, Shaojin Wen wrote:
>> Use fast path for ascii characters 1 to 127 to improve the performance of
>> writing Utf8Entry to BufferWriter.
>
> Shaojin Wen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update s
> Use fast path for ascii characters 1 to 127 to improve the performance of
> writing Utf8Entry to BufferWriter.
Shaojin Wen has updated the pull request incrementally with one additional
commit since the last revision:
Update src/java.base/share/classes/java/lang/System.java
Co-authored
On Tue, 3 Sep 2024 11:27:53 GMT, Shaojin Wen wrote:
>> Use fast path for ascii characters 1 to 127 to improve the performance of
>> writing Utf8Entry to BufferWriter.
>
> Shaojin Wen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> fix test
> Use fast path for ascii characters 1 to 127 to improve the performance of
> writing Utf8Entry to BufferWriter.
Shaojin Wen has updated the pull request incrementally with one additional
commit since the last revision:
fix testcase
-
Changes:
- all: https://git.openjdk.org/jd
> Use fast path for ascii characters 1 to 127 to improve the performance of
> writing Utf8Entry to BufferWriter.
Shaojin Wen has updated the pull request incrementally with two additional
commits since the last revision:
- improve benchmark, from @liach & @cl4es
- remove 256
-
C
On Tue, 3 Sep 2024 09:11:06 GMT, Claes Redestad wrote:
>> Shaojin Wen has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - code style
>> - remove unsafe
>
> src/java.base/share/classes/jdk/internal/classfile/impl/BufWriterImpl.java
> line
> Use fast path for ascii characters 1 to 127 to improve the performance of
> writing Utf8Entry to BufferWriter.
Shaojin Wen has updated the pull request incrementally with two additional
commits since the last revision:
- optimize writeUTF
- stringCoder -> isLatin1
-
Changes:
On Tue, 3 Sep 2024 08:54:39 GMT, Claes Redestad wrote:
>> Shaojin Wen has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - code style
>> - remove unsafe
>
> test/micro/org/openjdk/bench/java/lang/classfile/Utf8EntryWriteTo.java line
> 76:
On Tue, 3 Sep 2024 00:38:40 GMT, Shaojin Wen wrote:
>> Use fast path for ascii characters 1 to 127 to improve the performance of
>> writing Utf8Entry to BufferWriter.
>
> Shaojin Wen has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - code s
On Tue, 3 Sep 2024 00:38:40 GMT, Shaojin Wen wrote:
>> Use fast path for ascii characters 1 to 127 to improve the performance of
>> writing Utf8Entry to BufferWriter.
>
> Shaojin Wen has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - code s
On Tue, 3 Sep 2024 00:38:40 GMT, Shaojin Wen wrote:
>> Use fast path for ascii characters 1 to 127 to improve the performance of
>> writing Utf8Entry to BufferWriter.
>
> Shaojin Wen has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - code s
> Use fast path for ascii characters 1 to 127 to improve the performance of
> writing Utf8Entry to BufferWriter.
Shaojin Wen has updated the pull request incrementally with two additional
commits since the last revision:
- code style
- remove unsafe
-
Changes:
- all: https://g
> Use fast path for ascii characters 1 to 127 to improve the performance of
> writing Utf8Entry to BufferWriter.
Shaojin Wen has updated the pull request incrementally with one additional
commit since the last revision:
bug fix countGreaterThanZero
-
Changes:
- all: https://gi
On Mon, 2 Sep 2024 15:27:59 GMT, Shaojin Wen wrote:
>> Use fast path for ascii characters 1 to 127 to improve the performance of
>> writing Utf8Entry to BufferWriter.
>
> Shaojin Wen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> typo
Th
On Mon, 2 Sep 2024 15:27:59 GMT, Shaojin Wen wrote:
>> Use fast path for ascii characters 1 to 127 to improve the performance of
>> writing Utf8Entry to BufferWriter.
>
> Shaojin Wen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> typo
sr
On Fri, 30 Aug 2024 18:46:08 GMT, Chen Liang wrote:
>> Shaojin Wen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Suggestions from @cl4es, rename hasNegativeOrZeros to
>> isLatin1GreaterThanZero
>
> If a non-ascii is in the middle or t
> Use fast path for ascii characters 1 to 127 to improve the performance of
> writing Utf8Entry to BufferWriter.
Shaojin Wen has updated the pull request incrementally with one additional
commit since the last revision:
typo
-
Changes:
- all: https://git.openjdk.org/jdk/pull/2
> Use fast path for ascii characters 1 to 127 to improve the performance of
> writing Utf8Entry to BufferWriter.
Shaojin Wen has updated the pull request incrementally with one additional
commit since the last revision:
suggestion from @liach
-
Changes:
- all: https://git.open
On Mon, 2 Sep 2024 15:11:56 GMT, Shaojin Wen wrote:
>> Use fast path for ascii characters 1 to 127 to improve the performance of
>> writing Utf8Entry to BufferWriter.
>
> Shaojin Wen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> suggesti
> Use fast path for ascii characters 1 to 127 to improve the performance of
> writing Utf8Entry to BufferWriter.
Shaojin Wen has updated the pull request incrementally with one additional
commit since the last revision:
suggestion from @liach
-
Changes:
- all: https://git.open
On Mon, 2 Sep 2024 14:06:42 GMT, Shaojin Wen wrote:
>> Use fast path for ascii characters 1 to 127 to improve the performance of
>> writing Utf8Entry to BufferWriter.
>
> Shaojin Wen has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev exclude
On Fri, 30 Aug 2024 19:39:32 GMT, Shaojin Wen wrote:
>> Use fast path for ascii characters 1 to 127 to improve the performance of
>> writing Utf8Entry to BufferWriter.
>
> Shaojin Wen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> optimiz
> Use fast path for ascii characters 1 to 127 to improve the performance of
> writing Utf8Entry to BufferWriter.
Shaojin Wen has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The
On Mon, 2 Sep 2024 14:03:55 GMT, Shaojin Wen wrote:
>> Use fast path for ascii characters 1 to 127 to improve the performance of
>> writing Utf8Entry to BufferWriter.
>
> Shaojin Wen has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev exclude
On Fri, 30 Aug 2024 19:39:32 GMT, Shaojin Wen wrote:
>> Use fast path for ascii characters 1 to 127 to improve the performance of
>> writing Utf8Entry to BufferWriter.
>
> Shaojin Wen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> optimiz
> Use fast path for ascii characters 1 to 127 to improve the performance of
> writing Utf8Entry to BufferWriter.
Shaojin Wen has updated the pull request incrementally with one additional
commit since the last revision:
optimize Utf8EntryImpl#writeTo(UTF)
-
Changes:
- all: htt
On Fri, 30 Aug 2024 17:08:33 GMT, Shaojin Wen wrote:
>> Use fast path for ascii characters 1 to 127 to improve the performance of
>> writing Utf8Entry to BufferWriter.
>
> Shaojin Wen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Suggest
> Use fast path for ascii characters 1 to 127 to improve the performance of
> writing Utf8Entry to BufferWriter.
Shaojin Wen has updated the pull request incrementally with one additional
commit since the last revision:
Suggestions from @cl4es, rename hasNegativeOrZeros to isLatin1GreaterThan
On Fri, 30 Aug 2024 05:24:58 GMT, Shaojin Wen wrote:
>> Use fast path for ascii characters 1 to 127 to improve the performance of
>> writing Utf8Entry to BufferWriter.
>
> Shaojin Wen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> add com
On Fri, 30 Aug 2024 05:21:46 GMT, Shaojin Wen wrote:
>> src/java.base/share/classes/jdk/internal/classfile/impl/AbstractPoolEntry.java
>> line 441:
>>
>>> 439: }
>>> 440: else {
>>> 441: int charLength = stringValue.length();
>>
>> In the slo
On Fri, 30 Aug 2024 04:41:15 GMT, Chen Liang wrote:
>> Shaojin Wen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> add comments
>
> src/java.base/share/classes/jdk/internal/classfile/impl/AbstractPoolEntry.java
> line 441:
>
>> 439:
> Use fast path for ascii characters 1 to 127 to improve the performance of
> writing Utf8Entry to BufferWriter.
Shaojin Wen has updated the pull request incrementally with one additional
commit since the last revision:
add comments
-
Changes:
- all: https://git.openjdk.org/jd
On Thu, 29 Aug 2024 14:38:20 GMT, Shaojin Wen wrote:
> Use fast path for ascii characters 1 to 127 to improve the performance of
> writing Utf8Entry to BufferWriter.
src/java.base/share/classes/jdk/internal/access/JavaLangAccess.java line 394:
> 392: void inflateBytesToChars(byte[] src, in
Use fast path for ascii characters 1 to 127 to improve the performance of
writing Utf8Entry to BufferWriter.
-
Commit messages:
- bug fix
- optimize Utf8EntryImpl#writeTo
Changes: https://git.openjdk.org/jdk/pull/20772/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=20772
61 matches
Mail list logo
