On Wed, 4 Sep 2024 23:14:35 GMT, Shaojin Wen <s...@openjdk.org> wrote:
>> test/jdk/java/lang/String/CountNonZeroAscii.java line 35: >> >>> 33: * @modules java.base/jdk.internal.access >>> 34: * @summary test latin1 String countNonZeroAscii >>> 35: * @run testng/othervm -XX:+CompactStrings CountNonZeroAscii >> >> You are using the `testng` driver for a `main` test. I can probably fix it >> quickly. > > Is it recommended to change it to this? > > /* > * @test > * @modules java.base/jdk.internal.access > * @summary test latin1 String countNonZeroAscii > * @run main/othervm -XX:+CompactStrings CountNonZeroAscii > * @run main/othervm -XX:-CompactStrings CountNonZeroAscii > */ > `` Yes, that fixes this test. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20772#discussion_r1744626250
