On Mon, 2 Sep 2024 15:11:56 GMT, Shaojin Wen <s...@openjdk.org> wrote:
>> Use fast path for ascii characters 1 to 127 to improve the performance of
>> writing Utf8Entry to BufferWriter.
>
> Shaojin Wen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> suggestion from @liach
test/micro/org/openjdk/bench/java/lang/classfile/Utf8EntryWriteTo.java line 98:
> 96: @Benchmark
> 97: public void writeTo(Blackhole bh) {
> 98: ClassFile.of()
You need to either return the build result or bh.consume the build result.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20772#discussion_r1741053939
