On Wed, 23 Oct 2024 06:14:52 GMT, Chen Liang wrote:
>> @cl4es discovered that Stack Map generation in ClassFile API uses
>> `componentType` and `arrayType` for `aaload` `aastore` instructions, which
>> are currently quite slow. We can split out array class descriptors from
>> class or interfac
On Wed, 23 Oct 2024 06:14:52 GMT, Chen Liang wrote:
>> @cl4es discovered that Stack Map generation in ClassFile API uses
>> `componentType` and `arrayType` for `aaload` `aastore` instructions, which
>> are currently quite slow. We can split out array class descriptors from
>> class or interfac
On Wed, 23 Oct 2024 06:14:52 GMT, Chen Liang wrote:
>> @cl4es discovered that Stack Map generation in ClassFile API uses
>> `componentType` and `arrayType` for `aaload` `aastore` instructions, which
>> are currently quite slow. We can split out array class descriptors from
>> class or interfac
On Wed, 23 Oct 2024 06:14:52 GMT, Chen Liang wrote:
>> @cl4es discovered that Stack Map generation in ClassFile API uses
>> `componentType` and `arrayType` for `aaload` `aastore` instructions, which
>> are currently quite slow. We can split out array class descriptors from
>> class or interfac
> @cl4es discovered that Stack Map generation in ClassFile API uses
> `componentType` and `arrayType` for `aaload` `aastore` instructions, which
> are currently quite slow. We can split out array class descriptors from class
> or interfaces to support faster `arrayType` and `componentType` opera
On Wed, 23 Oct 2024 04:20:49 GMT, Chen Liang wrote:
>> @cl4es discovered that Stack Map generation in ClassFile API uses
>> `componentType` and `arrayType` for `aaload` `aastore` instructions, which
>> are currently quite slow. We can split out array class descriptors from
>> class or interfac
On Tue, 8 Oct 2024 01:24:07 GMT, Chen Liang wrote:
>> That said, can you leave a quick review on CSR
>> https://bugs.openjdk.org/browse/JDK-8340963 too?
>
> I think I will do this in another patch that adds it to `ConstantDescs` -
> there's a place in `ConstantDescs` that could have used it, bu
On Wed, 23 Oct 2024 04:09:37 GMT, Mandy Chung wrote:
>> Chen Liang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Relax displayName spec
>
> src/java.base/share/classes/java/lang/constant/ClassDesc.java line 278:
>
>> 276:
>> 277:
> @cl4es discovered that Stack Map generation in ClassFile API uses
> `componentType` and `arrayType` for `aaload` `aastore` instructions, which
> are currently quite slow. We can split out array class descriptors from class
> or interfaces to support faster `arrayType` and `componentType` opera
On Tue, 22 Oct 2024 04:50:29 GMT, Chen Liang wrote:
>> @cl4es discovered that Stack Map generation in ClassFile API uses
>> `componentType` and `arrayType` for `aaload` `aastore` instructions, which
>> are currently quite slow. We can split out array class descriptors from
>> class or interfac
On Tue, 22 Oct 2024 23:48:34 GMT, Mandy Chung wrote:
>> I believe the specification for class or interface display name is too
>> tight: if we have `java.awt.List` versus `java.util.List`, our current
>> implementation prints `List` for both cases. It makes sense for an
>> implementation to pr
On Tue, 22 Oct 2024 23:29:29 GMT, Chen Liang wrote:
>> src/java.base/share/classes/java/lang/constant/ClassDesc.java line 278:
>>
>>> 276:
>>> 277: /**
>>> 278: * {@return a human-readable name for this {@code ClassDesc}}
>>
>> I don't see the merit of making the string representation
On Tue, 22 Oct 2024 20:53:14 GMT, Mandy Chung wrote:
>> Chen Liang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Relax displayName spec
>
> src/java.base/share/classes/java/lang/constant/ClassDesc.java line 278:
>
>> 276:
>> 277:
On Tue, 22 Oct 2024 04:50:29 GMT, Chen Liang wrote:
>> @cl4es discovered that Stack Map generation in ClassFile API uses
>> `componentType` and `arrayType` for `aaload` `aastore` instructions, which
>> are currently quite slow. We can split out array class descriptors from
>> class or interfac
> @cl4es discovered that Stack Map generation in ClassFile API uses
> `componentType` and `arrayType` for `aaload` `aastore` instructions, which
> are currently quite slow. We can split out array class descriptors from class
> or interfaces to support faster `arrayType` and `componentType` opera
> @cl4es discovered that Stack Map generation in ClassFile API uses
> `componentType` and `arrayType` for `aaload` `aastore` instructions, which
> are currently quite slow. We can split out array class descriptors from class
> or interfaces to support faster `arrayType` and `componentType` opera
On Tue, 8 Oct 2024 21:13:47 GMT, Mandy Chung wrote:
>> So like `if (rank <= 0) throw ConstantUtils.rankNotPositive(rank);` at
>> individual use sites?
>
> I meant no need to have a utility method. Just do this:
>
> Suggestion:
>
> public static void validateArrayDepth(int rank) {
>
> @cl4es discovered that Stack Map generation in ClassFile API uses
> `componentType` and `arrayType` for `aaload` `aastore` instructions, which
> are currently quite slow. We can split out array class descriptors from class
> or interfaces to support faster `arrayType` and `componentType` opera
On Tue, 8 Oct 2024 21:04:47 GMT, Chen Liang wrote:
>> src/java.base/share/classes/jdk/internal/constant/ConstantUtils.java line
>> 313:
>>
>>> 311: throw new IllegalArgumentException("rank " + rank + " is
>>> not a positive value");
>>> 312: }
>>> 313: }
>>
>> Suggest
On Tue, 8 Oct 2024 19:42:14 GMT, Mandy Chung wrote:
>> Chen Liang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> mlchung suggestions: elementType, improve utility methods
>
> src/java.base/share/classes/jdk/internal/constant/ConstantUti
On Tue, 8 Oct 2024 20:46:13 GMT, Chen Liang wrote:
>> src/java.base/share/classes/java/lang/constant/ClassDesc.java line 281:
>>
>>> 279: *
>>> 280: * @implSpec
>>> 281: * The implementations return the simple name
>>
>> Suggestion:
>>
>> * The implementation returns the si
On Tue, 8 Oct 2024 19:47:06 GMT, Mandy Chung wrote:
>> Chen Liang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> mlchung suggestions: elementType, improve utility methods
>
> src/java.base/share/classes/java/lang/constant/ClassDesc.java
On Tue, 8 Oct 2024 01:13:37 GMT, Chen Liang wrote:
>> @cl4es discovered that Stack Map generation in ClassFile API uses
>> `componentType` and `arrayType` for `aaload` `aastore` instructions, which
>> are currently quite slow. We can split out array class descriptors from
>> class or interface
On Tue, 8 Oct 2024 19:32:34 GMT, Chen Liang wrote:
>> @cl4es discovered that Stack Map generation in ClassFile API uses
>> `componentType` and `arrayType` for `aaload` `aastore` instructions, which
>> are currently quite slow. We can split out array class descriptors from
>> class or interface
On Tue, 8 Oct 2024 19:32:34 GMT, Chen Liang wrote:
>> @cl4es discovered that Stack Map generation in ClassFile API uses
>> `componentType` and `arrayType` for `aaload` `aastore` instructions, which
>> are currently quite slow. We can split out array class descriptors from
>> class or interface
On Tue, 8 Oct 2024 19:16:00 GMT, Chen Liang wrote:
>> src/java.base/share/classes/jdk/internal/constant/ArrayClassDescImpl.java
>> line 81:
>>
>>> 79: throw new IllegalStateException(
>>> 80: "Cannot create an array type descriptor with more than "
>>> 81:
On Tue, 8 Oct 2024 01:13:37 GMT, Chen Liang wrote:
>> @cl4es discovered that Stack Map generation in ClassFile API uses
>> `componentType` and `arrayType` for `aaload` `aastore` instructions, which
>> are currently quite slow. We can split out array class descriptors from
>> class or interface
> @cl4es discovered that Stack Map generation in ClassFile API uses
> `componentType` and `arrayType` for `aaload` `aastore` instructions, which
> are currently quite slow. We can split out array class descriptors from class
> or interfaces to support faster `arrayType` and `componentType` opera
On Tue, 8 Oct 2024 18:16:34 GMT, Mandy Chung wrote:
>> Chen Liang has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains nine commits:
>>
>> - class or interface descriptor renamed for clarity
>> - Merge branch 'master' of https://gith
On Tue, 8 Oct 2024 01:13:37 GMT, Chen Liang wrote:
>> @cl4es discovered that Stack Map generation in ClassFile API uses
>> `componentType` and `arrayType` for `aaload` `aastore` instructions, which
>> are currently quite slow. We can split out array class descriptors from
>> class or interface
On Tue, 8 Oct 2024 01:13:37 GMT, Chen Liang wrote:
>> @cl4es discovered that Stack Map generation in ClassFile API uses
>> `componentType` and `arrayType` for `aaload` `aastore` instructions, which
>> are currently quite slow. We can split out array class descriptors from
>> class or interface
On Wed, 25 Sep 2024 20:00:42 GMT, Chen Liang wrote:
>> This patch already has a CSR for trivial signature changes. The real
>> difficulty lies in how we should name our new array class descriptors,
>> `Object_array` or `ObjectArray` or what else?
>
> That said, can you leave a quick review on C
On Fri, 4 Oct 2024 18:08:53 GMT, Jorn Vernee wrote:
>> Chen Liang has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains nine commits:
>>
>> - class or interface descriptor renamed for clarity
>> - Merge branch 'master' of https://gith
> @cl4es discovered that Stack Map generation in ClassFile API uses
> `componentType` and `arrayType` for `aaload` `aastore` instructions, which
> are currently quite slow. We can split out array class descriptors from class
> or interfaces to support faster `arrayType` and `componentType` opera
On Fri, 4 Oct 2024 18:24:37 GMT, Chen Liang wrote:
>> src/java.base/share/classes/jdk/internal/constant/ArrayClassDescImpl.java
>> line 116:
>>
>>> 114: sb.append(componentDesc);
>>> 115: return sb.toString();
>>> 116: }
>>
>> Is there really that much benefit in lazily com
On Fri, 4 Oct 2024 17:38:51 GMT, Jorn Vernee wrote:
>> @cl4es discovered that Stack Map generation in ClassFile API uses
>> `componentType` and `arrayType` for `aaload` `aastore` instructions, which
>> are currently quite slow. We can split out array class descriptors from
>> class or interfac
On Wed, 21 Aug 2024 20:25:07 GMT, Chen Liang wrote:
> @cl4es discovered that Stack Map generation in ClassFile API uses
> `componentType` and `arrayType` for `aaload` `aastore` instructions, which
> are currently quite slow. We can split out array class descriptors from class
> or interfaces t
On Wed, 25 Sep 2024 20:00:12 GMT, Chen Liang wrote:
>> src/java.base/share/classes/java/lang/invoke/InvokerBytecodeGenerator.java
>> line 79:
>>
>>> 77: private static final ClassDesc CD_LambdaForm_Name =
>>> ReferenceClassDescImpl.ofValidated("Ljava/lang/invoke/LambdaForm$Name;");
>>> 78:
On Wed, 25 Sep 2024 19:53:13 GMT, Claes Redestad wrote:
>> @cl4es discovered that Stack Map generation in ClassFile API uses
>> `componentType` and `arrayType` for `aaload` `aastore` instructions, which
>> are currently quite slow. We can split out array class descriptors from
>> class or inte
On Wed, 21 Aug 2024 20:25:07 GMT, Chen Liang wrote:
> @cl4es discovered that Stack Map generation in ClassFile API uses
> `componentType` and `arrayType` for `aaload` `aastore` instructions, which
> are currently quite slow. We can split out array class descriptors from class
> or interfaces t
On Wed, 21 Aug 2024 20:25:07 GMT, Chen Liang wrote:
> @cl4es discovered that Stack Map generation in ClassFile API uses
> `componentType` and `arrayType` for `aaload` `aastore` instructions, which
> are currently quite slow. We can split out array class descriptors from class
> or interfaces t
On Wed, 21 Aug 2024 20:25:07 GMT, Chen Liang wrote:
> @cl4es discovered that Stack Map generation in ClassFile API uses
> `componentType` and `arrayType` for `aaload` `aastore` instructions, which
> are currently quite slow. We can split out array class descriptors from class
> or interfaces t
@cl4es discovered that Stack Map generation in ClassFile API uses
`componentType` and `arrayType` for `aaload` `aastore` instructions, which are
currently quite slow. We can split out array class descriptors from class or
interfaces to support faster `arrayType` and `componentType` operations.
43 matches
Mail list logo
